Check it in!
-
David completed a small application (well, sort off). Now he had to check in the source code into our source code repository.
So he did.Bernie found many interesting files and folders in his check-in, e.g.
Build\WindowsNoEditor\FileOpenOrder containing 2 log files (and nothing else)
Content\Developers\Collections - an empty folder
Content\Developers\David\Collections - an empty folder
Eigene Dateien that's the German localization for My Documents. Seems to contain actually important things: many bitmaps are there.
Saved\Autosaves looks like some backup folder
Saved\Backup contains many previous versions
Saved\Crashes contains 23 folders with crash reports
Saved\Logs contains several log files
Saved\Tempa large folder hierarchy with some temp filesBernie is absolutely sure that they'll need such
crapfiles in their source code repository. Without them, nobody will be able to compile David's greatest achievement ever.
-
-
@BernieTheBernie said in Check it in!:
Without them, nobody will be able to compile David's greatest achievement ever.
This seems to carry the quite possibly unwarranted implication that it would be possible to "compile" the "application" with the files. I would expect this not to be the case. What does compilation consist of? Docker?
-
@Gribnit said in Check it in!:
@BernieTheBernie said in Check it in!:
Without them, nobody will be able to compile David's greatest achievement ever.
This seems to carry the quite possibly unwarranted implication that it would be possible to "compile" the "application" with the files. I would expect this not to be the case. What does compilation consist of? Docker?
Nobody has tried upto now...
And who ever will do so, will prove you right, I guess.
-
@BernieTheBernie said in Check it in!:
Content\Developers\Collections - an empty folder
Content\Developers\David\Collections - an empty folderYou wouldn't have this problem if you used real version control system
-
@Gąska said in Check it in!:
@BernieTheBernie said in Check it in!:
Content\Developers\Collections - an empty folder
Content\Developers\David\Collections - an empty folderYou wouldn't have this problem if you used real version control system
No, that's specifically an Unreal thing.
INB4: that's the joke.
-
Meanwhile, David committed an Update. This new commit contains - again - many useful files and folders.
For example,
Binaries\Win32\Demo5.exe Binaries\Win32\Demo5.exp Binaries\Win32\Demo5.lib Binaries\Win32\Demo5.pdb Binaries\Win32\Demo5.target
So, @Gribnit , there won't be any problems with compiling, because David just checks in the executable, too.
Then comes a new folder hierarchy Intermediate with sub folders Build, Config, Source, Staging.
Of course, also Saved\Autosaves, Saved\Backup, Saved\Cooked, Saved\Crashes, Saved\StagedBuilds, Saved\Temp received some additional "content".
Overall, some 1000 extra files. David is a very productive programmer, at least when we evaluate his commits.
-
@BernieTheBernie doesn't UE4 come with a .gitignore file that stops most of that from happening? And, if you're not using git, why haven't you translated it to whatever version your source control server uses to stop the shenanigans?
Edit: if you want, I can share my p4ignore if you're using perforce.
-
@BernieTheBernie has anyone told him he's doing it wrong?
-
@Gąska Can we persuade David to work on ?
-
@dkf it would certainly improve quality of their codebase.
-
@BernieTheBernie said in Check it in!:
So, @Gribnit , there won't be any problems with compiling, because David just checks in the executable, too.
This guy is saving time in the build process - he deserves a raise.