"Drag and Drop Images Here" overlay should cover entire viewport
-
the Drag and Drop Images Here overlay should cover the entire viewport as dropping images when that overlay is not active will cause the browser to open the dropped image in the current tab, which is undesired behavior.
-
@accalia And it should allow me to upload .mp4s too. Also 2mb is too small for a proper otter video. Last but not least I can only post once every 10 seconds. like wtf!
Do gifs work in the forum?
-
@DogsB said in "Drag and Drop Images Here" overlay should cover entire viewport:
Do gifs work in the forum?
.... looks like it.
-
@accalia +1. I've done this too.
-
@accalia said in "Drag and Drop Images Here" overlay should cover entire viewport:
@DogsB said in "Drag and Drop Images Here" overlay should cover entire viewport:
Do gifs work in the forum?
.... looks like it.
-
-
@accalia may I assume this was prompted by the April fools CSS topic?
Either way, the default behaviour is bad UX. It should be a positive reaction instead of taking you away from the site, which is clearly negative. If anything if you miss we should just do nothing.
But the drop target needs to be bigger yes.
-
@julianlam said in "Drag and Drop Images Here" overlay should cover entire viewport:
may I assume this was prompted by the April fools CSS topic?
not really - blakeyrant already pissed and moaned about this problem in his "nodebb doesn't work on my special snowflake pc" topic.
-
@julianlam said in "Drag and Drop Images Here" overlay should cover entire viewport:
But the drop target needs to be bigger yes.
Yes, the whole viewport.
-
@julianlam said in "Drag and Drop Images Here" overlay should cover entire viewport:
@accalia may I assume this was prompted by the April fools CSS topic?
>_>
<_<
>_>
<_<
maaaaaaaaaaaaaaaaaybe?
@darkmatter said in "Drag and Drop Images Here" overlay should cover entire viewport:
not really - blakeyrant already pissed and moaned about this problem in his "nodebb doesn't work on my special snowflake pc" topic.
well maybe. i havent even entered that topic in a while. it was the april fools topic that prompted me to do my testing and file the bug.
-
@loopback0 said in "Drag and Drop Images Here" overlay should cover entire viewport:
Yes, the whole viewport.
Personally, I'd settle for the whole composer
-
@julianlam said in "Drag and Drop Images Here" overlay should cover entire viewport:
may I assume this was prompted by the April fools CSS topic?
No, I've noticed it before. The only new thing is the blue haze that actually shows you that it doesn't cover the viewport properly. Before, I'd try to drag a picture and it'd just do nothing if I tried to drop it near the lower edge of the textarea.
I guess it'll only replace the page if you drop it in the lower margin below the textarea. That'd be really annoying, but it doesn't happen if you drop it in the textarea because the default drop handler for textareas just ignores anything that's not text.
-
@accalia Serously. At least the strange rectangle it DOES cover isn't invisible now (thanks whoever keeps adding that hideous blue leftover-spray-paint CSS to everything), but why the hell was it implemented that way in the first place?
-
@julianlam said in "Drag and Drop Images Here" overlay should cover entire viewport:
Either way, the default behaviour is bad UX.
Yes, as are about 57 other default behaviors around here. you BADLY need a UX person. Or to do this strange concept totally foreign to open source developers, I think it's called "testing stuff".
Also you misspelled "behavior".
@julianlam said in "Drag and Drop Images Here" overlay should cover entire viewport:
It should be a positive reaction instead of taking you away from the site, which is clearly negative.
Made worse by the fact that your Back button is broken, so when you do get taken away from the site ALL THE TEXT YOU TYPED IN THE POST IS GONE!
(In all fairness, Ben L tells me there's a magical button called "show composer" that brings the post back, but since it can only been seen by fairy-folk or those wielding silver weapons sanctified by a Priest of Arkay, I'm not going to count that as a solution.)
-
@blakeyrat Also, you need to look up the concept of "z-order":
Look at that fucking tools menu. Look at it.
Hey I know a guy who knows all about z-order, he's in that "quadnary" computer thread, you should hire him. Probably better at UX than whoever you got doing it now. (Satan, I assume.)
-
@blakeyrat said in "Drag and Drop Images Here" overlay should cover entire viewport:
"testing stuff".
By the way, I submitted a PR to generate code coverage when the unit tests are run. The current statement-level coverage is 32.95%
-
@Yamikuronue said in "Drag and Drop Images Here" overlay should cover entire viewport:
By the way, I submitted a PR to generate code coverage when the unit tests are run. The current statement-level coverage is 32.95%
Unit tests are fucking useless for UX problems.
This forum needs ACTUAL testing by ACTUAL human beings. I'm so fucking sick of these open source developers who think they just don't have to actually test anything, and they just shove out all this buggy awful shit into the world and what's worse of all: they don't even seem to give a shitty that it's buggy awful shit.
Whatever, you've all heard this before. I work for a company that creates quality software with good testing, plenty of UX people, meeting all kinds of legislative quality bars and certifications, but do you ever read an article on Hacker News about that? No. You only read, "yet another buggy incomplete untested shitty open source project! Isn't open source so great awesome terrific!" Well the answer is no. No it is not.
-
@blakeyrat said in "Drag and Drop Images Here" overlay should cover entire viewport:
Look at that fucking tools menu. Look at it.
I think that's a result of the april fool's CSS. Doesn't happen in my dev environment that doesn't have this applied.
I look forward to your humorless rant about that, too, BTW.
-
@boomzilla said in "Drag and Drop Images Here" overlay should cover entire viewport:
I think that's a result of the april fool's CSS.
I don't give a fuck. Broken is broken.
Untested prank CSS is STILL UNTESTED BROKEN SHIT. Being used for a prank doesn't somehow make it "working correctly" as if by magic.
-
@blakeyrat said in "Drag and Drop Images Here" overlay should cover entire viewport:
I don't give a fuck. Broken is broken.
Your broken.
@blakeyrat said in "Drag and Drop Images Here" overlay should cover entire viewport:
Untested prank CSS is STILL UNTESTED BROKEN SHIT. Being used for a prank doesn't somehow make it "working correctly" as if by magic.
Gibberish. It seems to be working marvelously!
-
Wait... are you fucking kidding me? The drop element has inline styles to position and size it... and it's a fucking child of the
.composer-container
which is the exact size it needs to be!WTF.
-
@anotherusername Those inline styles aren't in the template code:
And I don't see them being added anywhere… @ben_lubar, is this something you've added/changed?
-
@RaceProUK https://github.com/NodeBB/nodebb-plugin-composer-default/blob/c0d80f10f34e00fe4e3e80a7449f2dffb4b0c8c2/static/lib/composer/uploads.js#L97-L110
-
@RaceProUK It's doing it with Javascript when you drag something over/off it.
Nice side effect/: if you drag something onto the composer but not onto the drop area, then drag it back off the composer without ever dragging it over the drop area, the drop area doesn't go back to
display:none
like it oughta.
-
@ben_lubar It would help if you linked to the lines in question
-
@RaceProUK I did, but
someeveryone asked me to re-enable iframely.
-
@ben_lubar Fair enough; what lines should I be looking at?
-
@RaceProUK #L97-L110
-
@ben_lubar said in "Drag and Drop Images Here" overlay should cover entire viewport:
@RaceProUK I did, but someeveryone asked me to re-enable iframely.
WHO asked that? iframely is awful.
Could we get some kind of governance here instead of you just randomly doing shit for no reason?
-
Adding this fixes it.
.imagedrop { top: 0 !important; height: 100% !important; left: 0; } .imagedrop > div { position: relative; top: 50%; transform: translatey(-50%); }
-
@blakeyrat said in "Drag and Drop Images Here" overlay should cover entire viewport:
Yes, as are about 57 other default behaviors around here. you BADLY need a UX person. Or to do this strange concept totally foreign to open source developers, I think it's called "testing stuff".
I agree.
My niche is UX and it feels like there are zero UX skills out there.
The fact that selects are still practically unstylable and that there are frameworks to substitute in place, are good examples of how UX seems to not even be a consideration of browsers these days.