CheckStyle code review.



  • @blakeyrat said:

    While I admit that is true, it still doesn't really address my shock that nobody in the mainframe development community has ever, in 20 years, attempted to build a better tool for this? Ever? It beggars belief-- what the hell are you people doing all day? Especially since it seems like the requirements would be pretty basic.
     

    Having to feed from their systems (and worse yet use screen scrapers to automate manual steps in their systems) I also wonder what they are doing.  Though this could also be due to the fact that I deal with mainframes with medical data, which means of course the constant changes are slight business rule updates rather than actual technology updates.



  • @blakeyrat said:

    @Jaime said:
    That work OK if you are doing it once. However, if the a daily data feed comes in this format, you've got to parse it in some easily automated way. Excel macros running on somebody's workstation doesn't count as automated, and Office on a server doesn't count as easy.
    While I admit that is true, it still doesn't really address my shock that nobody in the mainframe development community has ever, in 20 years, attempted to build a better tool for this? Ever? It beggars belief-- what the hell are you people doing all day? Especially since it seems like the requirements would be pretty basic.

    IBM generally has their shit together on this.  However, the people that inhabit these machines can't even spell UI.  Anybody who cared about user experience ran screaming from mainframes during the Internet bubble.

    I regularly ask our RPG programmers if they can provide me data in any other format than flat files and by any other mechanism than FTP.  The answer is always "no".  It's not that language or the system aren't capable, it's that the people aren't capable.



  • @blakeyrat said:

    @TheCPUWizard said:

    @Helix said:

    A DEV who is BLIND... sorry since when did anyone employ a developer who cannot read directly his own code.................. who ever suggested employing this guy should be awarded the "This is a stupid suggestion but we may get a 'fair employer' suggestion" award

    He does "read directly his own code", just uses a screen reader (audible into headsets). He is the lead developer for a major (fortune 100 company) and if he ever became available I would not hesitate to hire him [if I could afford him] or give him the best recommendation possible.

    It says it's a troll RIGHT ON THE POST!

    What's wrong with everybody in this thread!? Jesus. You could troll this thread with anything, it's sucker-central.

    If Hitler wrote code, he'd use Consolas 11pt! Blind people are only useful as sausage filling! Programmers are all big fat stinky-heads who smell like butts!

     

     

    <font size="-3">Suckers </font>

     



  • @Helix said:

    <FONT color=#698d73>c:\xkcd\refere~1\hitler\godwin\ref\*.*</FONT>

    I ran this and it formatted my computer.  Thanks a lot.


  • @blakeyrat said:

    While I admit that is true, it still doesn't really address my shock that nobody in the mainframe development community has ever, in 20 years, attempted to build a better tool for this? Ever? It beggars belief-- what the hell are you people doing all day? Especially since it seems like the requirements would be pretty basic.

    Requirement number 1: users need to have terminals that can display real graphics - let's say, minimum 320x200 2 bit CGA graphics.  FAIL.

    At least, for the last mainframe I interacted with, the mainframe administrators had laptops, and used a terminal emulator to connect to the mainframe.  The application owners had laptops or desktops, which used terminal emulators.

    Virtually everyone else who connected to the mainframe did so using antiquated things that we all wish had ceased to exist at least a decade ago.  I'm talking green or amber screen, 80x25 screens.  If you're *lucky*, they have a shift key, and some of them even manage to have some "graphical characters" that one can use to make line boxes that actually connect, rather than faking it with minus signs and pipe symbols.

    Going GUI would require upgrading all of those.  That's not going to happen for some of these companies until they can no longer replace their dead terminals with surplus stockpiles.  From what I've heard, generally speaking, when a company upgrades from those terminals, they upgrade from the mainframe, too - and thus, provide more surplus stockpiles of terminals for the rest of the companies still using mainframes.

    So, graphics for mainframes don't exist because mainframes only still exist for people not willing to pay for graphics - not even the lousy kind available 30 years ago.



  • @tgape said:

    Going GUI would require upgrading all of those.  That's not going to happen for some of these companies until they can no longer replace their dead terminals with surplus stockpiles.  From what I've heard, generally speaking, when a company upgrades from those terminals, they upgrade from the mainframe, too - and thus, provide more surplus stockpiles of terminals for the rest of the companies still using mainframes.

    So, graphics for mainframes don't exist because mainframes only still exist for people not willing to pay for graphics - not even the lousy kind available 30 years ago.

    Going GUI only requires adding a web front end to the application.  It's really easy, but then the trolls that work on them would have to learn HTML and/or a web framework.

    [url]http://www-01.ibm.com/software/awdtools/wdzseries/[/url]



  • @Jaime said:

    Going GUI only requires adding a web front end to the application.  It's really easy, but then the trolls that work on them would have to learn HTML and/or a web framework.

    Wow, you said "GUI" then linked to IBM... as if you honestly believe IBM can create a GUI that doesn't suck ass! You should be in a museum!



  • @blakeyrat said:

    Wow, you said "GUI" then linked to IBM... as if you honestly believe IBM can create a GUI that doesn't suck ass! You should be in a museum!

     OS/2 had a very wll thought out GUI, especially Warp and WarpConnect.


  • ♿ (Parody)

    @blakeyrat said:

    @Jaime said:

    Going GUI only requires adding a web front end to the application.  It's really easy, but then the trolls that work on them would have to learn HTML and/or a web framework.

    Wow, you said "GUI" then linked to IBM... as if you honestly believe IBM can create a GUI that doesn't suck ass! You should be in a museum!

    I think you need to read things more carefully. He was just pointing out that you can fairly easily create a web interface using stuff provided by IBM. Of course, most web interfaces suck ass, but that's no different from any other form of UI, so meh.



  • @belgariontheking said:

    Static variable definition in wrong order.

    Code involved:

    private static HashMap<String, String[ ][ ]> STATE_TABLE;

    Can you figure out what they're complaining about?  I can't. It's only informational level though.

    Don't feel like digging through all three pages to see if anyone else has addressed this yet, but the problem isn't with the contents of the line; rather, the problem is with the position of the line. Similarly to class constructors, CheckStyle feels that private static variables should be declared (IIRC) between public constants and private instance variables.

     



  • @TheCPUWizard said:

    @Helix said:

    A DEV who is BLIND... sorry since when did anyone employ a developer who cannot read directly his own code.................. who ever suggested employing this guy should be awarded the "This is a stupid suggestion but we may get a 'fair employer' suggestion" award

     He does "read directly his own code", just uses a screen reader (audible into headsets).  He is the lead developer for a major (fortune 100 company) and if he ever became available I would not hesitate to hire him [if I could afford him] or give him the best recommendation possible.

    On the topic of screen readers, if anyone is developing an application for distribution [including within a corporate environment] then this should be part of normal testing.  I was contacted by one company last year who was facing bankrupcy becuase their flagship product failed ADA [Americans with Disabilities] testing, and was being forced out of use at thousands of client sites. I looked at "updating" the application, but it was way too far away from what is necessary, so they lost the sales, faced a lawsuit, laid off 80%+ of their staff. They will probably be totall gone within months, and this was a multi- $100M/yr company who simply didnt consider that not all people use displayes, keybords, mice...

    That's weird. Can he use debuggers? I mean, I'm not trying to be an asshole, but there's a lot of information in the call stack, locals, etc. that would be really hard to understand without vision.



  • @Power Troll said:

    That's weird. Can he use debuggers? I mean, I'm not trying to be an asshole, but there's a lot of information in the call stack, locals, etc. that would be really hard to understand without vision.

     I would use "amazing" rather than wierd, but yes, he does use the debugger quite well. The first time I met him (circa 2005) my first thoughts were similar. Then I saw him doing some work, and just stared for a while. A few week later I had the opportunity to work with him, and was completely blown away. Between the use of a specialized braille keyboard [which has functionallity beyond that of a regular keyboard] and the integrated screen reader [a full professional one, not the simple one that ships with windows] he was quite proficient.

     In some ways it is not that different than a blind person who can walk through a large city, and always know where they are simply by keeping (mental) track of how many steps they have taken, how they have turned, what their cane has touched, etc. It is a skill set that very very few sighted people will ever understand fully (I dont) and almost never aquire.



  • @TheCPUWizard said:

    integrated screen reader
    I have to ask: do any of you curse in comments? (or code itself?)

    Oh wait, if he uses earphones then it's not that funny. (not that it would be funny otherwise, of course)



  • @Zecc said:

    Oh wait, if he uses earphones then it's not that funny. (not that it would be funny otherwise, of course)

    Good thing you brought it up then.



  • @blakeyrat said:

    @Zecc said:
    Oh wait, if he uses earphones then it's not that funny. (not that it would be funny otherwise, of course)
    Good thing you brought it up then.
    Bored?



  • @C-Octothorpe said:

    @blakeyrat said:

    @Zecc said:
    Oh wait, if he uses earphones then it's not that funny. (not that it would be funny otherwise, of course)
    Good thing you brought it up then.
    Bored?

    Remember that blakeyrat job is TRWTF



  • @serguey123 said:

    @C-Octothorpe said:

    @blakeyrat said:

    @Zecc said:
    Oh wait, if he uses earphones then it's not that funny. (not that it would be funny otherwise, of course)
    Good thing you brought it up then.
    Bored?

    Remember that blakeyrat job is TRWTF

    Yeah. Plus I worked from home tuesday and wednesday while my boiler was replaced, and I'm super-productive when working from home, so I'm basically done with my week's work right now. Even with yesterday's completely wasted morning.

    This is where a person with talent and ambition would create their own .com and become a millionaire, but... I'm not that person. So I sit around watching nyancat and trolling DailyWTF.



  • @blakeyrat said:

    @serguey123 said:

    @C-Octothorpe said:

    @blakeyrat said:

    @Zecc said:
    Oh wait, if he uses earphones then it's not that funny. (not that it would be funny otherwise, of course)
    Good thing you brought it up then.
    Bored?

    Remember that blakeyrat job is TRWTF

    Yeah. Plus I worked from home tuesday and wednesday while my boiler was replaced, and I'm super-productive when working from home, so I'm basically done with my week's work right now. Even with yesterday's completely wasted morning.

    This is where a person with talent and ambition would create their own .com and become a millionaire, but... I'm not that person. So I sit around watching nyancat and trolling DailyWTF.

    That's so weird...  Where did you get my bio from?



  • Finally got the word back from India on what I have to fix.  Looks like I don't have to clear out all the warnings and informationals.  Just the errors.

    Guys, you still care about the OP right?  

    *cricket*

    Oh dammit.

     



  • @Jaime said:

    @tgape said:

    Going GUI would require upgrading all of those.  That's not going to happen for some of these companies until they can no longer replace their dead terminals with surplus stockpiles.  From what I've heard, generally speaking, when a company upgrades from those terminals, they upgrade from the mainframe, too - and thus, provide more surplus stockpiles of terminals for the rest of the companies still using mainframes.

    So, graphics for mainframes don't exist because mainframes only still exist for people not willing to pay for graphics - not even the lousy kind available 30 years ago.

    Going GUI only requires adding a web front end to the application.

    You need something to display that GUI.  For 95% of the users of the mainframe, they don't have it.  At all.  Not a little, tiny bit.  Unless, of course, you want to consider an EBCDIC art GUI...

    I'll grant you, it'd be easy to code the GUI of which you speak.  I even saw someone do it, back in the late 1990s.  But it was useless, because the users couldn't use it.  Even porting lynx to the mainframe didn't help - aside from the fact of removing the 'G', it wasn't at all acceptable because the interface was totally different.


  • Garbage Person

    @tgape said:

    I'll grant you, it'd be easy to code the GUI of which you speak.  I even saw someone do it, back in the late 1990s.  But it was useless, because the users couldn't use it. 
    And these users should be shot



  • @tgape said:

    You need something to display that GUI.  For 95% of the users of the mainframe, they don't have it.
    Maybe my employer was privileged, but everyone in the building(probably some 800 or so) had a Windows XP machine (it was 2005) and those who needed it used a 3270 emulator to access the mainframe.  

    I see no reason why a webserver running a webapp (or web service) couldn't communicate with the mainframe or become the server in a custom client-server text/code editor.  It seems like it complicates the architecture, but if you think of the mainframe as a database, it's just like a webapp that has its db server on a different box.  Any amount of architectural injustice created by this would still be better than forcing everyone to use a 80x25 window.  

    Yet still, nobody's done it to my knowledge.



  • @Weng said:

    @tgape said:

    I'll grant you, it'd be easy to code the GUI of which you speak.  I even saw someone do it, back in the late 1990s.  But it was useless, because the users couldn't use it. 
    And these users should be shot

     

    You mean the guy who made the UI.

     



  • @belgariontheking said:

    @tgape said:

    You need something to display that GUI.  For 95% of the users of the mainframe, they don't have it.
    Maybe my employer was privileged, but everyone in the building(probably some 800 or so) had a Windows XP machine (it was 2005) and those who needed it used a 3270 emulator to access the mainframe.  

    I see no reason why a webserver running a webapp (or web service) couldn't communicate with the mainframe or become the server in a custom client-server text/code editor.  It seems like it complicates the architecture, but if you think of the mainframe as a database, it's just like a webapp that has its db server on a different box.  Any amount of architectural injustice created by this would still be better than forcing everyone to use a 80x25 window.  

    Yet still, nobody's done it to my knowledge.

    It doesn't even need to be that complicated.  Mainframes and AS/400s come with a web server.  BTW, I too have never seen an IBM environment with physical terminals.  In my experience everybody with terminal access also has a web browser.

    IBM also makes your model trivial.  Whenever one of the dinosaurs make a structured storage file, the operating system automatically exposes the data in the file as if it were a table in a database and allows anyone with the IBM client to query it with ODBC.



  • @belgariontheking said:

    @tgape said:
    You need something to display that GUI.  For 95% of the users of the mainframe, they don't have it.
    Maybe my employer was privileged, but everyone in the building(probably some 800 or so) had a Windows XP machine (it was 2005) and those who needed it used a 3270 emulator to access the mainframe.

    My first guess is that the main people entering data into your employer's mainframe weren't even privileged enough to be in that building (maybe even were in India or something.)

    However, if everyone accessing the mainframe *did* have an XP machine, then, yeah, they should be accessing it through a GUI.  As I said, I saw someone make one back in the late 1990s.  Having been to a few presentations on mainframe terminal architectures, I'd say it would simplify the architecture, rather than complicate it.  Not doing so by 2005 would be quite crazy.


Log in to reply