Youtube controls

boomzilla

@hungrier said in Bug Bites:

@Zecc There's no consistency to it from what I can tell, at least on Chrome-ish browsers. Usually when I see some long video in a thread I'll click the embed to enable the Youtube controls then add to watch later. This morning I tried to do that (it was some security oriented video) and it started playing.

@ben_lubar, I updated the youtube plugin to v0.6.8, with some community suggested fixes for parsing and sanitization that seem to fix the issue of the controls for youtube videos on NodeBB v1.13 but I'm not sure how to update that in our docker image.

Also, BTW, they've released 1.13.2. We're currently on 1.13.1.

ben_lubar

@boomzilla said in Youtube controls:

but I'm not sure how to update that in our docker image

just update the git submodule

(cd into plugins/nodebb-plugin-youtube-embed and git pull)

boomzilla

@ben_lubar said in Youtube controls:

@boomzilla said in Youtube controls:

but I'm not sure how to update that in our docker image

just update the git submodule

(cd into plugins/nodebb-plugin-youtube-embed and git pull)

Ahhh...haven't really worked with those (still pretty much a git n00b). Done:

boomzilla@boomzilla:~/tdwtf/plugins/nodebb-plugin-youtube-embed$ git pull
remote: Enumerating objects: 4, done.
remote: Counting objects: 100% (4/4), done.
remote: Compressing objects: 100% (3/3), done.
remote: Total 4 (delta 1), reused 2 (delta 1), pack-reused 0
Unpacking objects: 100% (4/4), done.
From github.com:boomzillawtf/tdwtf
   04be0e8..07d6a67  master     -> origin/master
Updating 04be0e8..07d6a67
Fast-forward
 Dockerfile                          | 2 +-
 plugins/nodebb-plugin-youtube-embed | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

ben_lubar

@boomzilla hmm, do you not have the submodule initialized? it looks like you pulled the main repo. try git submodule update --init --recursive

boomzilla

@ben_lubar no it was not. Dammit...firing up my vm again...

EDIT: Oh, I see you've already done it.