Bug: entering an unread topic clears (marks read) all upvote notifications for that whole topic
-
This wasn't the case until recently, but now, anytime I enter a topic that has new posts, all of the upvote notifications I had from posts in that topic get marked read. This happens whether I enter the topic normally, or by clicking on one of the notifications, but only if the topic had new posts (i.e., was "unread")... marking the topic "read" automatically clears all notifications for it.
I don't know if this was a deliberate change, but regardless, I hate it. It's bad enough that entering a topic clears all of your mention notifications from that topic. Clicking the notification should mark it, and only it, read. Entering the topic should not, and it should not mark all of the upvote notifications from the topic read just because you marked one of them read.
Please fix it / change it back.
-
If the topic is already read and there are no new posts since last time you were there, the bug can still be reproduced by clicking the " Mark unread" button and then leaving and re-entering the topic, or clicking the permalink on one of the posts to reload the page.
Obviously you have to try it when you have unread upvote notifications from that topic.
-
@anotherusername said in Bug: entering an unread topic clears (marks read) all upvote notifications for that whole topic:
I don't know if this was a deliberate change, but regardless, I hate it.
That was one thing Discourse did. I think I'd rather have upvote notifications marked as read than mention notifications marked read.
-
@boomzilla No, it's not something Discourse does. Discourse tracks unread notifications and like notifications per post. If you view a particular post, both its unread and likes notification clear. If you visit a thread and don't read an unread post, or don't read a liked post, it won't clear.
-
@pie_flavor That's new behavior then because it definitely was what it did whenever you entered a thread.
-
-
@pie_flavor said in Bug: entering an unread topic clears (marks read) all upvote notifications for that whole topic:
The times we live in now have changed.
-
@boomzilla I'm actually pretty sure it did, except 'you view a post' probably meant 'your browser downloaded the not-a-page containing that post' and the pages were rather large.
-
@pleegwat said in Bug: entering an unread topic clears (marks read) all upvote notifications for that whole topic:
@boomzilla I'm actually pretty sure it did, except 'you view a post' probably meant 'your browser downloaded the not-a-page containing that post' and the pages were rather large.
Then they've changed read tracking too because that only kicked in when the post was actually visible.
-
@boomzilla Did it? I may be misremembering stuff we've been off discourse for a while now.
-
@pleegwat Here was the best reference I could find quickly:
Mark Post as Read Lower on Page
This is a modification suggestion for an existing feature, if it’s not categorized correctly, I’d love it if someone can correct it for me. Discourse marks posts as read and updates the “thread position counter” at the bottom of the screen as you scroll down a thread, I like this. It’s cool,...
...My problem is that it doesn’t update the counter and mark posts as read until they’re near the top of the screen...
The “eye line” is about 1/3 the way down the top of the page.
-
@boomzilla said in Bug: entering an unread topic clears (marks read) all upvote notifications for that whole topic:
Then they've changed read tracking too because that only kicked in when the post was actually visible.
The largest table in the database. They might have removed it to optimise something or other perhaps?
-
@pjh I don't think so. In the thread I linked @sam was talking about unread holes in topics. Though maybe they stopped tracking time "spent reading" each post? Not interested enough to go and look at their tables.
-
I don't know if I should be happy or sad that this happens. TBH I like seeing the progression of likes individually...
-
@tsaukpaetra said in Bug: entering an unread topic clears (marks read) all upvote notifications for that whole topic:
TBH I like seeing the progression of likes individually...
Me too, except when they're coming from you
-
@timebandit said in Bug: entering an unread topic clears (marks read) all upvote notifications for that whole topic:
@tsaukpaetra said in Bug: entering an unread topic clears (marks read) all upvote notifications for that whole topic:
TBH I like seeing the progression of likes individually...
Me too, except when they're coming from you
Feature request: Ignoring like notifications from a particular user if they're the first like in the post? ;)
-
@tsaukpaetra Why ever would anyone want that?
-
@boomzilla said in Bug: entering an unread topic clears (marks read) all upvote notifications for that whole topic:
@tsaukpaetra Why ever would anyone want that?
Why would anyone ever want a stable scrolling experience?
-
Can someone please give me an official comment as to
- whether this is a bug?
a. when might it be fixed? It's really annoying. - whether it's by design?
a. why?! Who would ever want their notifications to just disappear all by themselves like that?
b. whether there's a possibility of getting an option to re-enable the old, not-broken way of handling these -- maybe with fine-grained controls so that we could have it automatically clear mention notifications (or not), upvote notifications (or not), ... are there other types of notifications that would be cleared when entering a topic? If there was an option for each kind of notification that would be lovely...
- whether this is a bug?
-
@anotherusername said in Bug: entering an unread topic clears (marks read) all upvote notifications for that whole topic:
Who would ever want their notifications to just disappear all by themselves like that?
I hate to say it, but even
did this better. It's kinda sensible to mark them read when the post appears on your screen. Kinda. Marking them read when you enter the topic is not. Marking them read sometimes, if the topic has unread posts and it's not raining on a Tuesday night during the full moon, is not.
-
@anotherusername It's a bug, although a low priority one, which is why it hasn't been looked at yet.
We currently do not have tools to track whether a post is in view, although this is fairly straightforward.
Best way forward would be to open an issue on our tracker so it can be addressed instead of forgotten over time.
-
@julianlam ok, thanks for the clarification.
Is this a bug that's existed for ages, and we've just finally updated to the version that has it? Or is it truly new? I found
Topics.markTopicNotificationsReadin /src/topics/unread.js, but it doesn't look like anything in that function has been changed for at least a year, so I'm wondering if the bug was introduced someplace else. Or I'm looking in the wrong place.
