Buttons still visible if you can't use them
-
Examples include the upvote and downvote buttons on your own posts, or the Purge button on a deleted post.
-
Nothing wrong with them being visible. Problem is, they should be distinguishly disabled.
-
@Zecc Why should they be visible if you can't use them? What would be the point?
Consider Discourse.
https://i.imgur.com/JpMob2S.png
Expanding the controls:
https://i.imgur.com/plIgluF.png
https://i.imgur.com/ySApHx6.png
There is no reason to show buttons that you cannot access. I cannot like my own post; I cannot edit or delete his posts. So I do not see those buttons.
-
@pie_flavor said in Buttons still visible if you can't use them:
So I do not see those buttons.
This seems to be done correctly for most moderator functions. Apparently not enough care was put into other ones.
Or someone was attempting Feng Shui.
Or something.
Pull requests accepted?
-
@pie_flavor said in Buttons still visible if you can't use them:
Why should they be visible if you can't use them?
Visual consistency, clues that you can normally perform that action.
My preference would be for the up/down votes to always be there but clearly disabled on your own posts, but things in drop downs to be removed when not possible as those are more advanced functions so a more situational display makes sense
-
@pie_flavor said in Buttons still visible if you can't use them:
@Zecc Why should they be visible if you can't use them? What would be the point?
Because things moving around when you're not looking for them to do so is bad UI. Take this classic example from Discourse where things got moved around, causing problems.
And got ignored, incidentally.
@pie_flavor said in Buttons still visible if you can't use them:
Consider Discourse.
I think the example presented above amply demonstrates how it's not any different in this regard..
-
@PJH said in Buttons still visible if you can't use them:
Because things moving around when you're not looking for them to do so is bad UI.
You mean like everything moving around as soon as the window hits 767px?
Seriously, I don't know what would be wrong with the arrow buttons disappearing on your own post, leaving the vote number behind in the same position.
-
@pie_flavor said in Buttons still visible if you can't use them:
Seriously, I don't know what would be wrong with the arrow buttons disappearing on your own post, leaving the vote number behind in the same position.
Here you go then.
[data-uid="141530"] > div.clearfix.post-footer > small > span.votes > a:nth-child(3) > i, [data-uid="141530"] > div.clearfix.post-footer > small > span.votes > a:nth-child(1) > i { display: none; }
-
@PJH said in Buttons still visible if you can't use them:
@pie_flavor said in Buttons still visible if you can't use them:
Seriously, I don't know what would be wrong with the arrow buttons disappearing on your own post, leaving the vote number behind in the same position.
Here you go then.
[data-uid="141530"] > div.clearfix.post-footer > small > span.votes > a:nth-child(3) > i, [data-uid="141530"] > div.clearfix.post-footer > small > span.votes > a:nth-child(1) > i { display: none; }Sure, but replace
a:nth-child(#)witha[component="post/upvote"]anda[component="post/downvote"].
-
Purging deleted posts is not a moderator action. It just happens that we haven't given that privilege to anyone explicitly, so only moderators can do it here.
-
@ben_lubar Sounds like the perfect Christmas gift for @sockpuppet7
-
@ben_lubar So? If you don't have the permission, you shouldn't see the button.
-
FEATURE REQUEST: Upvote/downvote your own posts
-
@loopback0 said in Buttons still visible if you can't use them:
FEATURE REQUEST: Upvote/downvote your own posts
This would be awesome if we still used Discourse where you could upvote/downvote the same post multiple times.
-
@loopback0 said in Buttons still visible if you can't use them:
FEATURE REQUEST: Upvote/downvote your own posts
nothing to see here, move along
-
@ben_lubar said in Buttons still visible if you can't use them:
@loopback0 said in Buttons still visible if you can't use them:
FEATURE REQUEST: Upvote/downvote your own posts
nothing to see here, move along
Stop hacking the database!
-
I'm with a few simple rules and this applies to buttons, menu options, etc.
If you have access the option is visible, no access it is not visible.
If the action is valid in the current context the option is enabled, otherwise it is disabled.This keeps the UI consistent based on context and access with very little surprises and makes for a very simple rules engine when painting the screen.
