I haven't been doing a good job of following my own commit message rules
-
Looking at a commit summary on a pull request for some recent work, I think I may need to take a moment to do a quick check on policy regarding writing useful commit messages. Not all these commits are mine. Generally just the ones that have no useful information. This started as a project I was working on alone, and I may have carried over some of my bad habits now that it's a team effort...
- Nodes no longer create an event. Event will start as NULL. Exporting to JSON will skip any NULL events.
- Merge branch 'master' into develop
- Starting node API redesign
- This turned into a much bigger project.
- Working on API fallout.
- Progress continues. Grown men weep.
- Death awaits he who thought this was a good idea.
- Continuing work on node API redesign...
- Cleaned up some random build warnings with gcc about unused params.
- Added a script for running cppcheck.
- foo
- Created a simple test case for testing the path counting. Changed the counts from signed to unsigned ints.
-
Good men don't need rules. Today is not the day why we found out why we all need so many.
Those aren't terrible comments. On the other hand, from my (private) repo yesterday:
It might even work but right now the brain it no work. This stuff is ridiculously, extremely tediously dull. Dull, dull, desperately dull.
(Yes, I actually checked it in without even checking it would run. It's PHP so compilation isn't a thing but I didn't even run a basic lint check on it.)
-
Good men don't need rules. Today is not the day why we found out why we all need so many.
Did someone just kidnap your best friends' baby?
Should I also mention that the baby, through timey-wimey effects, is your best friends' child hood friend and your future wife?
-
Should I also mention that the baby, through timey-wimey effects, is your best friends' child hood friend and your future wife?
/facepalm.
Aside: Did anyone else see "2dis" as a pun? I retold that joke to several people and nobody else seemed to get it, even the other fan in the office.
-
And that the baby is part Time Lord and regenerates, even to the point of donating regenerations.
Also, it's not a great pun but it is a pun.
-
-
-
More specifically... while in flight.
-
More specifically... while in flight.
This is what happens when you take your friends on a honeymoon trip in a TARDIS.
-
This is what happens when you take your friends on a honeymoon trip in a TARDIS.
Even if their bedroom has a bunk bed in it.
-
-
-
Really. It's not FUBAR, after all.
-
-
@Sutherlands said:
Really?
That was only one comment, he said comments.
Really?
-
@chubertdev - Days Since Last Discourse Bug: 0
-
That was only one comment, he said comments.
This turned into a much bigger project.
Death awaits he who thought this was a good idea.
Progress continues. Grown men weep.
Yeah, those are crappy comments too. They tell nothing of what was done. Might as well say "did stuff."
-
Merge branch 'master' into develop
That's not a terrible comment. There's really not that much informative to say other than that in that case; the interesting ones are upstream on
master
. Going the other way with the equivalent comment would be worse though (assumingmaster
is the principle branch, of course).For the others (except
foo
:) and maybe the weeping one) what's wrong?
-
-
Latest commit message from me:
Adding flowers.
Literally just added a flower box to an SQL script because code review said it needed it.
-
-
Princie pal
-
My latest commit: Forgot to add files
-
Princle pie
-
-
-
Hell damnit!
-