WebEdition PHP CMS

haha_only_serious

I just found this atrocity in the webEdition code (it's a crap PHP CMS http://www.webedition.de/en/):

[img]http://img4.imageshack.us/img4/9329/wearraykeyexistsabomina.png[/img]

btw: this forum sucks, requiring html to create linebreaks? c'mon...

DOA

Sheesh, how retarded do you have to be to write this...

Oh come on... it's not that bad.

Sure, you could use isset(), but at least this is functional, isn't it?

Edit: oh, and array_key_exists().

error

I frequently see a former coworker of mine write: someExpression ? true : false

As well as, someString.ToString() and (LINQ) from x in y select x. He likes the verbose no-ops.

vyznev

Depending on which bastard-offspring-of-C language you're coding in, someExpression ? true : false can be a perfectly reasonable way to cast something into a boolean. (Using it in a strongly typed B&D language like Java would be a WTF, of course.) Sure, you could shorten it to !!someExpression, but honestly, you had to look at that twice to figure out what it did, didn't you? Of course, in most languages the cleanest way to write that would be something like (boolean) someExpression.

PJH

@vyznev said:

Sure, you could shorten it to !!someExpression, but honestly, you had to look at that twice to figure out what it did, didn't you?

Um no - it's an idiom that, while perhaps not common, isn't unknown.

morbiuswilters

@vyznev said:

Depending on which bastard-offspring-of-C language you're coding in, someExpression ? true : false can be a perfectly reasonable way to cast something into a boolean. (Using it in a strongly typed B&D language like Java would be a WTF, of course.) Sure, you could shorten it to !!someExpression, but honestly, you had to look at that twice to figure out what it did, didn't you? Of course, in most languages the cleanest way to write that would be something like (boolean) someExpression.

This is PHP so the ternary is redundant, although I admit I sometimes forget the shortcut of storing the result of the expression in a variable and use the ternary anyway.

JoelKatz1

I can't fully justify this, but one way you can wind up with code like this is if at one time there was code to create a log entry in the 'else'. Once the code was tested, the log entry was removed, but the person removing it didn't want to make any more changes than needed, and it's possible someone might want to put the log entry back.

This is easier to justify if there had been a commented-out logging command there, of course.

@morbiuswilters said:

This is PHP so the ternary is redundant, although I admit I sometimes forget the shortcut of storing the result of the expression in a variable and use the ternary anyway.

I'll never get over the left associativity of PHP's ternary operator.

$how_many = $qty < 2 ? 'too few' : $qty > 2 ? 'too much' : 'just right';

is interpreted as

$how_many = ($qty < 2 ? 'too few' : $qty > 2) ? 'too much' : 'just right';

at and makes $how_many become an unexpected 'too much' when $qty == 1.

morbiuswilters

@Zecc said:

@morbiuswilters said:
This is PHP so the ternary is redundant, although I admit I sometimes forget the shortcut of storing the result of the expression in a variable and use the ternary anyway.
I'll never get over the left associativity of PHP's ternary operator.
$how_many = $qty < 2 ? 'too few' : $qty > 2 ? 'too much' : 'just right';
is interpreted as
$how_many = ($qty < 2 ? 'too few' : $qty > 2) ? 'too much' : 'just right';
at and makes $how_many become an unexpected 'too much' when $qty == 1.

Nested ternaries are always a WTF, IMO.

gherkin

if (boolean) {

return true;

}

else {

return false;

}

... is how I'd code if I were paid by the line.

TwelveBaud1

@gherkin said:

... is how I'd code if I were paid by the line.

Pfft! You and your sticking to K&R.

if 
    (
        boolean
    )
        {
        return
            true;
        }
    else
        {
        return
            false;
        }

digitalcircuit36939

Re: Line breaks

I might be kinda slow to find out the requirement, but thank you for telling me how to do it!