"View Raw" does not allow select-quoting

Lorne Kates

I know this is custom plugins and all that shit, but...

View VIEW RAW

Highlight some text

Click Reply or Quote

Select-to-quote doesn't work

ben_lubar

/cc @anotherusername

anotherusername

@ben_lubar the code that grabs the selection appears to be restricting it to component="post/content" elements.

I wasn't sure if there would be repercussions to having more than one component="post/content" element in a post. As long as there's not some highlander "there can be only one" type of thing going on, that attribute could be set on the .content.raw-content element, and then select to quote seems to work in that.

ben_lubar

@anotherusername could you put the raw inside the component="post/content" area and then hide everything inside and show the raw instead of adding the raw-content outside it?

anotherusername

@ben_lubar I suppose. I don't see why not.

It'd be more work... all the child nodes of the component="post/content" would have to be placed in a new element so that they could be hidden properly...

edit: well, text nodes would, at least... it'd sort of seem half assed to just assume that the post contents are all inside secondary elements so that CSS can target them...

Also, moving an iframe or video node will cause it to reload.

If it's known for sure that all visible children of the component="post/content" will be elements, then the raw could just be inserted as the first child and then CSS could hide siblings when the raw is visible.

ben_lubar

@anotherusername said in "View Raw" does not allow select-quoting:

If it's known for sure that all visible children of the component="post/content" will be elements

Unless something is wrong with one of the post formatting-related plugins, that should always be the case.

remi

Spongebob later...

I just want to mention that, for once, NodeBB search did its job and managed to find this thread before I created a new one to say exactly the same thing

Actually, I just want to mention the bug mentioned in this thread (:xzibit:).

Highlighted text in "view raw" still isn't quoted when clicking "reply."

That's all. Let this bug go back to sleep for the next (checks date) 3 years.

loopback0

@remi

boomzilla

@remi said in "View Raw" does not allow select-quoting:

Highlighted text in "view raw" still isn't quoted when clicking "reply."

That's all. Let this bug go back to sleep for the next (checks date) 3 years.

View raw is one of our customizations (which perhaps helps explain some of the talk up-thread).

remi

@boomzilla Yes, that's what I understood from the discussion. If I understand correctly, @anotherusername suggested some changes to our plugin so that the raw part that we add is marked in a way that the select-to-quote mechanism recognises, but since there are no follow-up posts I assume no one ever tried to implement it?