Onebox preview completely wrong
-
How does this happen?
Not much of a preview. I'm guessing both results do come from dictionary.com at some point (the one in the preview must be filtering for NSFW language?) but I don't know why they differ.
-
@heterodox I think that's a deliberate change to stop the preview DoSing other servers.
-
@raceprouk said in Onebox preview completely wrong:
@heterodox I think that's a deliberate change to stop the preview DoSing other servers.
Oh. So does the onebox never match the end result? I guess I don't use it enough to know that. I figured both were making requests but the first one was different in some way (filtering hypothesis above).
-
@heterodox Honestly? Dunno. I'm just guessing.
-
@raceprouk said in Onebox preview completely wrong:
@heterodox Honestly? Dunno. I'm just guessing.
Testing:
https://twitter.com/devopsreact/status/890257671957299200Yeah, that does the same thing. What's weird is it shows the end result correctly, then once you keep typing it switches to "[Twitter: DevOps reactions on Twitter, click to preview]" at some point.
I'd argue this is incorrect behavior, especially since it does show the correct preview first. Then the preview is not a preview unless you click the link.
-
@heterodox It shows the full preview if NodeBB hasn't seen that link before, and then switches to the [click to preview] thing once it's cached.
-
@ben_lubar said in Onebox preview completely wrong:
@heterodox It shows the full preview if NodeBB hasn't seen that link before, and then switches to the [click to preview] thing once it's cached.
And personally I think this is a good idea.
-
@zecc said in Onebox preview completely wrong:
And personally I think this is a good idea.
Hm. I may very well be the only one who thinks the behavior is unintuitive then. It seems to me though that NodeBB could show "[click to preview]" from the start as it can generate that information immediately then can cache the full preview in the background.
-
@heterodox said in Onebox preview completely wrong:
@zecc said in Onebox preview completely wrong:
And personally I think this is a good idea.
Hm. I may very well be the only one who thinks the behavior is unintuitive then. It seems to me though that NodeBB could show "[click to preview]" from the start as it can generate that information immediately then can cache the full preview in the background.
The problem is that there's no way to tell whether iFramely will handle a given URL or not before you've gone and called it anyways.
I suppose though that instead of immediately showing the result, once iFramely does catch in it should first show the "Hey this is an embed, click to enable preview" and not initially render it...
