Markup errors


  • SockDev

    Put your markdown errors here. yelling at blubar or :doing_it_wrong: is optional but it may make you feel better about the bugs.

    1. Images with a manual class fail unless they are not alone on a line.

    This image has the class "emoji" but it doesn't apply the style


    This image has the class "emoji" and does apply the style


    This image has the class "emoji" and doesn't apply the style because the line above has an html tag



    1. Username "emoji" go bonkers. source
      0_1500638794990_cbe03f5e-40e4-48b2-b01e-5fa6c24aca4f-image.png
      I've tried to reproduce that one, half way through that post the accalia emoji stops working for apparently no reason i can find.


    How many more bugs can you find?




  • @nedfodder That's what I see too.



  • @nedfodder It's hard to judge whether the screenshot is correct or not without knowing what the "emoji" class implies. Is it supposed to resize the image to a square?

    :100:
    :8ball:
    :accept:


  • SockDev

    @blakeyrat said in Markup errors:

    Is it supposed to resize the image to a square?

    To emoji size, yes



  • @raceprouk Well the CSS is demented, but it looks like it gets assigned both .img-responsive and .emoji, and the former overrides the "square-ness" of the latter by setting the width to auto.

    Whether this works as intended, it's hard to say what's even intended here.



  • @raceprouk said in Markup errors:

    @blakeyrat said in Markup errors:

    Is it supposed to resize the image to a square?

    To emoji size, yes

    The non-square emoji are :arrows:



  • Not all of our emojis are square: :arrows: :crazy: and the CSS rule for our custom ones .emoji[data-set-id="tdwtf"] only enforces height. I'd say 20px high and not necessarily square is closer to the desired behaviour. In any case, all the images in the OP have the same classes and all look the same.



  • @blakeyrat said in Markup errors:

    @nedfodder It's hard to judge whether the screenshot is correct or not without knowing what the "emoji" class implies. Is it supposed to resize the image to a square?

    :100:
    :8ball:
    :accept:

    Yes... actually it just forces the height to 20px, but doesn't force it to be square, because some emoji aren't square. It also suppresses the image border.

    Image without emoji class:

    Image with emoji class:

    Apparently there is a bug with the class inside the preview... this style:

    0_1500647003294_0e87cfa5-2f00-4218-8acb-01e152519f4f-image.png

    ...isn't getting applied because, for some reason, the image doesn't have the img-responsive class in some cases:

    0_1500647080692_ae835203-6e5c-4835-bd6a-ef44f1e79312-image.png

    0_1500647107786_130d054c-5758-478d-ac20-c454a77feaf5-image.png



  • @anotherusername E_NO_REPRO Chrome 59.0.3071.115

    0_1500671454694_843c2b3e-db98-4798-8cdd-c1b48a81c970-image.png

    0_1500671652577_76f6276b-71ac-4657-8ef3-421f6e01b6aa-image.png



  • @e4tmyl33t the bug is only in the composer's preview pane. After submitting the post, the emoji class works as expected.

    0_1500672786024_f7ab257c-dd7b-4b0e-b9da-2439e4a381a4-image.png


  • SockDev

    @nedfodder said in Markup errors:

    @accalia :question:

    0_1500639116416_1d45bd52-848b-4736-9c81-228acd7e6c96-image.png

    .... i SWEAR that was broken in the live as well, not just the preview


Log in to reply
 

Looks like your connection to What the Daily WTF? was lost, please wait while we try to reconnect.