Feature request: notifications on edited @mentions
-
@TDWTF-NodeBB-Development
So, not sure if the underpinnings of the post baker & notification systems would even support this, or whether or not there's a social engineering reason why it shouldn't be done, but a minor pain point that comes up fairly frequently in the ImpMisslumarea of the forum is that once a post is submitted, any changes to the @mentions in the post will not send notifications. Meaning you either have to add a second post to @mention someone, or hope they have the thread on watching.My desired feature MVP state:
- adding additional @mentions via an edit of a post will send notifications for those @mentions
- unless the user was already notified for that post due to a watching status (the same as they don't get an @mention notification for a post they get notified about due to watching a thread)
I think removing a notification if it hasn't been read (or maybe just undelivered?) by the target and a @mention gets removed from a post via post deletion or edit would also be useful behavior.
Given that it's a pretty esoteric use case, I figured I'd ask here to see if any of our Node plumbers think it's viable instead of asking upstream. Willing to cross-post there if people think that would be a better idea.
-
@izzion said in Feature request: notifications on edited @mentions:
post baker
There is no pre-baking in NodeBB like there is in discourse.
IIRC, the edit code path doesn't include mentions at all, which is probably a good thing. The suggested system makes sense, but sounds pretty complicated to get right.
-
@boomzilla Does it have the text that changed? Or just the new entire text, and you'd have to diff them?
-
@Yamikuronue I don't think the original text is saved in any way for later processing. Obviously it could be and it would exist in the DB prior to saving. I dunno...it's been a while since I've looked at it.
-
I assume the reason it is done this way is to avoid stealth mentions, e.g, put a mention in, let the alert go out, remove it again. And potentially reinclude it again afterwards to alert spam.
-
I don't think there's protection against stealth mentions. If you got a notification for this post, then I just did a stealth mention.
-
@RaceProUK maybe not but it does stop alert spamming by not doing it on edit. Stealth is harder to fix though... and yes, I got a notification.
-
Does the forum revoke notifications (e.g. if you upvote then un-upvote a post)? If so then it seems the simplest solution (conceptually, maybe not technically) would be to re-generate notifications for each @mention and revoke the ones that are no longer in the post. Also if possible, don't re-generate notifications if they've already been read for that post.
-
@hungrier
If anything, it's the opposite for notifications (as highlighted by the brief life span of the "vote balance" thred), at least for the 1,5,10,25 setting that (@boomzilla? someone here, I'm pretty sure) addedIf you get exactly one upvote, and that upvote gets rescinded and then a later upvote gets applied, you'll get a second notification the next time. Similarly for all of the other thresholds - if you drop back below it, the next time you hit it, you get a new and additional notification.
-
@Yamikuronue said in Feature request: notifications on edited @mentions:
@boomzilla Does it have the text that changed? Or just the new entire text, and you'd have to diff them?
I don't think you'd want to diff the text anyway (Imagine I fix a mention of @yamibot to @yamikuronue). You want to extract the mention sets from both posts and diff that.
-
@boomzilla It shouldn't be impossible to compare the mentions in the pre-edited post and the post-edited post, and send mentions to any that were added to it.
-
@izzion said in Feature request: notifications on edited @mentions:
once a post is submitted, any changes to the @mentions in the post will not send notifications
I'll testTested with @trust_level_3 they always confirm when they get mentions.
-
@wharrgarbl as I'm sure you've figured out by now, nope.
-
what about ghost mentions?
-
@wharrgarbl yes.
