Link text selection broken
-
@Yamikuronue said in Link text selection broken:
since I have no idea what I'm doing
I tried to get it working on my local instance but am definitely Doing It Wrong⢠so it's not
-
@loopback0 Was a stupid syntax error on my part.
Just amending line 13-15 to:topicsContainer.on('selectstart', '[component="topic/select"]', function (ev) { ev.preventDefault(); });
Shift + select works on the "checkbox":
Shift + select works on the text:
Alt + select works on the link:
Based on the comments on Github, that would work with the other themes too.
-
-
Well done team.
-
@loopback0 said in Link text selection broken:
Allow text selection on /unread by loopback0
I'd rather this PR allow text selection on /unread by all users, not just loopback0.
-
@Lorne-Kates said in Link text selection broken:
I'd rather this PR allow text selection on /unread by all users, not just loopback0.
PRs accepted.
-
@loopback0 said in Link text selection broken:
Oh, if you shift-click the avatar it selects a range of topics. What a totally discoverable feature which is totally worth inconsistently breaking the browsers own behaviour for.
Holy crap, no kidding, huh?
FFS at this point might as well have just had real checkboxes apart from the avatars, but what's done is done...
-
@PJH said in Link text selection broken:
Double click a word here and then click a checkbox:
-