"Open links in new tab" settings not respected in chats
-
I have the checkbox set to open all links in a new tab.
I received a chat with a link in it. I left-clicked it.
Expected: Opens in a new tab.
Actual: Opens in the same tab, making me navigate back to nodebb.
-
@Yamikuronue I'm going to wager the reason is "We have different functions that generate HTML links copy and pasted all over the codebase, and the one in Chat module is different..."
-
@Lorne-Kates My money's on "Chats are a plugin, we have nothing to do with it, E_TICKET_CLOSED "
-
@Yamikuronue said in "Open links in new tab" settings not respected in chats:
@Lorne-Kates My money's on "Chats are a plugin, we have nothing to do with it, E_TICKET_CLOSED "
aren't chats one of the plugins that are installed by default? and isn't julian the dev for chats?
-
Do plugins have access to site-wide settings?
-
@Yamikuronue said in "Open links in new tab" settings not respected in chats:
@Lorne-Kates My money's on "Chats are a plugin, we have nothing to do with it, E_TICKET_CLOSED "
[!(http://what.thedailywtf.com/uploads/WHY_NOT_BOTH.jpg upload 101%)]
-
@Yamikuronue said in "Open links in new tab" settings not respected in chats:
@Lorne-Kates My money's on "Chats are a plugin, we have nothing to do with it, E_TICKET_CLOSED "
Nope, chats are core. I can't reproduce it on my test instance.
Possibilities:
- Settings-grabbing code is messed up (I changed the variable directly in JavaScript)
- Link was inside an iframe which we don't control
- ???
-
Hopefully @masonwheeler doesn't object to my sharing (and why does he have three accounts?! @Mason-Wheeler @Mason_Wheeler @masonwheeler )
(It was a link to archive.org's cached version of a website)
-
@Yamikuronue Start a chat with Ben and send him the same link?
Also, noticed he wrote "here" instead of "http://example.com/". Presumably that could mean he put together the link himself, rather than relying on NodeBB to render it.
I wonder if this link that is just an a tag opens in a new for you?
What about this link that is just an a tag with target="_self" this link that has target=self? Does it opens in a new for you?
-
@Lorne-Kates said in "Open links in new tab" settings not respected in chats:
I wonder if this link that is just an a tag opens in a new for you?
Yes
@Lorne-Kates said in "Open links in new tab" settings not respected in chats:
What about this link that is just an a tag with target="_self" this link that has target=self? Does it opens in a new for you?
yes
@Lorne-Kates said in "Open links in new tab" settings not respected in chats:
nstead of "http://example.com/".
That one did too, by the way
-
Also why don't I have moderator edit abilities in chats?
-
Maybe it's archive.org specifically?
ETA: No, that opened in a new tab.
-
@Yamikuronue said in "Open links in new tab" settings not respected in chats:
Maybe it's archive.org specifically?
ETA: No, that opened in a new tab.
Weird, I can't reproduce the bug in windowed or fullscreen chat mode.
-
@ben_lubar I was in windowed. and it's still occurring when I click that one link.
-
I have no idea why I have multiple logins. Because stupidity most likely ???
-
@masonwheeler Last time it happened to me, it was because I clicked the github button.
-
@Yamikuronue
If only we had a moderator with the ability to ban and purge all the incorrect accounts and enforce using One True Account per user.for Mod!
</tongue-in-cheek>
-
@Yamikuronue That's a definite possibility in my case.
@administrators Is it possible to merge duplicate accounts on node ?
-
@masonwheeler I'm going to go with my gut reaction of: No.
-
There is currently no way to associate a logged-in account with an SSO auth at the moment, but also because we have no user merging facilities.
That was 2 years ago.
-
If the accounts don't have any posts, we can delete them and then you can associate the SSO by going to your profile and clicking the buttons there.
-
@ben_lubar said in "Open links in new tab" settings not respected in chats:
If the accounts don't have any posts, we can delete them and then you can associate the SSO by going to your profile and clicking the buttons there.
Pretty sure all three have posts, though one only has like 7 IIRC.
-
@Tsaukpaetra said in "Open links in new tab" settings not respected in chats:
@ben_lubar said in "Open links in new tab" settings not respected in chats:
If the accounts don't have any posts, we can delete them and then you can associate the SSO by going to your profile and clicking the buttons there.
Pretty sure all three have posts, though one only has like 7 IIRC.
If they aren't useful posts, we can live without them.
SOmething something weel they are MasonWeeehler posts so useful no lol something
-
@RaceProUK said in "Open links in new tab" settings not respected in chats:
Do plugins have access to site-wide settings?
Yes.