Cached site images not invalidated when changed
-
@Tsaukpaetra said in The Official Funny Stuff Thread™:
@abarker said in The Official Funny Stuff Thread™:
my browser never refreshes cached images for this site. I
So that's why I never see Avatar changes without a refresh! FFS!
@abarker said in The Official Funny Stuff Thread™:
@Tsaukpaetra At least it's not just me.
^This^, basically.
-
There should be a version on the avatar's URL or something
-
Yeah, that triggered me to refresh the page, which was showing the latest Mafia Avatar for @abarker (Holy crap autocorrect you learned a name!) and now is showing a nice happy face?
-
@Tsaukpaetra Yeah, I just changed it.
-
@abarker said in Cached site images not invalidated when changed:
@Tsaukpaetra Yeah, I just changed it.
Oh. Well then...
-
Between my phone, laptop, and work PC, I see three different avatars each for @accalia and blakey.
-
@NedFodder said in Cached site images not invalidated when changed:
Between my phone, laptop, and work PC, I see three different avatars each for @accalia and blakey.
hmm... that means i'm not changing avatars fast enough.... good to know.
-
-
-
-
@ben_lubar Good luck! People apparently don't want a patch that Just Works, but a fully configurable toggle in the admin panel!
-
I mean, I kind of see the point of not turning that on by default. As a
battle hardenedtime wearied IIS admin, the number of times I've been bitten in the ass by "we'll just rotate log files daily, but never actually clean up old logs" is a bad thing. If I had a GH account, I would definitely argue strongly for either some sort of avatar file garbage collection or being able to disable the feature so I didn't get my server drive eaten by avatar changes.
-
@Tsaukpaetra said in Cached site images not invalidated when changed:
a fully configurable toggle in the admin panel!
Bug 1:
Bug 2:
Bug 3:
Bug 4:
...
Bug 593:
-
@izzion said in Cached site images not invalidated when changed:
my server drive eaten by avatar changes.
...
..
.
...
..
.
....
-
@izzion said in Cached site images not invalidated when changed:
If I had a GH account, I would definitely argue strongly for either some sort of avatar file garbage collection or being able to disable the feature so I didn't get my server drive eaten by avatar changes.
... does it already store arbitrary quantities of upload images? Like full-size up to 4 MB huge images?
What's the difference?
-
@blakeyrat
There's a difference between storing one copy of a 4MB image per user, versus storing unlimited copies of a 4MB image per user. If you're gaining a lot of users, your forum admin should have pretty good visibility into that happening and be able to prepare for the related effects. If your users are rotating avatars such that you're storing 50 new avatar versions a day, then all the sudden you're consuming an additional 6GB of disk space this month, even though volume on your forum hasn't really changed.Not saying it's the end of the world to do it that way, but I've definitely seen multiple servers wind up with critical outages because the lack of a proper tombstoning strategy for old, irrelevant data (log files, in that case, but the same thing applies here to old avatars) led to an out of disk space problem and everything fell over.
Edit: and I guess as far as uploaded pictures in forum posts, yes, that's already happening too. But again, posts are fairly visible to the admins in the front end, whereas avatar changes don't have a metric that says "hey, you're gonna need enough disk space to handle 50 avatar changes a day"
-
@izzion said in Cached site images not invalidated when changed:
There's a difference between storing one copy of a 4MB image per user, versus storing unlimited copies of a 4MB image per user.
Right, but right now NodeBB is the latter, so...
@izzion said in Cached site images not invalidated when changed:
If your users are rotating avatars such that you're storing 50 new avatar versions a day, then all the sudden you're consuming an additional 6GB of disk space this month, even though volume on your forum hasn't really changed.
... well ok? But. Since they can already store unlimited images, what's the diff?
@izzion said in Cached site images not invalidated when changed:
Not saying it's the end of the world to do it that way, but I've definitely seen multiple servers wind up with critical outages because the lack of a proper tombstoning strategy for old, irrelevant data (log files, in that case, but the same thing applies here to old avatars) led to an out of disk space problem and everything fell over.
I really doubt the "old" avatars would even be a drop in the bucket compared to the number of times I've uploaded the "cool story bro" comic panel.