Changing avatar ist borken


  • sockdevs

    0_1461587648969_upload-ab794893-40ea-4938-9f3d-8b9273828621

    That's when uploading a new PNG, btw.

    cc @ben_lubar


  • Winner of the 2016 Presidential Election

    @RaceProUK I really like that ENOENT is exposed to end users.



  • @Arantor I'm just so glad they test all these changes so thoroughly, so we never have to worry about regressions.

    Cue Boomzilla to come in here and tell me I'm insane and illiterate for expecting regression testing in a software product...



  • @Arantor The first ENOENT that the system did say was to certain poor users in fields where they lay.



  • @blakeyrat Nah, I'm not sure what, exactly, @ben_lubar has been up to with the imagemagick plugin.



  • @boomzilla Maybe, and this is just a thought here, maybe before you pick development tools to create your masterpiece forum software in, you should pick one that already supports common image formats so you wouldn't have to call-out to an entirely different (and, being open source, buggy-as-shit) image program/library.



  • @blakeyrat Maybe. There are always tradeoffs to be made.



  • @blakeyrat one of the functions that I have to override gets a target filename that is sometimes null. The other one doesn't get a target filename at all and the location the output goes to isn't documented anywhere apart from the source code.



  • @ben_lubar Quality.



  • @blakeyrat needs more asterisks and extra/missing letters.



  • @ben_lubar Boomzilla thinks I'm insane and illiterate because I think software should be tested. I was just doing him a favor and acting insane and illiterate.



  • @blakeyrat said in Changing avatar ist borken:

    @ben_lubar Boomzilla thinks I'm insane and illiterate because I think software should be tested. I was just doing him a favor and acting insane and illiterate.

    I think you're illiterate because your first and last name start with the same letter and syllable.



  • @blakeyrat said in Changing avatar ist borken:

    Boomzilla thinks I'm insane and illiterate because I think software should be tested

    No, I think you're illiterate because you read my posts and came away with this impression. Of course, I can't rule out insanity as the cause here, either.


  • Discourse touched me in a no-no place

    @Arantor Bah, I like that spock's mom is in the filename.



  • Marginally relevant image based on topic title:



  • So...first there was an issue in the imagemagick plugin's normalise not adding .png to the filename upon conversion. I added that locally, and then:

    4/5 08:08 [16518] - error: TypeError: callback is not a function
        at /home/boomzilla/nodebb/src/user/data.js:17:4
        at /home/boomzilla/nodebb/src/user/data.js:23:4
        at fireFilterHook (/home/boomzilla/nodebb/src/plugins/hooks.js:92:11)
        at Object.Plugins.fireHook (/home/boomzilla/nodebb/src/plugins/hooks.js:76:5)
        at modifyUserData (/home/boomzilla/nodebb/src/user/data.js:131:11)
        at /home/boomzilla/nodebb/src/user/data.js:58:4
        at /home/boomzilla/nodebb/src/database/mongo/hash.js:136:4
        at handleCallback (/home/boomzilla/nodebb/node_modules/mongodb/lib/utils.js:96:12)
        at /home/boomzilla/nodebb/node_modules/mongodb/lib/cursor.js:848:16
        at handleCallback (/home/boomzilla/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/cursor.js:154:5)
        at setCursorDeadAndNotified (/home/boomzilla/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/cursor.js:463:3)
        at nextFunction (/home/boomzilla/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/cursor.js:644:7)
        at Cursor.next [as _next] (/home/boomzilla/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/cursor.js:685:3)
        at fetchDocs (/home/boomzilla/nodebb/node_modules/mongodb/lib/cursor.js:844:10)
        at /home/boomzilla/nodebb/node_modules/mongodb/lib/cursor.js:867:7
        at handleCallback (/home/boomzilla/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/cursor.js:154:5)
        at nextFunction (/home/boomzilla/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/cursor.js:675:5)
        at /home/boomzilla/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/cursor.js:588:7
        at queryCallback (/home/boomzilla/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/cursor.js:232:5)
        at Callbacks.emit (/home/boomzilla/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/topologies/server.js:116:3)
        at null.messageHandler (/home/boomzilla/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/topologies/server.js:282:23)
        at Socket.<anonymous> (/home/boomzilla/nodebb/node_modules/mongodb/node_modules/mongodb-core/lib/connection/connection.js:273:22)
        at emitOne (events.js:77:13)
        at Socket.emit (events.js:169:7)
        at readableAddChunk (_stream_readable.js:153:18)
        at Socket.Readable.push (_stream_readable.js:111:10)
        at TCP.onread (net.js:531:20)
    

    Which causes the restart.



  • @boomzilla I'm glad this feature was so well-tested before release.



  • @blakeyrat I can tell.





  • @ben_lubar But if you'd included some tests with your original commit...


Log in to reply
 

Looks like your connection to What the Daily WTF? was lost, please wait while we try to reconnect.