Emoji and spoiler are not friends
-
Spoilers and emoji do not work correctly together.
Examples:
Input:
[spoiler]:+1:[/spoiler]
Output:
[spoiler][/spoiler]Expected Output:
[spoiler][/spoiler]
Input:
[spoiler]:rofl:[/spoiler]
Output:
[spoiler][/spoiler]Expected Output:
[spoiler][/spoiler]
Input:
[spoiler]prefix text :+1: Suffix text[/spoiler]
Output:
[spoiler]prefix text Suffix text[/spoiler]Expected Output:
[spoiler]prefix text Suffix text[/spoiler]
.... even the manually constructed expected output is bugged!
-
Emoji and spoiler are nto friends
The title is a one liner... I mean, seriously!
Filed Under: Not even gonna fix it!
-
Oh yeah, I found something similar when I was trying to hide emoji:
<:trollybus:>
Didn't that used to work?
-
Not that I recall; I don't think it's valid to start a tag name with
:
anyway
-
It didn't used to hvae to be a valid tag either
<!invalid> works just fine (view raw)
-
<!invalid>
is a valid tag, at least by SGML standards (which HTML is a dialect/implementation of)
-
It's :trolleybus: ...
-
Ok, this is a weird one, but can someone confirm the same breakage in Chrome/other WebKit browser (spoilered?) GIFs tend to cause: namely, the weird flickering stuff?
Got it to happen when full reloading the end of the thread once, but a reliable way to repro seems to be selecting some text so that the
quote reply
thing appears.
-
reported.
-
I'm getting random parts of the page whited-out while scrolling around in this topic in Chrome:
-
you too? i thought it was the flakey Intel HD graphics i'm running my left monitor on....
-
Repro here.
moving the mouse pointer over the white areas fixes it for a while
-
As do I, when I disable my custom styles (I change how spoilers appear).
I remember someone pointing out the same issue before, and here it is:
-
Yes, it looks different for me on chrome between the discodefault style and our local default style.
-
I can go better than that:
Chrome 40-something, Windows 8.whatever, NVIDIA GeForce NumbersLetters
-
Yeah, I don't see the white out effect on Discourse Default. Also, the spoilered GIF on Discourse Default is tiny, so that may help prevent the issue from appearing.
-
This way works
[spoiler]<img src="/images/emoji/emoji_one/+1.png?v=0" title=":+1:" width="20" height="20" class="emoji" alt="+1">[/spoiler]
-
Congrats you copied the raw used to generate the expected case, way to go.
-
yes, but try sticking some text in there as well as the emoji. :-P
-
yes, but try sticking some text in there as well as the emoji.
you mean like @xaade did?
Input:
[spoiler]prefix text :+1: Suffix text[/spoiler]
Output:
[spoiler]prefix text Suffix text[/spoiler]Expected Output:
[spoiler]prefix text Suffix text[/spoiler](quoted, but had to do an adjustment to properly copy from the OP raw before deleting the
[quote]
blocks)
-
it's not just the discodevs that JDGI
-
-
WhyTF not?
dunno, but according to pl3bs they aren't.
my reaction to that was "ok, so that makes that part of this bug report a feature request, but the images and text spoilers thing is absolutely a bug."
-
this is looking to be a retroactive fix, i.e. the bug is in the JS rendering, not the cooking.
what happens is the render goes "are there images in me? okay do image spoiler. otherwise, do text spoielr"
-
-
Don't forget, unless something changed recently (in the last few weeks), spoiler doesn't even handle line breaks...