Likes topic that isn't


  • SockDev



  • Did you try it on Discourse Default?
    Did it fix itself after a reload?

    Sometimes here the CSS does odd things which offend Stylish. Never seen that but I'm still thinking Stylish is involved.



  • uh, repo steps? Even if just from memory, cause I've no idea how you would get that (and have tried a couple guesses).


  • SockDev

    @locallunatic said:

    repo steps

    1. Go to t/1000
    2. Use the bit at the bottom to go to another thread

    @loopback0 said:

    Did you try it on Discourse Default?

    No, but I'm not reporting this as a bug in Dischorse anyway :stuck_out_tongue:
    @loopback0 said:
    Did it fix itself after a reload?

    New tab, but yeah



  • @RaceProUK said:

    [image]

    Ctrl + Shift + B if you want to hide your bookmarks bar for screenshots.

    Looks like Discourse had some issue when switching topics and didn't change the URL that the topic title pointed to.


    @loopback0 said:

    Did you try it on Discourse Default?

    Wouldn't say it's a style issue, the hyperlink for the topic would've been pointing at /t/1000, as that's the only condition for that thing to show (barring any dumb attempt to clone all applied styles and remove the conditions onto a new element). The fact you can see the style would've just been a clear sign that the issue occurred.


  • SockDev

    @ChaosTheEternal said:

    Wouldn't say it's a style issue, the hyperlink for the topic would've been pointing at /t/1000

    No, the URL in that shot is correct; I'd gone from t/1000 to a different topic :stuck_out_tongue:



  • @RaceProUK said:

    Go to t/1000
    Use the bit at the bottom to go to another thread

    Hrrm, when I did a quick test guessing that was it I didn't repro. *shrug* Probably something with the million little moving parts in dischorse getting confused, but good luck finding it.


  • SockDev

    Yeah, I can't repro it any more :cry:



  • @RaceProUK said:

    @ChaosTheEternal said:
    Wouldn't say it's a style issue, the hyperlink for the topic would've been pointing at /t/1000

    No, the URL in that shot is correct; I'd gone from t/1000 to a different topic :stuck_out_tongue:

    Those two things are not the same. The hyperlink I was referring to is the topic title in the blue bar, which likely was still pointing to /t/1000. Since you (I assume) closed the tab, you can't check it.



  • As I said, sometimes Stylish does odd things to CSS that I've never seen on my computer which has it disabled.



  • Of course, I do have to say the process the header bar does looks different now when switching topics. It seems to:

    1. Show the topic and category you are in (then you click to switch topics)
    2. Switch to the full site logo (like you see at the top of Latest) momentarily
    3. Switch to the mini logo and the category you are going to
    4. Load in the topic title in the blue bar with the category underneath or switch to the full site logo (if at the very top of the topic)

    I believe it used to not do step 2 or 3, but instead just showed the mini logo and said "Loading topic..." until it was loaded, then did step 4.



  • I just had it happen to me, and my guess that the hyperlink didn't update was correct:

    I'm hovering over the title in the header bar.

    Nothing in the console log to suggest a JS error making it fail to update, and I didn't have it open before getting that so I can't check the request/response to see if it's a server issue.


  • SockDev

    …so it is a Dischorse bug then…



  • Seems like it.

    Switching topics from that tab did fix it, but switching again had the issue, the link in the header bar is pointing at the old topic (but not one with a custom CSS deal, which makes it harder to notice).

    The JSON response from Discourse doesn't show anything to me that would suggest it's a server issue, but instead some oddball handling on the client side.


  • area_deu

    IOW, someone should try to repro on FF/IE?



  • Or a bug in the custom stuff to put the labels on things. Has anyone gotten it to happen on something without the custom labels (though would be hard to notice on those)?



  • @locallunatic said:

    Has anyone gotten it to happen on something without the custom labels (though would be hard to notice on those)?

    Yes. I did.

    @ChaosTheEternal said:

    switching again had the issue, the link in the header bar is pointing at the old topic (but not one with a custom CSS deal, which makes it harder to notice).



  • You can try. It's a crapshoot to even get the issue to happen in the first place.

    Might be tied to moments of server cooties, I don't know for sure.



  • Sorry I wasn't clear in what I was asking (you may have got it right but having a "words are hard" moment so can't tell), I meant without switching to a topic with custom labels. For example from this topic to another bug category item without hitting a custom label topic.



  • @locallunatic said:

    I meant without switching to a topic with custom labels.

    That is what I did, which is what I'd meant when I said:

    but not one with a custom CSS deal, which makes it harder to notice

    I'd meant I'd switched from one topic without a custom label to another topic without a custom label, and the hyperlink in the header was still pointing to the old topic, not the "current" one. I was just saying that when it does that, it's harder to notice, but it can (and did) happen.

    In retrospect, I should've screenshot it.

    Here you go, screenshot of it (really wish there was an option in Windows to capture the cursor in your screenshot natively):

    Neither of those topics have a custom label like the Likes thread does (also, neither even have a Unicode emoji thing in the title, so that can be discarded as a possibility too).



  • @sam updated 4 hrs ago - it's not impossible that we have some new discobugs to play with...



  • OK, sorry for misunderstanding. Sounds like you or @RaceProUK should be reporting it on meta.d.



  • It'd have to be someone else. I don't have (and won't make) an account over there.


  • mod

    @PJH said:

    @sam updated 4 hrs ago - it's not impossiblevery likely that we have some new discobugs to play with...exterminate …

    FTFY



  • @locallunatic said:

    repo steps

    *twitch*

    Look guys, there's a difference between repository and reproduction. Go on like that and one day you'll end up with your penis in a Git server.


  • Banned

    its totally possible, we spent a few day on post queueing testing, but maybe something slipped through. if you have a repro I will make sure it gets fixed.

    on the upside we did manage to get a few perf fixes in, and I will continue working through the logs till we get back to reasonable performance here.


  • BINNED

    Reliable repro:

    1. Enter any topic with custom label (Likes, Status, FWiP)
    2. Go to another topic using a notification link

    Extra: Entering any topic with a custom label does not show the label in the title if not entered from /latest. Not sure about suggested, no time to test now, need to run.


  • area_deu

    @Onyx said:

    Entering any topic with a custom label does not show the label in the title if not entered from /latest.

    Entering from Notifications doesn't show the label thingies.
    Most other things don't seem to break the labels here.



  • @Onyx said:

    Enter any topic with custom label (Likes, Status, FWiP)

    And the custom labels are simply the following CSS:

    /* Highlight topics that change regularly in topic list
    http://what.thedailywtf.com/t/the-official-coffee-party-topic-bawston-style/1000/32759
    */
    tr[data-topic-id="1000"], /* Likes */
    tr[data-topic-id="1673"], /* Status */
    tr[data-topic-id="6979"], /* Movie topic */
    tr[data-topic-id="4285"] /* First World Problems */
    {
       .main-link > .title:before {
            padding: .2em .2em .2em .4em;
            margin-right: .5em;
            border-radius: 10px;
            font-family: "FontAwesome";
            background-color:#CADCE6 !important;
            font-size: 75%;
        }
    }
    
    tr[data-topic-id="1000"] /* Likes */
    {
       .main-link > .title:before {
            content: "Likes \f074  ";
       }
    
    }
    tr[data-topic-id="1673"], /* Status */
    {
       .main-link > .title:before {
            content: "Status \f074  ";
       }
    }
    tr[data-topic-id="6979"], /* Movie topic */
    {
       .main-link > .title:before {
            content: "Movie \f074  ";
       }
    }
    tr[data-topic-id="4285"] /* First World Problems */
    {
       .main-link > .title:before {
            content: "FWP \f074  ";
       }
    }
    

    ... and looking at them now, I think I can remove 6979...


  • BINNED

    @PJH said:

    And the custom labels are simply the following CSS:

    Yup, I am a aware of how it was done.

    The :wtf:s we should consider:

    1. The custom label shows up in topic title. Ever. Since the class of the title here is topic-link that CSS shouldn't affect it.
      Buttumption: The title is not actually rendered by using the JSON from /t/topic_id</post_id>. It's actually snagged from $('.main-link').html() and dumped into $('.topic-link') as-is.
    2. The custom label is not cleared after using a notification link. This reinforces the previous buttumption: if the template were re-rendered using new data it would remove the :before pseudoelement. Once again, the topic title seems to be injected from somewhere (could be clicked link innerHTML, could be actual JSON, E_NOT_ENOUGH_DATA)
    3. We didn't figure this out until now

    Addendum: I have a possible fix for "no custom labels if clicked on notification". Not sure if it would help with discussed issue, or just make it worse (it's something pretty much on the fringes of my understanding of finer points in CSS). Testing required.



  • @Onyx said:

    Yup, I am a aware of how it was done.

    Just documenting it for the bug. And for people who didn't want to bother digging through /admin for the specific rules.



  • Didn't repro for me. Going into or out from a topic with a label via a notification link had normal results (the header link updated accordingly and the label showed or not based on the topic I was now in).

    When I did get my screenshots of it happening, I was only going through Suggested, but it's not every time.


  • mod

    @Onyx said:

    Reliable repro:

    1. Enter any topic with custom label (Likes, Status, FWiP)
    2. Go to another topic using a notification link

    Further reliable repro (at least it works for me):

    1. Enter a topic.
    2. Navigate to another topic.
    3. Use the back button.


  • @Onyx said:

    Reliable repro:

    1. Enter any topic with custom label (Likes, Status, FWiP)
    2. Go to another topic using a notification link

    No repro.
    @abarker said:

    Further reliable repro (at least it works for me):

    1. Enter a topic.
    2. Navigate to another topic.
    3. Use the back button.

    Repro'd!


  • BINNED

    @ChaosTheEternal said:

    Didn't repro for me.

    @NedFodder said:

    No repro.

    Well then. It's even more broken than I thought.

    I'd say I'm surprised. But I'm not.



  • Just realized a good way to tell the bug happened if you're going through Suggested (or notifications) is if the topic title is still visible while the new topic is loading, then it doesn't change the link.

    I just saw the topic title still visible while a topic was loading and when it finished, the link was wrong.


    I seem to be hitting the bug a lot today so far.


  • kills Dumbledore

    Another bug that seems new:

    • Go to unread with a decent amount of unread topics
    • Scroll to the bottom (multiple times if it's infiniscrolling you past the end of the page)
    • The topic list will look something like this:
    • Enter a topic, stay on the last post long enough for the blue unread indicator to disappear
    • Click the back button in your browser
      You would expect the topic you've just entered to be gone, since you've now read it. It's a long-standing, minor bug that with enough topics it stays there, but with the blue bubble gone since there are no unread posts in it.

    What actually happens is nothing. If you go back, enter a different topic and go back again, the first topic may go grey instead of blue, but this doesn't always seem to happen


  • SockDev

    It's marking you as having entered the topic, but you haven't necessarily given it time to mark the posts read too


  • kills Dumbledore

    Incorrect. Refreshing the unread page correctly removes them. s Edited the report to clarify that the posts should be marked as read

    Also:

    @Jaloopa said:

    If you go back, enter a different topic and go back again, the first topic may go grey instead of blue

    Wouldn't explain this. After entering topic #2 and going back, topic #1 has its bubble made grey, topic #2 is unchanged



  • I don't see the grey in that scenario too often, but the other thing you reported...



  • I think that's the "normal" CSS visited color. I don't see it only because of a bug in Firefox that makes Discourse completely blow out my places.sqlite beyond usefulness.



  • The visited colour was removed from default Discourse - I added it back locally with CSS. My point was those topics have been visited, the posts have been read but the blue bubbles ain't gone.


  • mod

    Yeah, it's been an issue since the last update.


  • :belt_onion:

    I've always had that problem.. just an overzealous cache pull thing.

    Also, you're probably doing it wrong, Jeff likely doesnt think the back button is a valid method of navigation.


  • BINNED

    @darkmatter said:

    Jeff likely doesnt think the back button is a valid method of navigation.

    But... it's just window.onpopstate and plug it into the same routing code that it would run on link click. Fucking hell. This is the basics here.



  • @darkmatter said:

    the back button is a valid method of navigation.

    ERROR: Invalid viewstate. Please close all browser windows and restart from the home page.


  • :belt_onion:

    @Onyx said:

    But... it's just window.onpopstate and plug it into the same routing code that it would run on link click.

    Not if they're using random #s generated at the end of each url to cause the server to send updated results. Because then popping the old url and running it like a link just gets you a 304 Not Modified.



  • I think this may be fixed. I made a change to fix deleting posts. I guess something changed in a recent update and we were adding the custom delete button handler (to warn when deleting in /t/1000) in the wrong place now. I moved it based on @riking's advice and that issue is fixed.

    The CSS seems to be correct now for me when I go into Likes and Status.


  • BINNED

    Still no dice if entering the topic from notifications. Though that might just be a deficiency in our CSS.



  • Eh, yeah, seeing it now, too. Wonder why it worked earlier...


Log in to reply
 

Looks like your connection to What the Daily WTF? was lost, please wait while we try to reconnect.