"Clear bookmark" button won't work correctly for single bookmark



  • Continuing the discussion from :fa_trash_o::

    @tar said:

    So, if you have any bookmarks on a topic, the <kbd> :fa_bookmark: Bookmark</kbd> turns into <kbd> :fa_bookmark: Fuck all of these bookmarks in this topic</kbd>, which doesn't have a Are you sure you want to fuck all of these bookmarks in this topic? dialogue—it just goes right ahead and fucks all of these bookmarks in this topic. That's really clever and useful that, not something that's practically designed to screw you over if you have 100 bookmarks in a 800 post topic..

    (Yeah, I know, Doing it Wrong™—Bookmarks are there to look pretty and make you feel happy, you're not expected to actual try and derive any usefulness out of them...)

    It's my fault for not having kept paying attention to my post on meta. Mea culpa.

    But it sounds1 like the way it was implemented if you have a single bookmark on a topic you will still lose it without confirmation regardless of whether it is the first post in the topic or not.

    @zogstrip, maybe test for firstPost too?

    1if (unbookmarkedPosts.length > 1)



  • I'm not sure I understand the issue here. Why would having a bookmark on the first post/topic be different than having a bookmark on any other post?



  • The point is that if you accidentally hit the "Destroy Bookmarks" button, then you lose all your bookmarks in the topic without any confirmation that that's what you wanted to do. (Why would you even want to do that?)



  • Quite - you can't cancel a post without confirmation but you can delete all bookmarks in a topic without it.



  • @tar said:

    The point is that if you accidentally hit the "Destroy Bookmarks" button, then you lose all your bookmarks in the topic without any confirmation that that's what you wanted to do.

    I totally agree. That's why I made that fix ^^ (ie. to show a confirm dialog when you are deleting more than 1 bookmark).


  • Discourse touched me in a no-no place

    @zogstrip said:

    That's why I made that fix ^^ (ie. to show a confirm dialog when you are deleting more than 1 bookmark).

    Maybe you should just rate limit the deletion of bookmarks?



  • To what end? How would that help more than my fix?


  • sockdevs

    @zogstrip said:

    To what end? How would that help more than my fix?

    I'm 99.999% certain that was a "joke" commenting on the fact that many things that one would not expect to be rate limited are in discourse.

    ;-)


  • area_deu

    Isn't setting bookmarks rate-limited?


  • Winner of the 2016 Presidential Election

    Stop giving them ideas! :P



  • @Onyx said:

    Stop giving them ideas! :P

    Agreed: ideas should be rate-limited ;)


  • sockdevs

    @aliceif said:

    Isn't setting bookmarks rate-limited?

    i don't think so... i know starring topics before they got belgium-ed in their starholes were rate limited.



  • @RaceProUK said:

    Agreed: ideas should be rate-limited ;)

    Jeff's especially.
    To 0.


  • Discourse touched me in a no-no place

    @zogstrip said:

    To what end? How would that help more than my fix?

    Because the creation of bookmarks is rate-limited.


  • sockdevs

    @PJH said:

    the creation of bookmarks is rate-limited.

    :headdesk:

    JDGI



  • @zogstrip said:

    I'm not sure I understand the issue here. Why would having a bookmark on the first post/topic be different than having a bookmark on any other post?
    For one thing you always know where the first post is.

    As for the others... well, that's why you use bookmarks, right?

    Try this: go to an unbookmarked topic with over 50 posts and bookmark a post somewhere in the middle. Then go all the way down and hit "Clear Bookmarks". Then try to find the same post again.



  • So what are you suggesting? Clearing bookmarks should not ask for confirmation when it's on the first post/topic but should ask for a confirmation when it's on any other post?



  • It's not clear to me that anyone has suggested a bookmark on the OP of a topic should behave differently to a bookmark on any other post in the topic.



  • @tar said:

    It's not clear to me that anyone has suggested a bookmark on the OP of a topic should behave differently to a bookmark on any other post in the topic

    That sounds like a useful feature, though. We could call it, like, Starring a topic instead, maybe.

    How long before we get back there?



  • @zogstrip said:

    So what are you suggesting? Clearing bookmarks should not ask for confirmation when it's on the first post/topic but should ask for a confirmation when it's on any other post?
    That would be it, yes.

    @tar said:

    It's not clear to me that anyone has suggested a bookmark on the OP of a topic should behave differently to a bookmark on any other post in the topic.
    I'm suggesting that if clearing the bookmark on the first post does not ask for confirmation, then it should behave differently on all the other posts. (that is, it should ask for confirmation)

    I'm okay with no confirmation on the first post only, since that easily undone.

    Just to be clear: I'd be okay with it asking confirmation for any post including the first. I'm not okay with it not asking confirmation for every other post.



  • I suppose it's ambigous whether you're trying to remove all bookmarks, or just the bookmark from the OP in that situation. I wonder if it might be better if marking topics used a different indicator than marking posts within topics...


  • sockdevs

    @Zecc said:

    I'm not okay with it not asking confirmation for every other post.

    so long as it does confirm if the remove would remove a bookmark that isn't the OP



  • Confirmation before clearing any bookmark IMO.

    Treating the OP (and thus the topic) differently when "bookmarking" is a feature that's been removed already.


  • Impossible Mission Players - A

    @zogstrip In the style of @fbmac ....

    How would I go about mass-un-bookmarking posts?

    You know.... just in case I want to.... Not that I do, mind you!

    But I wonder...

    Also, Hi User # 2! (a.k.a. @zogstrip )



  • @Tsaukpaetra I have no idea what you're talking about


  • Impossible Mission Players - A

    @fbmac said in "Clear bookmark" button won't work correctly for single bookmark:

    I have no idea what you're talking about

    It's OK, you probably deleted that idea from your memory.


Log in to reply
 

Looks like your connection to What the Daily WTF? was lost, please wait while we try to reconnect.