User Card UI over content but invisible
-
Found myself catching up in the Likes thread with a post I couldn't click on the Like button for (or the Raw button either).
Checking in the Chrome Developer Tools and:
I did open a user card before this, though it was at least a dozen threads before. Looks like, by default, the user card sits at the bottom of the page, taking up space but transparent (appears to be the cause of @accalia's bug report) until opened, at which point it moves from the bottom of the page and stays where it was opened, potentially blocking things.
Able to repro:
- Open a topic
- Open the Developer Tools
- In the console:
$("#user-card").css("opacity", 1); - Open a user card
- Switch to a new topic, then scroll up/down and look for a black box (or the background of the user card you opened)
-
I'm seeing this as well. Trying to click on a topic from the New list, half the title wasn't a link, part was directed at a profile page and part went to a badge.
I "solved" it by removing the object from within developer tools. I now have no user cards but since I rarely open them anyway, meh.
TDWTF default, Chrome. Didn't check to see if it happens in Discourse default
-
-
Thanks for reporting that issue. I just pushed a fix
FIX: move the user-card out of the viewport when closed · discourse/discourse@93b43c5
A platform for community discussion. Free, open, simple. - FIX: move the user-card out of the viewport when closed · discourse/discourse@93b43c5
-
Why are you guys making the user-card non-visible and moving it instead of just using the CSS
displayproperty? Or jQuery's.hide()? either one would make the card non-visible and prevent it from capturing clicks in a single step, without the need to move the card out of the viewport.
-
Because you can't animate
display;)
-
But you can animate
.hide().
-
Then animate
opacityor whatever it is you use, and when the animation's over, setdisplay;)Not an edit: Hanzo'd in part
-
Why does it even need to be animated?
-
-
I wanted to post a few suggestions on how to make it all even more shiny. Sarcastically, of course.
Then I started worrying it might give someone additional ideas....
-
-
Shiny?
-
-
So, it looks like we recently (today? I had a full refresh on a navigation earlier) updated to a new beta version.
Looks like the "fix" made does work, moving the user card to -9999px top and left and not, you know, hiding the belgiuming thing but whatever.
-
So, it looks like we recently (today? I had a full refresh on a navigation earlier) updated to a new beta version.
Looks like we did:
Version v1.3.0.beta3 +21 1.3.0.beta3 ☻ You're up to date!I guess someone forgot to update the update topic. This explains a lot.
-
And do the admin logs mark who initiated an update?
I'm pretty sure this was already asked and the answer was "no".
-
And do the admin logs mark who initiated an update?
They're supposed to here:
http://what.thedailywtf.com/t/docker-upgrades/1929?u=boomzilla
Last post in there right now is from 4 days ago by @PJH:
http://what.thedailywtf.com/t/docker-upgrades/1929/139?u=boomzilla
Hmm...but beta3 + 21 is where we are. So I guess we didn't get an update. We just didn't notice stuff until now.
-
Pretty sure it's been fixed for a while now, since that update.
-
I think he was just relaying what the screen said, because that log didn't include an "after" update of that screen like previous updates did.
Only way to be sure, cc @PJH...
They're supposed to here
I meant the system logs, not an admin logging them.
-
Yes. I just noticed some other new stuff elsewhere, and jumped to some conclusions, abetted by the email notification outage earlier today.
-
I meant the system logs, not an admin logging them.
Not anywhere in the admin pages. Possibly someone with shell access could discover something.
-
The site, at the moment is going through... stuff.
I'm not too inclined to keep updating that docker thread until I'm the only one doing updates to distance myself from accusations of breaking stuff by updating the site.
I religiously (I hope) document when I do it in that topic. Sam, also, usually does.
I've noticed evidence of others updating the site, (as a side effect rather than 'deliberately') but suspect this has to do with the import of the old forums.
-
I'm not too inclined to keep updating that docker thread until I'm the only one doing updates to distance myself from accusations of breaking stuff by updating the site.
I don't think anyone should blame you if shit broke after an update. We all know this thing regresses all the time.
Although, I am at fault of accusing your CSS for one bug (I know you fiddled with it and buttumed you fixed it in a different way than you actually did). I checked the CSS today and I was wrong, but forgot to post in the relevant topic
-
I don't think anyone should blame you if shit broke after an update.
We don't. Only a certain group of developers do.
.hide()
