Can't unbookmark a thread
-
Specifically the funny stuff thread.
Bookmarked the thread (at the bottom).
Monitoring turned on.
Bookmarked a post in the thread.
Some time later go to unbookmark the thread (at the bottom).
Icon goes from blue to grey (as expected).
On the Latest tab thread appears when there's a new post (as expected).
Thread appears with the bookmark icon to the left of it (not expected).
Clicking the thread title takes me to the first unread post (as expected).
Clicking the bookmark icon takes me to the bookmarked post.
For both of the 2 steps above the bookmark icon at the bottom of the thread is blue again.
-
They could fix this by separating the concepts of bookmarking a thread and a single post. They could call the new feature a "star" or something
-
-
They could fix this by separating the concepts of bookmarking a thread and a single post. They could call the new feature a "star" or something
+∞
-
They could fix this by separating the concepts of bookmarking a thread and a single post. They could call the new feature a "star" or something
Latest Commit: Fuck bookmarks right up in their bookmarkholes
900 adds, 874 deletes, 21232189678 modified files
-
They could fix this by separating the concepts of bookmarking a thread and a single post. They could call the new feature a "star" or something
+∞∞
-
CC: @CodingHorror, @Sam
-
-
Yeah, I am on this one, the implementation is a bit "odd", its just toggling bookmark on post #1, fixing it up today.
-
-
Yeah, I am on this one, the implementation is a bit "odd", its just toggling bookmark on post #1, fixing it up today.
I think that the concept could really be cleaned up by implementing something akin to the idea mentioned in post #2.
-
<- I've never seen anything that looks LESS like an 8-pointed black star.
-
lol, I guess gmail should do that too :)
-
lol, I guess gmail should do that too
That is an old, tired argument.
I thought you guys were trying to be new and different? Yet it looks like Discourse is just trying to be the GMail of forums. GCourse.
-
Yet it looks like Discourse is just trying to be the GMail of forums. GCourse.
At one point, suddenly realized that Discourse is just a glorified chat room
-
Hmm... you're right. It is like gmail.
If I bookmark two posts in the same thread, I only get one link in my bookmark tab. And it only lets me go to the first bookmark.
-
Key difference:
I can easily see I've got two starred emails in the chain as I scroll down
-
You can see the stars, If you open the chain.
Same here. You can see multiple bookmarks in a thread if you open the thread.Bookmark two posts in the same thread.
Go to the main forum page, click on the bookmark tab.
The thread only shows up once, giving you access to only one of your bookmarks.
Select it and it always picks the first bookmark.
-
yes, but in this case, the second bookmark -- many emails later -- is within a page of the first, because the intervening ones were automatically collapsed. Discourse's lazy-load means that if my second bookmark is several hundred posts later in a long thread, I can't get to it rapidly.
-
Oh, and by the way, GMail does allow you to bookmark a conversation:
I boxed the indicator for your convenience.
-
I just checked in:
FIX: bookmark topic was not working intuitively · discourse/discourse@b041b3f
- explicitly call out "clear bookmarks" - correct keyboard shortcuts - properly remove bookmarks when toggeling
It cleans up the implementation, feel free to try it out on meta and let me know what you think
