[CLOSED FIXCOMMITTED] Closed Poll: Can't close them
-
Can't reproduce over at try.discourse, but..
When this poll is closed, can you vote in it? There's no Close Poll button btw...
- yes
- no
- BUG_NOT_FOUND
-
Did you try some hammer time?
-
-
-
To repeat the previous post...
Confirmed - that is the problem.
-
I'd LOVE to hear the Discoreasoning behind that shit. Do they not have translations for the phrase Close Poll? I got nothin'...
-
I'd LOVE to hear the Discoreasoning behind that shit.
Maybe the reasoning started with “well, let's see what these mushrooms do…”
-
Do they not have translations for the phrase Close Poll?
Yes. They do. Which makes that edit rather suspicious...
-
I'd LOVE to hear the Discoreasoning behind that shit.
I'm guessing it's like those sex dice.
"Hm, what do we screw with today? *rolls a die* 'Close Poll' button, yeah, that's good... And when do we fuck it up? *rolls another die* 'When user locale is enabled'... yep, that works. Off to make a commit."
It seems the end result is usually like this:
[spoiler] [/spoiler]
-
I suppose those features are discompatible because the status of a poll depends on the topic title. If some user closes a poll, it is not necessarily closed for other users because they might use a different locale with different prefixes. I have no idea why they don't store the poll status directly in the DB, though.
-
I suppose those features are discompatible because the status of a poll depends on the topic title. If some user closes a poll, it is not necessarily closed for other users because they might use a different locale with different prefixes.
But, as I pointed out, they do have the prefixes available, and they use the 'open' poll to enable the functionality to begin with...
[pjh@sofa discourse]$ grep closed_prefix . -r -B1 ./plugins/poll/config/locales/server.zh_CN.yml- prefix: "投票" ./plugins/poll/config/locales/server.zh_CN.yml: closed_prefix: "已关闭的投票:" -- ./plugins/poll/config/locales/server.de.yml- prefix: "Umfrage" ./plugins/poll/config/locales/server.de.yml: closed_prefix: "Beendete Umfrage" -- ./plugins/poll/config/locales/server.ru.yml- prefix: "Опрос" ./plugins/poll/config/locales/server.ru.yml: closed_prefix: "Завершившийся опрос" -- ./plugins/poll/config/locales/server.pt.yml- prefix: "Votação" ./plugins/poll/config/locales/server.pt.yml: closed_prefix: "Votação encerrada" -- ./plugins/poll/config/locales/server.ca.yml- prefix: "Enquesta" ./plugins/poll/config/locales/server.ca.yml: closed_prefix: "Enquesta tancada" -- ./plugins/poll/config/locales/server.en.yml- prefix: "Poll" ./plugins/poll/config/locales/server.en.yml: closed_prefix: "Closed Poll" -- ./plugins/poll/config/locales/server.pl_PL.yml- prefix: "Ankieta" ./plugins/poll/config/locales/server.pl_PL.yml: closed_prefix: "Zamknięta ankieta" -- ./plugins/poll/config/locales/server.it.yml- prefix: "Sondaggio" ./plugins/poll/config/locales/server.it.yml: closed_prefix: "Sondaggio Chiuso" -- ./plugins/poll/config/locales/server.he.yml- prefix: "הצבעה" ./plugins/poll/config/locales/server.he.yml: closed_prefix: "הצבעה סגורה" -- ./plugins/poll/config/locales/server.ko.yml- prefix: "투표" ./plugins/poll/config/locales/server.ko.yml: closed_prefix: "투표 닫기" -- ./plugins/poll/config/locales/server.ar.yml- prefix: "تصويت" ./plugins/poll/config/locales/server.ar.yml: closed_prefix: "هذا التصويت مغلق" -- ./plugins/poll/config/locales/server.es.yml- prefix: "Encuesta" ./plugins/poll/config/locales/server.es.yml: closed_prefix: "Encuesta cerrada" -- ./plugins/poll/config/locales/server.tr_TR.yml- prefix: "Anket" ./plugins/poll/config/locales/server.tr_TR.yml: closed_prefix: "Bitmiş Anket" -- ./plugins/poll/config/locales/server.fr.yml- prefix: "Sondage " ./plugins/poll/config/locales/server.fr.yml: closed_prefix: "Sondage fermé " -- ./plugins/poll/config/locales/server.fi.yml- prefix: "Kysely" ./plugins/poll/config/locales/server.fi.yml: closed_prefix: "Suljettu kysely" -- ./plugins/poll/config/locales/server.pt_BR.yml- prefix: "Votação" ./plugins/poll/config/locales/server.pt_BR.yml: closed_prefix: "Votação encerrada"
-
Because adding metadata to a topic is Doing It Wrong, obvs.
-
Status: FixedInPR