Sexy Schmoozability



  • Go to a topic. Hit Reply on someone's comment. Click something else. Hit Reply again.

    Notice that the focus doesn't change.

    I pray that we can fund the technology to set focus to a textarea possible.


  • Discourse touched me in a no-no place

    Extensive testing has shown forum users don't want that.





  • Look, Discourse has a lot of valid bugs and problems. This doesn't mean that you need to make a mountain out of every tiny thing. It doesn't set the focus when you click reply the second time? Come on.


  • sockdevs

    Considering that it's something Jeff has explicitly complained about, that it falls foul of all good practice - and it is a behaviour they had to specifically implement since clicking on the reply button the first time sets focus - why would it not do it the second time?

    The whole point of computing is that it is repeatable. What goes in comes out again.

    Most of the reason we make a mountain out of it is because literally nothing less actually makes a difference any more.



  • @Arantor said:

    and it is a behaviour they had to specifically implement since clicking on the reply button the first time sets focus - why would it not do it the second time?

    That's the daftest thing with bugs like this - making the same action behave differently twice in a row is something you'd have to specifically do. Someone's put effort into that, presumably effort diverted away from doing something useful.


  • sockdevs

    Exactly. And that's why it deserves a special level of acid tongue lashing.



  • @loopback0 said:

    That's the daftest thing with bugs like this - making the same action behave differently twice in a row is something you'd have to specifically do. Someone's put effort into that, presumably effort diverted away from doing something useful.

    Exactly this.



  • I doubt it's specifically doing that, it's more "slack coding". My guess would be the focus setting code is part of the panel opening code, and as that's not being called if the panel is already open...

    That said, fixing something like this is certainly more important than, for example, solving some of the race conditions they have, and probably only slightly less important than changing trust level names.

    The only thing stopping it getting fixed now is that, now Jeff's been explicitly called on it, he'll have to desperately try and justify it as as-designed behaviour.



  • But that's not true at all. When you click reply for the first time it needs to show the reply pane, set it to reply to the corresponding post and give it focus. When you click reply for a second time, it only needs to change the reply "destination".
    There's a common part of the code and a separate one, and yes, giving focus to the text area should be in the common one, but it's not a mistake you have to intentionally make.



  • It's less obvious than he originally implied, but it's still intentional.


  • :belt_onion:

    @chubertdev said:

    but it's still intentional.

    i doubt it. it's just poor event planning.

    i'm with tufty on the focusing part being in the popup portion of the code. since it's already popped up, when you click a different reply button (which causes focus to go to the button) it just doesn't re-focus afterwards because all it does is change the "reply to" text & id.

    Just laziness and/or poor planning. Although, we're lucky that clicking reply again even manages to do the first part of what is expected.



  • Well yeah, the focus code was intentionally put in the open dialog event, not the click Reply event, which is where it should be. Improper encapsulation.


  • :belt_onion:

    @chubertdev said:

    intentionally put in the open dialog event
    yes they intentionally put it wherever it ended up being put, but i seriously doubt they did it to intentionally make the reply box not re-focus. That would be beyond even dicsourse-level stupid.



  • I dunno, based on a lot of their decisions, I'd disagree with the last part.


Log in to reply
 

Looks like your connection to What the Daily WTF? was lost, please wait while we try to reconnect.