Well, that went well...
-
There are three doors. Behind one is herpes, behind another is an anal probe, and behind the last is Discourse...
Yeah, but which one of them does Monty open? This might be the first time you actually go for that one, depending on what it is and your preferences.
Filed under: if you get Discourse, do you even mind being anal probed and getting herpes afterwards?
-
That's weird; I see loads of people using Google+
It must be a function of which communities you belong to. If you don't join up (and don't listen to “What's Hot”), you see very little. (G+ has the big advantage that you don't have to share everything with everyone. Just the creeps from Menlo Park and Fort Meade.)
-
Shit, there's a dilemna; Discourse or Google+.
That's like picking between herpes and anal probing...
Then what's phpBB and Community Server v2007?
-
Then what's phpBB and Community Server v2007?
Missionary position (boring but reliable and proven), and the sure-fire bottom of the black book (weird, might bite you, but is familiar, and has track record of just getting the job done)
Disqus, as mentioned several times before, you do not have sex with. You fuck it with a leaky car battery. http://sevenseventeen.ca/disqus.html
-
At a previous job in a previous lifetime I promised some customers that "service pack 3" will fix everything. Did not bode well for me.
All I can say is that rendering speed is likely to be improved with this new version of ember.
That said, I turned off cloaking here (left it on, on touch and mobile), scroll up and down, notice how there is not "rerendering" going on anymore.
-
Well, I just switched back over here from another site and my first (frist?) impression, before reading Sam's post was "wooooaaaahhhh.... this is really slow". And it is.
I wonder whether the TDWTF post profile is different to other Discourse sites? I click on links and there is a 2-3 second delay before any kind of feedback,.I look forward (no, that's not true*) to Service Pack 3.
* Nah - I still hate it. Faster shit is still shit. Sorry, Sam.
-
TDWTF post profile is different to other Discourse sites?
main thing was posts per page being 40 vs 20 on a vanilla install, I switched it back down to 20 which makes it render twice as fast. We can up the number later after the fabled ember update.
-
That said, I turned off cloaking here (left it on, on touch and mobile), scroll up and down, notice how there is not "rerendering" going on anymore.
The perceived speed seems to have improved, at least in the threads that I've looked at in the past hour. Much kudos!
-
The perceived speed seems to have improved, at least in the threads that I've looked at in the past hour. Much kudos!
Hold tight on this, I have been turning stuff off and on all weekend trying to find the right balance for here, uncovered a few issues with post cloaking I want fixed. At the moment I wound stuff back to default while I sort out some internal bugs.
-
Hold tight on this, I have been turning stuff off and on all weekend trying to find the right balance for here, uncovered a few issues with post cloaking I want fixed. At the moment I wound stuff back to default while I sort out some internal bugs.
Getting good performance monitoring is critical, and sometimes it can take a lot of work to identify what the problem really is. Especially when you've got several different clients and a server all working together.
I remember dealing with a nasty performance problem in my code earlier this year which turned a 10 second composite operation into one that too about 2 minutes. I went through a lot of my code (with a performance monitoring Aspect) and did some quite elaborate cache management to try to deal with the problem, but nothing seemed to work. (Just attaching a debugger/perf-tool was hard because the code was running as multiple different users across several machines.) It turned out in the end to be something “trivial”: a minor update to a security library had switched it from using salted MD5 hashes to bcrypt for password storage, but the “10 second composite operation” involved a few hundred messages and each needed to be reauthenticated (due to long-standing requirements to support clients without requiring cookie management) and bcrypt is not fast at all.
Once found, a fix was trivial. As things are so often in this business. My point? The hard part is truly understanding what the problem is.
-
The hard part is truly understanding what the problem is.
You can say that again, uncovered a pile of bugs while working on this.
I bumped up slack ratio here to try it out. It should give low end browsers a better experience when scrolling.
The history of fixes are kind of interesting:
- We were leaving stray elements in our Ember hierarchy https://github.com/discourse/discourse/commit/13f4afe00f8ecae1adf107335f3f48d6b6b55bc3 (this mucks with read tracking and kills perf)
- We had a bunch of code that caused reflows, that are horribly expensive (later revised) https://github.com/discourse/discourse/commit/68600f1dce2d9d16121d6303dd08665f1ac15416
- We had a bunch of minor perf papercuts
Now that this is applied, upping slack ratio has very little bad side effects. I still tried to set it to something sane, if you load more that 50 screens it will start peeling stuff off, but in general use, you can now grab the scroll bar and shake it up and down without seeing random loading indicators.
-
...and you're capturing CTRL-F which, at first glance, seems to work pretty well.
It certainly seems faster once the DOM is loaded - still an uncomfortable pause while using the scrollwheel but generally a lot better than it was.
-
I want to be clear that while "rearchitect your entire approach" is not on the table "fix the shitty bugs in Discourse and make it better and faster" is ALWAYS on the table.
-
I was about to say that it had improved a lot, but then I checked in my JS console and saw that I was still using the old value of
2. Placebo effect, ahoy!I guess it was the other fixes that made it look good when swinging my scrollbar.
Edit: I'm still not seeing any whitespace / "Loading" even after bringing it down with
Discourse.SiteSettings.desktop_post_slack_ratio = 0. Or is it cached on page load?
-
I was about to say that it had improved a lot, but then I checked in my JS console and saw that I was still using the old value of
2. Placebo effect, ahoy!I guess it was the other fixes that made it look good when swinging my scrollbar.
I think some of those bug fixes must've really helped quite a bit. (I'm sticking with whatever defaults are nominated by @sam since I've got too much on my plate with other projects already to be hacking on another one…)
-
...and you're capturing CTRL-F which, at first glance, seems to work pretty well.
Which many users specifically told them fucking NOT to do, because it fucks up the browsers even more.
-
@Lorne_Kates said:
Which many users specifically told them fucking NOT to do, because it fucks up the browsers even more.
Not in this case, because getting browser default search was broken on the site.
Interestingly, if the reply box has focus, you get the browsers find box. It might not be so bad now that the load / unload has been rejiggered a little bit. Searching up and down this thread worked reasonably well, though there are only 65 posts here.
-
Interestingly, if the reply box has focus, you get the browsers find box.
You can also get it by pressing Ctrl+F from the hijacked search box. Although now that I've mentioned it, the next "fix" will probably have it recursively bring up more copies of itself in some not-at-all-broken Ajaxy way.
-
Not in this case, because getting browser default search was broken on the site.
Not an excuse to break it further. If your site doesn't work with a browser, you fucking fix your software, not the browser.
I suppose next we'll hijack CTRL-T, CTRL-N and all combinations with TAB to keep the users from leaving the forum, because experiencing working discussion software breaks Disocurse and we can't have that.
-
Also, continued lols:
-
I spent a bunch of time today fixing mess in this area today:
BUGFIX: progress was 0 of 100 while a post is in transit · discourse/discourse@fb3e06b
BUGFIX: highest_post_number could be incorrect BUGFIX: incorrect rendering of in-situ post (when its a reply)
and (this arguably awesome feature was removed)
BUGFIX: flashing incorrect avatar while posting · discourse/discourse@7653262
BUGFIX: incorrect trophy for admins while posting
I was wondering
- What browser were you using?
- Are you able to reproduce this consistently?
I dislike these progress bar bugs.
-
@Lorne_Kates said:
Not an excuse to break it further. If your site doesn't work with a browser, you fucking fix your software, not the browser.
I think there are probably improvements that need to be made for the site search (and devs have agreed). What I'd like is to be able to hop up and down the topic when searching in a topic, like the browser's normal search does. Since the entire topic isn't necessarily loaded, the browser cannot possibly do this correctly, so a proper implementation of search would be better. I guess I should start a bug thread or something.
And this would be better than having pagination, since you could search through the entire thread.
-
I guess I should start a bug thread or something.
http://what.thedailywtf.com/t/search-widget-does-not-prioritize-current-topic/572
-
...and you're capturing CTRL-F which, at first glance, seems to work pretty well.
...for the values of pretty well that mean: doesn't highlight all matches in the page, doesn't search while I'm typing, disappears when I hit Enter instead of moving to the next match...
-
Yep - I did say "first glance" and "pretty well", both of which are marked improvements on "doesn't work worth a flying fuck", which is what it was before.
I am being pessimistic and assuming that TDWTF is staying on Discourse so am trying to give faint praise where it's due.
And yes, I'd prefer we went to paged pages and then could turn off the CTRL-F embellishment, but... this is where we are right now...
-
[...] doesn't highlight all matches in the page [...]
Doesn't highlight any matches (at least for me).
[...] disappears when I hit Enter instead of moving to the next match...
Yeah, is there any way to move to a different (next/previous) match with the keyboard only? Can't find anything in the secret ?-popup.
-
Or "FRITS".
That popup almost made me rethink posting, so it's almost doing its job, I guess.
-
Wait till you see the necroing warning.
-
How'd you manage to get a 3588 day old topic in Discourse?
-
How'd you manage to get a 3588 day old topic in Discourse?
I'm sure there are at least one of those at least twice as long in CS....
-
Imported blog comments.
In the beginning, there was Movable Type
I’m all about Movable Type. We pretty much use it as the de-facto standard when clients ask for a Blogging tool. Looks good on this end.
-
Wait till you see the necroing warning.
That definitely needs a finely crafted necromancer imager or something.
-
How'd you manage to get a 3588 day old topic in Discourse?
Actually the current limit here is set to the default of 180 days.
-
Actually the current limit here is set to the default of 180 days.
And now the truth is out! The move to Discourse has been in the planning for six months - no wonder it went so smoothly!
-
which popup?
-
This one:
"
Welcome to What the Daily WTF? — thanks for contributing!Does your reply improve the conversation in some way?Be kind to your fellow community members.Constructive criticism is welcome, but criticize ideas, not people.
For more guidance, see our FAQ. This panel will only appear for your first 2 posts.
"
-
Constructive criticism is welcome, but criticize ideas, not people.
We gotta replace this thing fast.
-
-
This panel will only appear for your first 2 posts.
Oh, damn. I'm too focused on replying to topics instead of making new "posts", that's why it didn't appear to me when i tried to get it (that's what my two-word question above was... thought you might have seen some kind of "post is too short, please reconsider if it really improves the conversation" :))
