Uploading an image that's too big generates 17 error messages
-
Steps to repro:
- Copy a large image (this will do the trick)
- Paste it in a message
- Hit "OK" on the error dialog 17 times
-
Never mind, hard refreshing seems to put it back to normal. Maybe having had multiple Discourse tabs open in the past has something to do with it.
-
CNR. 1 error message.
-
Looks like it is tabs. I just tried opening a new tab (no composer window in that one, just the topic list) and it gave me 3 error dialogs.
-
Let me guess: you had 17 Discourse tabs open?
-
It's odd. The amount of times you see the error increases each time.
-
Looks like it is tabs
It'll be likely related to this issue then:
http://what.thedailywtf.com/t/pasting-an-image-in-one-tabs-composer-pastes-it-in-all-open-composers/48992?u=raceprouk
-
Open composer - paste large image - 1 error.
Cancel composer.
Open composer - paste large image - 2 errors.
Cancel composer.
Open composer - paste large image - 3 errors.Open a composer on another Discourse tab, and it increases by 2 errors.
-
I'd probably had a bunch of tabs opened and subsequently closed since the last hard-refresh, but at the time it happened it was only one.
Since my previous post (two tabs total, but only one composer), I closed the other tab and it went up to 4, and stayed that way for a couple tries, but now it's at 5 for
-
TO META!
Multiple error messages for over-sized images
Repro steps (confirmed on here): Copy large image (eg this) - copy the image itself, not a link. Paste into message Get error about size (or 2 errors sometimes) Cancel composer window Reopen it again Paste large image Get 1 more error than last time This carries on increasing if you do...
-
Fixed pending our next Discoupdate (presumably).
Multiple error messages for over-sized images
Someone had a pretty bad typo there https://github.com/discourse/discourse/commit/77c7bad61f54e8be199a3e2af5e6a7a9c0455c1d
-
@sam said:
FIX: not unbinding uploadTarget correctly
http://what.thedailywtf.com/t/sleep-considered-bad-practice-for-reaching-51k/1000/46249?u=onyx
Ha! I was right! Close enough, anyway.
