Reply notifications automatically marked as read
-
I'm not sure if this is a bug, so lemme know if y'all have this issue as well
- Enable pagination (not sure if this is required, but why not) and upvote notifications
- Create posts in a thread on page n.
- Read until the end of the thread
- Have someone upvote the posts and reply to a post of yours on page m > n
- Click on the upvote notification for the post on page n
Expected: only the notification for that specific post is marked as read
Actual: the upvoted post's notification is marked as read, AND the reply notification is marked as read, even though it's on a different page that I haven't read
-
@bb36e said in Reply notifications automatically marked as read:
I'm not sure if this is a bug, so lemme know if y'all have this issue as well
- Enable pagination (not sure if this is required, but why not) and upvote notifications
- Create posts in a thread on page n.
- Read until the end of the thread
- Have someone upvote the posts and reply to a post of yours on page m > n
- Click on the upvote notification for the post on page n
Expected: only the notification for that specific post is marked as read
Actual: the upvoted post's notification is marked as read, AND the reply notification is marked as read, even though it's on a different page that I haven't read
repro, happens with infiniscroll too. from what i can tell entering the topic clears all reply notifications for the topic, regardless of whether the post is on screen or not.
Discourse at least waited to clear the notification until after the post was actually on screen.
-
I'd noticed this, but figured it was a touch issue.
I also think it's a fairly recent (last month?) regression
-
@Weng as far as I can remember it's always been like this.
-
@accalia said in Reply notifications automatically marked as read:
Discourse at least waited to clear the notification until after the post was actually on screen.
For varying discodefinitions of "on."
-
@HardwareGeek said in Reply notifications automatically marked as read:
@accalia said in Reply notifications automatically marked as read:
Discourse at least waited to clear the notification until after the post was actually on screen.
For varying discodefinitions of "on."
well, yeah. it was a bit od when the thread was just barely on the page, even a single pixel was enough.... and with jelly potato....
-
@accalia said in Reply notifications automatically marked as read:
Discourse at least waited to clear the notification until after the post was actually on screen.
Discourse also tracked if you've seen an individual post, which probably made this easier.
-
@Tsaukpaetra NodeBB tracks the last post you've seen in every thread, which should make it almost just as easy.
-
@Tsaukpaetra said in Reply notifications automatically marked as read:
Discourse also tracked if you've seen an individual post, which probably made this easier.
And also made the server shit itself on a regular basis, but then again, Node isn't that much better.
-
@Tsaukpaetra said in Reply notifications automatically marked as read:
@accalia said in Reply notifications automatically marked as read:
Discourse at least waited to clear the notification until after the post was actually on screen.
Discourse also tracked if you've seen an individual post, which probably made this easier.
not noticably. just make the client fire off the "i see this post" every time the post scrolls into view and then it knows when to clear the notification.
don't need to store every post a user has looked at, just tell the server what ones the user sees right now
-
@Maciejasjmj said in Reply notifications automatically marked as read:
@Tsaukpaetra said in Reply notifications automatically marked as read:
Discourse also tracked if you've seen an individual post, which probably made this easier.
And also made the server shit itself on a regular basis, but then again, Node isn't that much better.
true, but at least now that there's the watchdog nodebb comes back faster than discourse. now you just get a spike that might last thirty seconds or so.... with discourse it could take hours if it decided to......
it's not much consolation, but at least it's slightly less sucktastic?
-
@accalia said in Reply notifications automatically marked as read:
it's not much consolation, but at least it's slightly less sucktastic?
Well the lack of suckage has made me more technically productive in recent times...
dammit Engine...
-
@accalia said in Reply notifications automatically marked as read:
now that there's the watchdog
That's not a very nice way to call @ben_lubar.
-
@accalia ehhh... more like have the client tell the server when that post comes into view. It doesn't need to be telling the server about every post you're reading; it already has a list of the pending notifications, and which posts they are.
-
@Maciejasjmj said in Reply notifications automatically marked as read:
@accalia said in Reply notifications automatically marked as read:
now that there's the watchdog
That's not a very nice way to call @ben_lubar.
You're right. Watchlion. Better?
-
@Maciejasjmj said in Reply notifications automatically marked as read:
And also made the server shit itself on a regular basis, but then again, Node isn't that much better.
That's because it sent 200MB of data for every post you read.
Rather than.
$.ajax("/readpost", data{'post_id', TheIDOfTheOnePostYouJustRead});
-
@Tsaukpaetra said in Reply notifications automatically marked as read:
You're right. Watchlion. Better?
WatchCupcakeCatThingQRCode
-
@Tsaukpaetra said in Reply notifications automatically marked as read:
lack of suckage
For a second I thought you missed Würst
-
@Luhmann said in Reply notifications automatically marked as read:
@Tsaukpaetra said in Reply notifications automatically marked as read:
lack of suckage
For a second I thought you missed Würst
No, but I do miss @mikeTheLiar.
-
@Maciejasjmj said in Reply notifications automatically marked as read:
@accalia said in Reply notifications automatically marked as read:
now that there's the watchdog
That's not a very nice way to call @ben_lubar.
fine, fine...
now that there's the watchcupcake
... is that better?
-
@accalia said in Reply notifications automatically marked as read:
@Maciejasjmj said in Reply notifications automatically marked as read:
@accalia said in Reply notifications automatically marked as read:
now that there's the watchdog
That's not a very nice way to call @ben_lubar.
fine, fine...
now that there's the watchcupcake
... is that better?
YOU STOLE MY JOKE I'LL DESTROY YOU!!!!!
-
@Lorne-Kates that's intellectual dmca copy infringement!!
-
@Lorne-Kates said in Reply notifications automatically marked as read:
@accalia said in Reply notifications automatically marked as read:
@Maciejasjmj said in Reply notifications automatically marked as read:
@accalia said in Reply notifications automatically marked as read:
now that there's the watchdog
That's not a very nice way to call @ben_lubar.
fine, fine...
now that there's the watchcupcake
... is that better?
YOU STOLE MY JOKE I'LL DESTROY YOU!!!!!
odd... i don't seem to be able to find a trademark registration for that joke, and it's far too short to be covered by copyright....
-
@accalia said in Reply notifications automatically marked as read:
i don't seem to be able to find a trademark registration
did you check http://www.ic.gc.ca/app/opic-cipo/trdmrks/srch/tmSrch.do?lang=eng?
-
@accalia said in Reply notifications automatically marked as read:
odd... i don't seem to be able to find a trademark registration for that joke, and it's far too short to be covered by copyright....
You must have missed the memo about copyright enforcement in this day and age. I don't need to prove I own the copyright. Hell, I don't even NEED to own the copyright. I can just claim anything anyways and steal your money.
-
@Lorne-Kates said in Reply notifications automatically marked as read:
@accalia said in Reply notifications automatically marked as read:
odd... i don't seem to be able to find a trademark registration for that joke, and it's far too short to be covered by copyright....
You must have missed the memo about copyright enforcement in this day and age. I don't need to prove I own the copyright. Hell, I don't even NEED to own the copyright. I can just claim anything anyways and steal your money.
Bite my lawyer's shiny ass.
-
@Maciejasjmj said in Reply notifications automatically marked as read:
@accalia said in Reply notifications automatically marked as read:
"now that there's the watchdogdwarf"That's not a very nice way to call @ben_lubar.
Better?
-
@Lorne-Kates said in Reply notifications automatically marked as read:
@accalia said in Reply notifications automatically marked as read:
odd... i don't seem to be able to find a trademark registration for that joke, and it's far too short to be covered by copyright....
You must have missed the memo about copyright enforcement in this day and age. I don't need to prove I own the copyright. Hell, I don't even NEED to own the copyright. I can just claim anything anyways and steal your money.
Yeah. At one point I was half-tempted to set up an email bot that spat out random ISP addresses to their abuse mailbox with copywrong claims. After all, if someone can silently suspend my service without warning this way, why not show them how wrong that hole is?
-
@Maciejasjmj
That's even worse
-
@Luhmann said in Reply notifications automatically marked as read:
@Maciejasjmj
That's even worseBut would you say it's the worst?
-
@Maciejasjm
No, claiming that would make me a liar
-
@Luhmann said in Reply notifications automatically marked as read:
@Maciejasjmj
No, claiming that would make me a liarM'aiq would never tell untruths.
-
@Maciejasjmj said in Reply notifications automatically marked as read:
@Luhmann said in Reply notifications automatically marked as read:
@Tsaukpaetra said in Reply notifications automatically marked as read:
lack of suckage
For a second I thought you missed Würst
No, but I do miss @mikeTheLiar.
Well now he's back!
-
@Arantor
That's obviously even worst
-
@Arantor said in Reply notifications automatically marked as read:
@Maciejasjmj said in Reply notifications automatically marked as read:
@Luhmann said in Reply notifications automatically marked as read:
@Tsaukpaetra said in Reply notifications automatically marked as read:
lack of suckage
For a second I thought you missed Würst
No, but I do miss @mikeTheLiar.
Well now he's back!
Who?
@mikeTheLiar?
-
@sloosecannon Yes. Even started his own topic.
-
Oh, are we @mikeTheLiar -ing again?
-
@HardwareGeek said in Reply notifications automatically marked as read:
@sloosecannon Yes. Even started his own topic.
Huh. Good for @mikeTheLiar
-
@Yamikuronue said in Reply notifications automatically marked as read:
Oh, are we @mikeTheLiar -ing again?
Not sure, but I think @mikeTheLiar can say
-
@Yamikuronue said in Reply notifications automatically marked as read:
Oh, are we @mikeTheLiar -ing again?
I'm not sure @mikeTheLiar would appreciate that.
-
@HardwareGeek said in Reply notifications automatically marked as read:
@Yamikuronue said in Reply notifications automatically marked as read:
Oh, are we @mikeTheLiar -ing again?
I'm not sure @mikeTheLiar would appreciate that.
I doubt @mikeTheLiar would.....
-
@sloosecannon said in Reply notifications automatically marked as read:
I doubt @mikeTheLiar would.....
If @mikeTheLiar said he did, he'd be lying.
-
@HardwareGeek you reckon we can break NodeBB's notifications by keep mentioning @mikeTheLiar ?
-
@Arantor said in Reply notifications automatically marked as read:
@HardwareGeek you reckon we can break NodeBB's notifications by keep mentioning @mikeTheLiar ?
No, but we can break @mikeTheLiar,
-
@Maciejasjmj you honestly reckon @mikeTheLiar will break before does?
-
@Arantor
What will come first ... Brexit or @mikeTheLiar blowing a gasket?
-
@Maciejasjmj you think you can break me? I'm the Kimmy Schmidt of internet trolling.
-
@mikeTheLiar
So you played an escape game before coming here?