The Formal Code Review
-
A certain Korean corporation is known to be very agile. They use the best tools to make the best software: Word for code review; a bug tracker with more ticket states than there are projects; an automatic test suite which require people to eyeball each test result, compare it to reference, and choose "pass" or "fail"; a specially crafted developer version of an OS, with explicitly disabled debugger. They use the best process to ensure each project is a guaranteed success (not any process - The Process).
Part of The Process is a periodic verification of code reviews done in Word. Let me tell you the story of
(no, don't ask me why there's a "checklist" in the name)
The Formal Code Review, being formal and all, cannot be done in some simple tool like Word. Naturally, it must be done in Excel. Let's go through it. First, you need to prepare yourself:
The Preparation consists of listing all bugs found in a file. Note: a file; guess what happens when you have multiple files to review.
You put in standard info, like department, name, review time, date, file, and then the defect list. For each defect line, you enter a description with some cryptic categorization. ST CL 3-1? We'll get to that later. Of course you also need to specify why the author introduced given defect. If you're not a mind reader, there's a standardized answer - "Wrong". Deal with it.When you feel prepared enough, you advance to the actual code review Result:
Here you have a round number, like in a boxing match, recorder (the person filling it up), file (again), version (always 1.0a; always), line count because that's the most important information in any review, and some type (nobody knows what that is). Then the fun starts: attendance. You see, The Process dictates that each member of the team makes their own code review Excel files, and we then sit in a conference room and discuss what we've found. Doing it with some online tool is not formal enough, apparently. Besides the name, department and the title of each attendee, you need to specify if he attended or not. Because attendees are known not to attend is some alternate reality. And we have a mystical column named Agreement, which needs to have an O inside. A keg of beer to anyone who knows what that means.
Going further, besides some useless statistics which must be filled (with date - again), you need to copy paste the defect list form the Preparation. Why? Maybe you have not prepared enough and some defects get lost between sheets? Note that each defect must have a date added. Someone really likes dates in The Process.Now, about those defect categories - you have a nice specification what to put in there:
For each line you have to consult this page, until you memorize it all. But one page is not enough:
You need to assign even another defect category to each line. These ones have comments! In Korean too!
After all of this, you need to fill in an even more formal defect list:
"But all this is in Korean!" - you might say. "Well, fuck you and learn!" - you might hear back.
After the dust clears, everyone can go home happy that another Formal Code Review (Checklist) has been successfully completed, and the software got undoubtedly better. The Process never fails.
-
@NeighborhoodButcher Sadly, this is bog-standard for a formal review process of a work product: http://istqbexamcertification.com/what-is-formal-review/
-
Man, just fuck Samsung.
-
@NeighborhoodButcher said in The Formal Code Review:
And we have a mystical column named Agreement, which needs to have an O inside. A keg of beer to anyone who knows what that means.
I have a suspicion. It's a checkbox which is checked (or not) with a pencil after printing out the Excel worksheet.
-
@NeighborhoodButcher said in The Formal Code Review:
And we have a mystical column named Agreement, which needs to have an O inside. A keg of beer to anyone who knows what that means.
I don't know about Korea, but in Japan, O is used as a ✓-equivalent. And × as the opposite of that.
-
Can we say Wingdings (or Webdings), where O is tick and P is cross (or vice versa)?
-
@NeighborhoodButcher said in The Formal Code Review:
For each line you have to consult this page, until you memorize it all. But one page is not enough:
You need to assign even another defect category to each line. These ones have comments! In Korean too!
Having carefully studied the above, especially Checklist No. 3-1, I have determined that your SoftWare must inevitably have Venereal Disease. It's not just Wrong, it's sinful! And the coding standard rule!
-
@aliceif said in The Formal Code Review:
@NeighborhoodButcher said in The Formal Code Review:
And we have a mystical column named Agreement, which needs to have an O inside. A keg of beer to anyone who knows what that means.
I don't know about Korea, but in Japan, O is used as a ✓-equivalent. And × as the opposite of that.
If that's the case, I would really like to know what we're agreeing to.
-
At any point during the formal code review, is code actually reviewed?
-
@Weng said in The Formal Code Review:
At any point during the formal code review, is code actually reviewed?
We actually have a secret gerrit up and copy-paste from there. Let that sink in for a minute.
-
@NeighborhoodButcher Writing an exporter for Crucible which exports Excel files in that format may take less time than going through The Process™ more than once.
-
@asdf said in The Formal Code Review:
@NeighborhoodButcher Writing an exporter for Crucible which exports Excel files in that format may take less time than going through The Process™ more than once.
Too bad you can't create software for conducting those meetings.
-
A certain Korean corporation
As I have posted else-topic, I am in the market for a new phone. A certain Korean corporation is not on my "approved vendor" list.
-
@NeighborhoodButcher said in The Formal Code Review:
Too bad you can't create software for conducting those meetings.
Oh, I'm sure you can. Just make it an online meeting and write a chatbot that can produce lip-sync video.
-
If it's a formal review, does that mean you have to wear white tie and tails to the meeting?
-
@HardwareGeek said in The Formal Code Review:
If it's a formal review, does that mean you have to wear white tie and tails to the meeting?
That, but women attend in cocktail dresses.
-
@NeighborhoodButcher If all South Koreans are like this, I would want to defect to North Korea
-
@NeighborhoodButcher Are those XLS or XLSX spreadsheets? You should put the SPANK SPANK Lemur GIF in a CDATA block if it is XLSX.
-
@HardwareGeek said in The Formal Code Review:
If it's a formal review, does that mean you have to wear white tie and tails to the meeting?
I think I need to start formal meetings around here too ...just for the funzies
-
- Maintains the goal of the reviewer (finding defects) and maximizes the synergy of the team by support and encouragement.
Yeah, I've read enough...
-
Dear career-gods, please guide my career in a way that I never have to deal with this kind of BS. :-(
-
@NeighborhoodButcher let me help you, O in the agreement box is a shorthand for Oll Korrect. Obviously.
-
@NeighborhoodButcher Fuck that, I'd rather wear tails.
-
-
@NeighborhoodButcher said in The Formal Code Review:
a mystical column named Agreement, which needs to have an O inside. A keg of beer to anyone who knows what that means.
"Obviously". You aren't going to disagree, are you?
-
@NeighborhoodButcher said in The Formal Code Review:
If that's the case, I would really like to know what we're agreeing to.
"The fault lies with a non-Korean". Just a guess.
-
@Yamikuronue said in The Formal Code Review:
Fuck that, I'd rather wear tails.
Somewhere @accalia's ears just pricked up.
-
@Yamikuronue said in The Formal Code Review:
I'd rather wear tails.
coat tails (sexy formal wear) or tail tails (very very very sexy "informal" wear)?
-
@accalia Why not both?
-
@FrostCat said in The Formal Code Review:
@accalia Why not both?
1, the coat isn't sexy before the tails are being added
2, fur is murder. (delicious murder wehn you eat the thing that wore the furr) and foxes are family!~ i'm not murdering family for my evening wear!
-
@accalia said in The Formal Code Review:
murder
Words have meanings.
The funny[1] thing is I searched for "fox in coat tails" hoping to find someone's devian tart page with a picture of a furry with a coat with tails, and got this.
[1] strange, not ha-ha
-
@FrostCat Something like this:
Apparently the correct search string was "anime fox in coat tails".
-
@accalia Both: tophat, tails, and a tail.
-
@NeighborhoodButcher said in The Formal Code Review:
Of course you also need to specify why the author introduced given defect. If you're not a mind reader, there's a standardized answer - "Wrong".
-
-