INS/DEL not playing nicely with dark themes
-
[mod - thread forked from https://what.thedailywtf.com/topic/20154/laptop-choice-for-developers/46 - @pjh]
@bb36e I hope someone fixes this someday so I don't have to highlight EVERY TIME:
-
@Magus said in laptop choice for developers:
I hope someone fixes this someday so I don't have to highlight EVERY TIME:
Maybe if you didn't skin the site...
-
@FrostCat said in laptop choice for developers:
Maybe if you didn't skin the site...
Some people require clothes, others don't. Who's to say what's better?
-
@FrostCat Just using one of the built-in ones. If they're built in and wrong, it's a bug.
-
@Magus But the ins/del button isn't part of NodeBB, so you can't necessarily expect it to work with arbitrary skins.
-
@FrostCat If you include a thing in your software and that thing does not work, you have a bug. Say what you will, a bug is a bug.
-
@Magus Ok, whose bug is it? NodeBB's, or whoever implemented the plugin? Also, who wrote the skins? Are those part of NodeBB? If not, then my question about whose bug it is becomes "Whose bug, NodeBB's, the skinner's, or the plugin's?"
-
@FrostCat What are you, @RaceProUK ?
It's the bug of whoever decided to put it in their software. NodeBB included a thing that doesn't work. It's obviously their bug. They could block the skin. They don't, so they have to deal with the bug. Don't be stupid.
-
@Magus said in laptop choice for developers:
NodeBB included a thing that doesn't work. It's obviously their bug.
But they didn't add the ins/del plugin, we did.
-
@FrostCat Then fix it.
-
-
@Magus said in laptop choice for developers:
@FrostCat Then fix it.
WOMM. First I've heard that it doesn't work.
-
@boomzilla said in laptop choice for developers:
WOMM. First I've heard that it doesn't work.
Works for me, too. But I'm not a whisperer.
-
@boomzilla We know, Jeff.
-
-
@FrostCat said in laptop choice for developers:
But they didn't add the ins/del plugin, we did.
Whoever added it obviously never tested with dark skins. It's one line of CSS to make sure the text is black instead of assuming it is because of other rules. I posted my fix in the Stylish topic.
@administrators, can you add the line to the site CSS?
-
@Jaloopa said in laptop choice for developers:
@FrostCat said in laptop choice for developers:
But they didn't add the ins/del plugin, we did.
Whoever added it obviously never tested with dark skins. It's one line of CSS to make sure the text is black instead of assuming it is because of other rules. I posted my fix in the Stylish topic.
@administrators, can you add the line to the site CSS?
Now I'm confused about what the bug even is and why we're discussing it in here. What does this all have to do with a button?
-
@boomzilla the bug is that in dark themes, del/ins text is still white, as that's the text colour. It's almost unreadable against the green and red
-
@Jaloopa Sounds awful.
-
@Jaloopa said in laptop choice for developers:
@boomzilla the bug is that in dark themes, del/ins text is still white, as that's the text colour. It's almost unreadable against the green and red
The problem is that the dark themes set the text colour to white regardless of what colour background the text is appearing on.
Our ins/del stuff doesn't actually touch the text color.
@Jaloopa said in laptop choice for developers:
Whoever added it obviously never tested with dark skins.
Dark skins weren't a thing when they were first put in.
I'll have a look.
-
@PJH said in laptop choice for developers:
Dark skins weren't a thing when they were first put in.
Haven't we had dark skins since adopting :nod:
?
-
@Jaloopa said in laptop choice for developers:
@PJH said in laptop choice for developers:
Dark skins weren't a thing when they were first put in.
Haven't we had dark skins since adopting :nod:
?ins/del went in when we had Discourse.
-
-
@PJH said in INS/DEL not playing nicely with dark themes:
The problem is that the dark themes set the text colour to white regardless of what colour background the text is appearing on.
Our ins/del stuff doesn't actually touch the text color.I mentioned that back here, thanks for fixing it.
-
Now how about this
crappyawesome link
-
-
That's how we hide our comm from the Sith
-
@PJH_3 Woo
hoot
!!!
-
I mean, it's still such weird red/green colors that it makes me think I'm colorblind, because they're meant to be tints on a white background, but this is still much better.
-
@Magus said in INS/DEL not playing nicely with dark themes:
I mean, it's still such weird
redgrey/greengray colors that it makes me think I'm colorblind, because they're meant to be tints on a white background,FTFY
-
@Tsaukpaetra I mean, I can tell the difference between the two and all, and they're definitely red and green, but only if I focus pretty hard.
You'd think someone testing the text change would notice this...
<insert blakeyrant>
Hmm, that wasn't effective enough.
Am I crazy, @blakeyrat ? Should this not have shown up in testing?
-
@Magus Don't mention me in threads I don't care about.
-
@blakeyrat said in INS/DEL not playing nicely with dark themes:
Don't mention me in threads I don't care about.
You now have the power to ignore threads you don't care about, therefore
.
-
@Tsaukpaetra Since when?
-
@Magus said in INS/DEL not playing nicely with dark themes:
@Tsaukpaetra I mean, I can tell the difference between the two and all, and they're definitely red and green, but only if I focus pretty hard.
if you need to focus hard, you're colorblind
-
@fbmac or your display is really really bad
-
@blakeyrat said in INS/DEL not playing nicely with dark themes:
Since when?
Since update\s.
Have you not seen all the threads rejoicing about it?
-
@fbmac interestingly, on my phone, the colors are more pronounced.
-
@Tsaukpaetra Honestly, no. Huh.
-
@blakeyrat said in INS/DEL not playing nicely with dark themes:
Honestly, no. Huh.
Don't worry, it was a rather short celebration.
-
@Magus said in INS/DEL not playing nicely with dark themes:
You'd think someone testing the text change would notice this...
Heh.
More seriously, the hues were chosen precisely because they were (on discourse) cromulent.
What I've done is fix a symptom, because the problem cant be fixed. The problem here is that dark themes don't consider the ins/del tags a thing and ignore them.
-
@PJH said in INS/DEL not playing nicely with dark themes:
The problem here is that
dark themesNodeBB don't consider the ins/del tags a thing and ignore them.Credit where credit is due.
-
@Magus
In https://what.thedailywtf.com/topic/19207/can-we-have-an-official-nodebb-stylish-topic-now/
I posted/* del/ins-fix */ del{ background-color:#C55; } ins{ background-color: #5C5; }The "bug" is neither with NodeBB nor with us, really. @PJH chose the colors based on a black text-color. NodeBB introduced white text-color on dark background.
They never used the del/ins background-colors, that's all TDWTF.Since dark teme requires some fixing anyway, I fixed it myself and posted about it.
Filed Under: Now the text-color is black because you made PJH fix a thing that was already fixed! Good job!
-
@PJH said in INS/DEL not playing nicely with dark themes:
What I've done is fix a symptom, because the problem cant be fixed. The problem here is that dark themes don't consider the ins/del tags a thing and ignore them.
In my less lucid moments, I've considered writing a plugin where we take those fucking skins and serve them up locally instead, which would make the unresponsive plugin able to work with custom skins. We could also then fork them and I guess fix stuff like this.
@Magus said in INS/DEL not playing nicely with dark themes:
Should this not have shown up in testing?
You'll have to figure out a way to send your visual perceptions to the testers.
-
@PJH said in INS/DEL not playing nicely with dark themes:
More seriously, the hues were chosen precisely because they were (on discourse) cromulent.
What I've done is fix a symptom, because the problem cant be fixed. The problem here is that dark themes don't consider the ins/del tags a thing and ignore them.Yeah, that's what I figured; on a white background, they're definitely the right colors. If there's a more medium color that could be used, that would be nice, but I don't know if you can detect the background color in any way, so there may be nothing you can do.
-
@Kuro said in INS/DEL not playing nicely with dark themes:
The "bug" is neither with NodeBB nor with us, really. @PJH chose the colors based on a black text-color. NodeBB introduced white text-color on dark background.
They never used the del/ins background-colors, that's all TDWTF.No one cares who did it.
@Kuro said in INS/DEL not playing nicely with dark themes:
Since dark teme requires some fixing anyway, I fixed it myself and posted about it.
Good, that is what I was hoping for.
-
@Magus said in INS/DEL not playing nicely with dark themes:
No one cares who did it.
You are clearly a lying liar who lies * as the first like 10 replies in this topic focus soley on this issue!
@Magus said in INS/DEL not playing nicely with dark themes:
Good, that is what I was hoping for.
You need Stylish to apply those styles (I guess you knew already, but better safe than sorry). I also don't know if I put the latest things I use in that post.
You might also want to read further in the topic. Some other people made some nice improvements!Filed Under: You are welcome :O
*: Copyright for "Lying liar who lies" is with blakeyrat, I think!
-
@Kuro said in INS/DEL not playing nicely with dark themes:
You are clearly a lying liar who lies * as the first like 10 replies in this topic focus soley on this issue!
People trying to play around with blame so they could ignore it. That's stupid and worthless. It changes nothing about the validity of the bug.
@Kuro said in INS/DEL not playing nicely with dark themes:
You need Stylish to apply those styles (I guess you knew already, but better safe than sorry). I also don't know if I put the latest things I use in that post.
You might also want to read further in the topic. Some other people made some nice improvements!*sigh* typical. Why must someone else own our css?
-
@boomzilla said in INS/DEL not playing nicely with dark themes:
In my less lucid moments, I've considered writing a plugin where we take those fucking skins and serve them up locally instead, which would make the unresponsive plugin able to work with custom skins. We could also then fork them and I guess fix stuff like this.
Still an advocate for this.
-
@Tsaukpaetra said in INS/DEL not playing nicely with dark themes:
Still an advocate for this.
I know. It's on my list...
Force text color in ins/del blocks to black so they play fair with da… · boomzillawtf/tdwtf@c5ca33e
