Reply as topic is not an option when replying to a post

[accalia]

Re: Notification enhancements
@boomzilla said in Notification enhancements:

The new thread button IS RIGHT THERE. /blakeyrat.

it is and it isn't. there's one hidden in the menu behind the thread level reply button, but not on the post level reply, so in order to quote part of a post and create a reply one must FIRST open the editor for replying as topic, which requires being at the top or bottom of the topic, then navigate to the post you wish to quote, highlight the text you wish to quote and hit reply in the post, far less intuitive and accessible than discourse where there was a button right there next to every post for replying to that post as a new topic.

@boomzilla said in Notification enhancements:

Err...sorry about that.

and what are you going to do about it? eeeh? :-p

Seriously though.... we should fix that.

[Onyx]

@accalia Also, it's completely unavailable on a locked topic IIRC. See: One post.

[loopback0]

@Onyx Yeah, that's where the lack of the option annoys me the most.

[accalia]

@Onyx right. that's an issue too

[boomzilla]

@accalia said in Reply as topic is not an option when replying to a post:

it is and it isn't.

I know. That's something that's on my TODO list. I figure the post buttons should have dropdowns like the topic level ones. Maybe someone could put in a request for that on nodebb's github?

[NedFodder]

@boomzilla Remember we have custom CSS here. Reply on a post is really a link, not a button:

"Reply as new topic" could easily be added to the hamburger, though...

[boomzilla]

@NedFodder Sounds like you're volunteering!

[hungrier]

@NedFodder said in Reply as topic is not an option when replying to a post:

Reply on a post is really a link, not a button

NodeBBsistency

[CHUDbert]

@abarker, time for the Nodebbeadia?

NodeBBsistency

[accalia]

@CHUDbert said in Reply as topic is not an option when replying to a post:

@abarker, time for the Nodebbeadia?

NodeBBsistency

at this point isn't it more the WTAFpedia?

[abarker]

@CHUDbert Why? People have already started adding NodeBB stuff to the Discopædia.

[Fox]

@boomzilla said in Reply as topic is not an option when replying to a post:

I figure the post buttons should have dropdowns like the topic level ones.

OR

we could utilize that *obnoxious* amount of white space between the signature and the post reply button to eliminate all drop-downs in the post buttons. Fucking Tools menu.

[ChaosTheEternal]

@Fox said in Reply as topic is not an option when replying to a post:

that obnoxious amount of white space between the signature and the post reply button

What whitespace?

[Fox]

@ChaosTheEternal BB is for way too many reasons to bother with right now. It's practically unusable. How did you even manage to navigate to that post on mobile?

Also, there's more whitespace between those buttons and the <hr> separating posts.

[NedFodder]

@boomzilla said in Reply as topic is not an option when replying to a post:

@NedFodder Sounds like you're volunteering!

Here's a start. (Disclaimer: JS is not my thing, so this code might be terrible.)

Adding the command to the hamburger didn't work. The NodeBBDevs told @Onyx how to do it, but it only adds the command to the user's own posts. Not very useful for this.

Assuming you can add a button somewhere in src/client/topic/postTools.js, it can do something like this:

function onReplyAsTopicClicked(button , tid) {
	var username = getUserName(button),
		pid = getData(button, 'data-pid');

	socket.emit('posts.getRawPost', pid, function(err, post) {
		if(err) {
			return app.alertError(err.message);
		}
		
		$(window).trigger('action:composer.replyAsTopic', {
			cid: ajaxify.data.cid,
				tid: tid,
				slug: ajaxify.data.slug,
				index: getData(button, 'data-index'),
				pid: pid,
				username: username,
				topicName: ajaxify.data.titleRaw,
				text: post
		});

	});
}

The composer has an action to create a new topic, and an action to add a quote, but no action to create a topic with a quote. So we'll need to add that somewhere like nodebb-plugin-composer-default/static/lib/composer.js.

$(window).on('action:composer.replyAsTopic', function(ev, data) {
    require(['composer'], function(composer) {
        
		var title = data.topicName;
		var topicSlug = data.slug;
		var postIndex = data.index;
		var username = data.username;
		var text = data.text;
		
		var escapedTitle = (title || '').replace(/([\\`*_{}\[\]()#+\-.!])/g, '\\$1').replace(/\[/g, '[').replace(/\]/g, ']').replace(/%/g, '%').replace(/,/g, ',');
		if (text) {
			text = '> ' + text.replace(/\n/g, '\n> ') + '\n\n';
		}
		
		if (title && topicSlug && postIndex) {
			var link = '[' + escapedTitle + '](/topic/' + topicSlug + '/' + (parseInt(postIndex, 10) + 1) + ')';
			translator.translate('[[modules:composer.user_said_in, ' + username + ', ' + link + ']]\n', config.defaultLang, onTranslated);
		} else {
			translator.translate('[[modules:composer.user_said, ' + username + ']]\n', config.defaultLang, onTranslated);
		}
 
		function onTranslated(translated) {
			composer.newTopic({
				cid: data.cid,
				title: data.title || '',
				body: translated + text
			});
		} 
        
	});            
});

I've got that all working with just a greasemonkey script (yes it's ugly, shut up):

[fbmac]

bump!

[Tsaukpaetra]

@fbmac said in Reply as topic is not an option when replying to a post:

bump!

Really?

[accalia]

@Tsaukpaetra said in Reply as topic is not an option when replying to a post:

@fbmac said in Reply as topic is not an option when replying to a post:

bump!

Really?

apparently nothing is sotempting to an fbmac as an opportunity to play necromancer

[sloosecannon]

@accalia said in Reply as topic is not an option when replying to a post:

@Tsaukpaetra said in Reply as topic is not an option when replying to a post:

@fbmac said in Reply as topic is not an option when replying to a post:

bump!

Really?

apparently nothing is sotempting to an fbmac as an opportunity to play necromancer

Swear to god, if he keeps it up, I will find that ball of string and untie every. single. bit.

[aliceif]

@accalia well, how do I reply to this post in a new topic?

[accalia]

@aliceif said in Reply as topic is not an option when replying to a post:

@accalia well, how do I reply to this post in a new topic?

I DON'T KNOW!~

you figure it out if you're so smart! i'm over here trying to keep the warp core reactor from overloading and splattering our remains across seventeen spatial dimensions and twelve time dimensions! i've got enough on my plate without worrying about how one replies as a new topic to a post!

</fakerant>

seriously.... i'll look into it..... soonish....... yeah......

[fbmac]

@accalia good rant 5/5
will troll again