Ignoring a topic
-
@flabdablet said in Ignoring a topic:
Couple of things. First, why is the icon for "show in unread" different from the icon on the actual "unread" menu item (the one that looks like an in-tray)?
Hmm...that could work. I was continuing the use of the and as they exist now.
@flabdablet said in Ignoring a topic:
Near as I can tell, what you're doing here is providing two controls, one that says whether or not thread activity shows up your notifications list and the other that says whether or not it shows up in your unread list.
Does is really make sense to split those out? Would you ever want to be notified of posts but see the thread as unread in the normal ways? It seems reasonable to me to have this setting indicate a user's level of interest in a thread.
@flabdablet said in Ignoring a topic:
Or if you're going to do it the new hipster everything-is-a-phone
Nope.
@flabdablet said in Ignoring a topic:
If there's currently no way to remove thread activity from both the notification list and the unread list, switching off either could switch on the other one. Then, when that ability does become available, just stop doing that.
This change is that ability becoming available.
-
@boomzilla said in Ignoring a topic:
Does is really make sense to split those out? Would you ever want to be notified of posts but see the thread as unread in the normal ways?
Sure. I find the Unread list completely useless. It always has some number >90 attached to it that just goes up and down at random. I don't pay attention to it but find it distracting. If I could just mark everything Read and make that number never appear again, I'd be happier.
-
@boomzilla Main thing is, though, that splitting them out makes the controls simpler. I can see no reason to complexify controls for the sole purpose of disallowing a use case that looks weird but is otherwise harmless.
The notification list and the unread list are separate things, so having simple, independent on/off controls for each seems natural.
-
@flabdablet said in Ignoring a topic:
I find the Unread list completely useless
How do you read the forum? I mean...how do you choose which topics to read? Also, please compare to how you picked what to read on discourse.
@flabdablet said in Ignoring a topic:
It always has some number >90 attached to
I think they basically cap the number at that for performance reasons.
@flabdablet said in Ignoring a topic:
The notification list and the unread list are separate things, so having simple, independent on/off controls for each seems natural.
I'm far from convinced on this.
-
@boomzilla said in Ignoring a topic:
How do you read the forum? I mean...how do you choose which topics to read?
- Respond to notifications.
- Occasionally find some list of topics curated by mysterious processes I cannot be arsed trying to understand, and pick an interesting looking topic off it.
Same method as Dicksauce.
@boomzilla said in Ignoring a topic:
I'm far from convinced on this.
New posts should
generate notifications
appear in UnreadI can't see how anything else could conceivably be simpler.
-
@flabdablet 'Unread' works the same way it works on countless PHP-based forums: new posts since you last read it
-
@RaceProUK Right, and having a per-thread checkmark to turn that off would stop topics of little interest cluttering up my Unread list. That might even make it useful.
-
@flabdablet And you'd effectively have that. But I'm not seeing a lot of utility in separating out the notifications.
Now, it's possible this is all moot:
I'm not exactly sure what's been done there, though. It's certainly something different.
-
Ah...
+ results.unreadTopics.filters = [{ + name: '[[unread:all-topics]]', + url: 'unread', + selected: filter === '' + }, { + name: '[[unread:new-topics]]', + url: 'unread/new', + selected: filter === 'new' + }, { + name: '[[unread:watched-topics]]', + url: 'unread/watched', + selected: filter === 'watched' + }];
Looks like different unread lists.
-
@boomzilla said in Ignoring a topic:
I'm not exactly sure what's been done there, though. It's certainly something different.
New posts should
generate notifications
appear in Unread
increase the gerbils
-
@boomzilla That would help those who want separate unread/new lists too
-
@baris said in Ignoring individual threads:
Ok so this PR is merged I also added another filter for watched topics. So now the /unread page has this
Pretty sure there will be some bugs and confusion with the unread number in the top bar since that shows the number for all topics. Also if you go to
/unread/watched
it will show topics from categories that you ignore. So for example you can ignore the testing ground category but watch a single topic from there and see it in/unread/watched
That linked PR is from @ben_lubar.
-
@RaceProUK said in Ignoring a topic:
That would help those who want separate unread/new lists too
Yeah, that's really what this does. I suspect that we're still going to need the additional ignore topic capability. Assuming that the "watched topics" setting still spams you with notifications.
We'll see, I guess.
-
@boomzilla Yeah, I don't want more notifications, just the ability to avoid having to select seven or eight threads and do Mark As Read because I stopped caring about them
-
@Yamikuronue Right. This was really meant to address new topics. And I guess it made sense to also filter on watched or not since the data was already available.
-
@flabdablet said in Ignoring a topic:
@boomzilla said in Ignoring a topic:
I'm not exactly sure what's been done there, though. It's certainly something different.
New posts should
generate notifications
appear in Unread
increase the gerbils
KILL IT WITH FIREIf I select that last option, it shouldn't appear in any list or search ever. There should be one area in my profile called "Here thar be dragons", which requires clicking through several modal popups and entering passwords and other secret information. Then it will show the list of topic I've marked as 'fuck this shit'.
-
@Lorne-Kates said in Ignoring a topic:
other secret information
Like the name of your first child?
I see that field isn't filled in. Could you PM me the missing information asap?
-
-
@ben_lubar What are you trying to say? Looks like you'd have to set up a custom navigation route in admin -> general -> navigation for that.
-
@boomzilla there's a dropdown menu in the upper right of the unread pages.
-
@ben_lubar Yes.
-
@Lorne-Kates said in Ignoring a topic:
There should be one area in my profile called "Here thar be
dragonsguacamole"FTFY
-
Listen up peep gang! I've pushed stuff upo to my ignore-topic (and, err...thread in one case) branches:
Would appreciate a review / test from anyone able and willing before I submit this as a PR.
-
I'd like to, but I'm not seeing any difference. Is a custom style sheet needed?
-
@CHUDbert Are you running the ignore-topic branch? What theme are you using? Is the computer on?
No, you shouldn't need a custom style sheet.
-
@boomzilla Using readable skin, firefox, but I have pagination on, so that could be messing with it. At bottom of topic I see
-
@CHUDbert Turned pagination off, no difference.
-
@CHUDbert Based on your screenshot, it looks like you're on TDWTF. I meant for someone with a local instance to try it out and see what I fucked up. It's not deployed anywhere, just pushed to github right now.
-
@boomzilla, correct, didn't know about that. I figured we were brave enough to be running off of our own branch so we could breaking things quicker...
-
@CHUDbert I want to cross my 'i's and dot my 't's so I can tell blakey to fuck off when he whines about it.
-
@boomzilla I don't care if your only reason for caring about quality is "spite", as long as you care about quality.
-
@boomzilla Installing now. BTW, you have three GH projects, two of the branches are called
ingore-topic
and one is calledignore-thread
. *shakes fist*
-
@NedFodder I know, hence the parenthetical.
@blakeyrat said in Ignoring a topic:
@boomzilla I don't care if your only reason for caring about quality is "spite", as long as you care about quality.
Actually, I mostly don't what @ben_lubar to just go and deploy it or whatever. Also, I want to get it good before I submit a PR to NodeBB.
-
@boomzilla said in Ignoring a topic:
parenthetical
You expect me to read those?
So far I've got this:
There's no drop-down arrow on the Following button, and clicking on it does nothing. What am I doing wrong?
-
@NedFodder said in Ignoring a topic:
What am I doing wrong
Probably the themes. Here's how I set it up:
- Clone the theme repos from github.
- From the root of the theme repo's tree,
sudo npm link
- Delete the theme from
$nodebb/node_modules
npm link nodebb-theme-persona
- Repeat as necessary for the vanilla theme, but persona is the default and what we use here
That uses npm to install the local version of the theme via symlink. Make sure you have the branch checked out on the theme repo.
-
@boomzilla I just deleted the old themes and cloned the new themes directly to
node_modules
.After undoing that and doing it your way, I still get the same broken button.
-
@NedFodder Well, I just noticed that my last commit, with tests, didn't get pushed correctly. That's fixed now.
Grr...apparently my ignore-topic branch didn't get the update in the theme. nodebb-theme-persona's master branch has the update.
-
@boomzilla *shakes fist again* So should I clone the persona master branch, or are you gonna fix the ignore-something branch?
-
@NedFodder Shit. That seems like work. Just use the master branch for now.
-
@boomzilla Found some strange behavior. I have a topic with just two posts, you can see both posts and the bottom menu at the same time:
I click on the top Reading button, select Following, and then the bottom menu opens up:
I just repeated this with a long topic. I navigated to post 1, clicked on the button, selected an option, got jellypotatoed to below the last post of the topic, and the bottom menu was open.
That was with Chrome. Slight difference with FF: instead of getting jellypotatoed to below the last post, I get sent to the top of the last post.
-
@NedFodder Hmm...interesting....does the Sort by menu do that? Goes to check....
EDIT: nope...looks like the sort menu has a special file in modules to handle it.
-
@boomzilla Sort always sends you to the top.
-
@NedFodder Fasckinating.
-
@boomzilla More unexpected behavior.
- I have three unread posts, and I'm viewing
/unread
. - Someone makes a post in a topic I'm ignoring.
Expected behavior:
- Nothing.
Actual behavior:
- The red number at the top goes from 3 to 4.
- The
There is a new post. Click here to reload.
toaster pops up. - I clicked on the toaster. The toaster went away but no new posts showed up, and the red number stayed at 4.
- Hard refresh made the red number go back to 3.
I'd say this one is pretty bad. Lots of people will complain about phantom new posts that never show up.
EDIT: I just tried to reproduce those steps. The toaster still came up and the number incremented, but clicking on the toaster made the count go back to the correct number.
- I have three unread posts, and I'm viewing
-
@NedFodder said in Ignoring a topic:
Lots of people will complain about phantom new posts that never show up.
Happened in Discourse all the time, though the Unread counter didn't actually change but the "there are new posts" bar always did.
-
@ChaosTheEternal I remember that. I meant to say that people will complain about the count changing, more so than the toaster.
-
@NedFodder said in Ignoring a topic:
I'd say this one is pretty bad. Lots of people will complain about phantom new posts that never show up.
True. Need to see how those happen....
-
@NedFodder said in Ignoring a topic:
Sort always sends you to the top.
That might be intentional, given that you're reordering the posts. This particular weird behavior on the part of the following menu was me trying to close the menu. I'm going to leave it alone. It seems to close on its own, just not immediately after clicking.
The problem is that in order to get it to be on the page twice:
$('.post-bar').clone().appendTo(mainPost);
So later grabbing by component ends up finding both of them, causing the issues.
-
And let's not forget "moble" mode...
-
@boomzilla
npm install git+https://github.com/boomzillawtf/repo.git#branch