Last read on short topics
-
This is totally driving me crazy. Apparently it used to be worse. It used to ignore that if a post had less than 10 posts. Last October it was reduced to 5:
Bookmark isn't presented when post count <= 10 · Issue #3759 · NodeBB/NodeBB
Small bug in the public/src/client/topic.js file, in the handleBookmark function: this line: else if (bookmark && (!config.usePagination || (config.usePagination && pagination.curre...
The correct strategy may be to make this be configurable by an admin so we could set it to 0, since one of the core devs seems to like having this. He didn't want to put the effort in to make this configurable, but maybe they'd accept it if someone else did?
-
@boomzilla I love bugs like this where people go out of their way to make their own product worse.
-
@boomzilla drives me mad too. The right damn thing to do would top set that to 0 and if one is on the last post, then It's read if you have the bottom of the post in your viewport.
-
I'm just going to post here so the topic grows beyond the magic 5+ tresshold
-
@Luhmann So close!
-
@boomzilla and yet so far?
-
@boomzilla
I thought about posting twice but that sounded so much like work ...
-
@boomzilla said in Last read on short topics:
set it to 0
@swayde said in Last read on short topics:
set that to 0
It should be either 1 (if the first post isn't counted) or 2 (if it is counted). Because you'll land on the first post regardless of whether there's a bookmark there or none at all.
-
@boomzilla said in Last read on short topics:
It used to ignore that if a post had less than 10 posts. Last October it was reduced to 5
-
Hey @TDWTF-NodeBB-Development (NB: that's a public group, feel free to add or remove yourself) people, I made a branch that makes this configurable (default to 5, as it currently works):
GitHub - boomzillawtf/NodeBB at customize-bookmark-threshold
Node.js based forum software built for the modern web - GitHub - boomzillawtf/NodeBB at customize-bookmark-threshold
What you think?
-
Pull request submitted:
Customize bookmark threshold by boomzillawtf · Pull Request #4512 · NodeBB/NodeBB
Adds a site specified threshold for user last read bookmarks. Defaults to 5, the current hard coded value, previously set in response to issue #3759. Not remembering that the user read something ca...
-
Woo hoo! Pull request accepted. Sort of. The code is in there, which is the important thing.
-
@boomzilla if the code is there, can we just set it globally to 2 here?
...I mean, you really don't need a bookmark to the last post if there's only 1 post. So it only makes sense to have it kick in at 2 posts.
-
@anotherusername No, I think 1 is the correct setting.
-
@boomzilla depends on whether it's counting the topic starter as a post or not.
