1. Home
  2. Categories
  3. Meta
  4. Bugs
  5. Don't onebox in the middle of my code tags!

Don't onebox in the middle of my code tags!

  • Weng
    Garbage Person

    Furthermore, pre/code seems to treat CRLF as two line breaks. Which is fucking dumb.

    ====Executing command 'npm install'====

    npm WARN package.json nodebb-plugin-soundpack-default@0.1.6 No README data
    npm WARN package.json passport@0.3.2 No README data
    npm WARN git config --get remote.origin.url returned wrong result (git://github.com/wzrdtales/simple-recaptcha)
    npm ERR! git clone git://github.com/wzrdtales/simple-recaptcha
    npm ERR! Error: spawn ENOENT
    npm ERR! at errnoException (child_process.js:1011:11)
    npm ERR! at Process.ChildProcess._handle.onexit (child_process.js:802:34)
    npm ERR! If you need help, you may report this entire log,
    npm ERR! including the npm and node versions, at:
    npm ERR! http://github.com/npm/npm/issues
    npm ERR! System Windows_NT 6.1.7601
    npm ERR! command "C:\Program Files\nodejs\\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "install"
    npm ERR! cwd C:\Users\Weng\Documents\GitHub\NodeBB-SQL
    npm ERR! node -v v0.10.35
    npm ERR! npm -v 1.4.28
    npm ERR! syscall spawn
    npm ERR! code ENOENT
    npm ERR! errno ENOENT
    npm

    ====npm command completed with exit code 1====

    or

    ====Executing command 'npm install'====

npm WARN package.json nodebb-plugin-soundpack-default@0.1.6 No README data
npm WARN package.json passport@0.3.2 No README data
npm WARN `git config --get remote.origin.url` returned wrong result (git://github.com/wzrdtales/simple-recaptcha) 
npm ERR! git clone git://github.com/wzrdtales/simple-recaptcha 
npm ERR! Error: spawn ENOENT
npm ERR!     at errnoException (child_process.js:1011:11)
npm ERR!     at Process.ChildProcess._handle.onexit (child_process.js:802:34)
npm ERR! If you need help, you may report this *entire* log,
npm ERR! including the npm and node versions, at:
npm ERR!     <http://github.com/npm/npm/issues>
npm ERR! System Windows_NT 6.1.7601
npm ERR! command "C:\\Program Files\\nodejs\\\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "install"
npm ERR! cwd C:\Users\Weng\Documents\GitHub\NodeBB-SQL
npm ERR! node -v v0.10.35
npm ERR! npm -v 1.4.28
npm ERR! syscall spawn
npm ERR! code ENOENT
npm ERR! errno ENOENT
npm

====npm command completed with exit code 1====
    2 Choonster blakeyrat 2 Replies
  • Choonster

    Does it onebox inside markdown code blocks?

    ====Executing command 'npm install'====

npm WARN package.json nodebb-plugin-soundpack-default@0.1.6 No README data
npm WARN package.json passport@0.3.2 No README data
npm WARN `git config --get remote.origin.url` returned wrong result (git://github.com/wzrdtales/simple-recaptcha) 
npm ERR! git clone git://github.com/wzrdtales/simple-recaptcha 
npm ERR! Error: spawn ENOENT
npm ERR!     at errnoException (child_process.js:1011:11)
npm ERR!     at Process.ChildProcess._handle.onexit (child_process.js:802:34)
npm ERR! If you need help, you may report this *entire* log,
npm ERR! including the npm and node versions, at:
npm ERR!     <http://github.com/npm/npm/issues>
npm ERR! System Windows_NT 6.1.7601
npm ERR! command "C:\\Program Files\\nodejs\\\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "install"
npm ERR! cwd C:\Users\Weng\Documents\GitHub\NodeBB-SQL
npm ERR! node -v v0.10.35
npm ERR! npm -v 1.4.28
npm ERR! syscall spawn
npm ERR! code ENOENT
npm ERR! errno ENOENT
npm

====npm command completed with exit code 1====

    Edit: Looks like it doesn't.

    0
  • PJH
    Discourse touched me in a no-no place

    pre also oneboxing..

    npm ERR! including the npm and node versions, at:
npm ERR!     <http://github.com/npm/npm/issues>
npm ERR! System Windows_NT 6.1.7601
    0
  • ben_lubar

    <pre> doesn't stop parsing of its contents. Not a bug.

    0 PJH 1 Reply
  • PJH
    Discourse touched me in a no-no place

    @ben_lubar said in Don't onebox in the middle of my code tags!:

    <pre> doesn't stop parsing of its contents. Not a bug.

    With all due respect, that's bollocks. The whole point of pre is to not interpret its contents. Things like not interpreting <. Or not collapsing multiple spaces. Or not inserting linefeeds. Or - in this instance - not expanding oneboxes.

    Totally a bug. Or, perhaps, less aggressively - not the expected behaviour. Perhaps we could have a poll on the matter?

    Talking of which, having to re-add the backticks into your quote, to stop <pre> not appearing in the quote, is another bug.

    4 ben_lubar 1 Reply
  • ben_lubar

    @PJH said in Don't onebox in the middle of my code tags!:

    Things like not interpreting <

    Except that it does interpret <. pre is not CDATA.

    0 PJH Weng 2 Replies
  • PJH
    Discourse touched me in a no-no place

    @ben_lubar said in Don't onebox in the middle of my code tags!:

    Except that it does interpret <. pre is not CDATA.

    Oops. I done fucked up....

    0
  • blakeyrat

    @Weng This one box plugin is broken buggy shit.

    Why did "we" (by which I mean "Ben L, unilaterally") turn it back on? Until it's about 40,000 times better than it is today, trying to deal with this shit is a waste of time.

    0 cartman82 A 2 Replies
  • cartman82

    @blakeyrat said in Don't onebox in the middle of my code tags!:

    @Weng This one box plugin is broken buggy shit.
    Why did "we" (by which I mean "Ben L, unilaterally") turn it back on? Until it's about 40,000 times better than it is today, trying to deal with this shit is a waste of time.

    Hmm, slight convenience for me vs DDOS that's not really my problem.

    Keep it on, ben.

    4
  • Weng
    Garbage Person

    @ben_lubar ... Can we have CDATA? With syntax highlighting?

    0 ben_lubar 1 Reply
  • ben_lubar

    @Weng you can either put four spaces before each line:

    def foo():
    return "https://www.google.com/"

    or put three or more backticks (```) on the lines immediately before and after the code block:

    def foo():
    return "https://www.google.com/"
    2 JBert 1 Reply
  • JBert
    Fake News

    @ben_lubar

    Is your final answer "you're doing it wrong"?

    6 Weng 1 Reply
  • Weng
    Garbage Person

    I thought "No markupdownupdownleftrightleftrighbabastart markup soup" was one of our key functional requirements. Or was that requirement discarded as nothing on the market provides such functionality anymore?

    4
  • PleegWat
    Java Dev

    Can we just fix the onebox plugin to only onebox url patterns that match the whole line?

    3 A 1 Reply
  • A

    This should be easy to settle, let's all vote here

    [poll]

    • Keep onebox plugin enabled
    • Disable it until it gets better
      [/poll]

    Oh, right, no polls anymore...

    3
  • A

    @PleegWat To be on the safe side, I'd make it require some explicit tag or syntax, i.e. just write something like [embed]http://myurl.invalid/thing.html[/embed] or {http://myurl.invalid/thing.html}.

    2
Log in to reply