Hashes in links break history handling, completely
-
Repro:
- Click this link (
href
is#link
) - Click on the header or navigate away from this topic in any way other than using a back button (
EDIT: suggested topics seem to work properly thoughNever mind, I messed the link up, broken as expected) - See your URL not change
- Bonus : try re-entering this topic from
/latest
- Click this link (
-
try re-entering this topic from /latest
Clicking on the topic from
/latest
did nothing, but F5 got me back here.
-
F5 ANYWHERE after doing this will get you back here.
Well... that's a way to handle bookmarking too, amirite?
-
I can verify that this is broken with the history spamming disabled ("Don't update URL while scrolling through topics") too. URL doesn't change on navigation and can't come back to this thread by clicking it in
/latest
.Although, my GreaseMonkey script that updates the URL manually on page blur fixed the URL so it's working again without a hard refresh.
-
Clearly the only thing capable of rendering Discourse correctly would be a web browser implemented in Discourse. Discourobouros!
-
-
...also when I said 'correctly' above, I actually meant 'works on my machine what do you mean regression how do I QA? '...
-
Oh, you use Discobrowser? That's different.
-
You know, if I ever get that native mobile client thing going, I might call it Discobrowser, just for shits and giggles.
-
Different to itself.
-
-
Will it have a as its app icon?
-
Dunno yet. Bikeshedding may commence once I get something that even remotely works. I'm not there yet.
-
Why not just skip a lot of hard work and make the browser only capable of displaying pictures of bikesheds now?
-
It doesn't even need that; all it needs is
<span class="fa fa-spinner fa-circle-o-notch"></span>
-
I completely forgot which FA spinner Discourse uses ever since I CSS'd it to a Dreamcast logo.