Mentioning User ending with Underscore: FAIL
-
, Discourse! No mention for @LB_?
It's not because his username is only three characters, I can mention @PJH.
Is it the underscore? Can I escape the underscore like this @LB_? I guess not...
-
How about @LB_?
edit: for some reason, @LB_ gets wrapped in
<span class="mention">
instead of<a class="mention">
... I wonder if either/both of them generate a mention notification?
-
It doesn't open the usercard when I click your makeshift mention, so I assume it doesn't notify LB_
Filed Under: "Why would a user call himself anything but "
codinghorrorend" anyway? Thats just doing it wrong!" -
-
It's actually
<span class="mention">@LB</span>_
. Yes, the underscore is outside the span.Does this work @LB_?
EDIT: It works in preview.
-
It's actually
<span class="mention">@LB</span>_
. Yes, the underscore is outside the span.Good catch.
It doesn't open the usercard when I click your makeshift mention, so I assume it doesn't notify LB_
Ah, but if you click the
_
it does! The<span>
is blocking the click.
-
Ah, but if you click the
_
it does! The<span>
is blocking the click....... :WTF:
-
......
Not really that surprising. The HTML source is identical, so the click event has to be globally trapped*... if the event target is a
<span>
the click trapping doesn't work and the default action is performed, which is to bubble the event up to the<a>
and follow the link.(*or it could programmatically register a click event handler for every
<a>
element, but I think that would be even more )
-
The HTML source is identical
In hindsight, that wasn't a very clear way of saying that there are no special onclick event handlers in HTML for the
<a>
tags.
-
Isn't this actually an honest to goodness regression? I CBA to go searching for it at work, but my recollection is this has been found and fixed previously...
INB4: there are no regressions in DC
-
You think we're visiting Regression Town, USA?
Fucking DIscourse, just when you think there can't be any new ways that it's broken in ways that it shouldn't be, it throws up a new one.
-
it throws up a new one.
That doesn't sound like a regression, though!
Filed Under: you can still complain about the lack of testnig, though
-
Hm, looking here: https://meta.discourse.org/t/mentiong-usernames-with-trailing-underscore-does-not-work/34290 and the parent thread suggests this is, in fact, a bugshed, and not a regression.
Though since it arose from expanding the potential space of allowable usernames, is it more a feature-bug, and less a bikeshed-bug?
-
#SHOULD I FILE A BUNG ON META.DERP?
-
-
The rule is like this:
Can you reproduce it on mobile?
Yes: Don't file it! It's clearly just bikeshedding!
No: Don't file it! It's clearly just bikeshedding!
What does this have to do with anything: Don't file it! It's clearly just bikeshedding!Filed Under: Hope I could help
-
Prepare to meet Jeff's banhammer pretty soon
-
Oooh, I love this example from the original bug report.
@username_, @another_user
@username_, @another_user
-
I would like to mention @LB_, and then type an underscore here:_.
-
the name formatting as a mention, but clicking on the @<g>mention does not bring up a user card, unless you click specifically on the underscore
The name didn't format as a mention, not by itself at least. If you look at the raw, I wrote the HTML that made it formatted as a mention.
-
-
The name didn't format as a mention, not by itself at least. If you look at the raw, I wrote the HTML that made it formatted as a mention.
Sure, but I didn't say the text you quoted ;)
-
-
Micregression? Microgression? Working out the exact term is important.
-
Ok guys, it's just unclosed underscorey things:
_ @Lorne_Kates
=> ✓
_, @Lorne_Kates
=>
**_ @Lorne_Kates**
=> ✓
_:mouse: @Lorne_Kates
=>
__, @Lorne_Kates
=>_ @Lorne_Kates
, @Lorne_Kates
** @Lorne_Kates**
_ @Lorne_Kates
__, @Lorne_Kates
-
-
@anotherusername said:
The name didn't format as a mention, not by itself at least. If you look at the raw, I wrote the HTML that made it formatted as a mention.
Sure, but I didn't say the text you quoted ;)
I know you didn't. Replying to your post and quoting the part I wanted to refer to was easier than figuring out who did and/or how to quote the oneboxed link "correctly", though.
-
I had no idea this thread existed. I've never gotten an at-mention before.
-
@LB_ Maybe?
I dunno, lets try titles...Edit: Nope lol, underscore is purposefully kicked out! Poor underscore...
-
Well, that explains why I haven't gotten any @ notifications in a while.
Wow. I wonder, do any of the Discodevs have _ in their usernames?
-
We should resolve this issue @eviltrout either by disallowing trailing _ or otherwise.
disallowing trailing _
Filed under: also, raw
-
>disallowing trailing _
So would "fixing it" for existing users mean their accounts get anonymized in that update?
-
Amazing, you mentioned WTDWTF and didn't get banned. Is Jeff getting soft? Has he started to forgive our sins (whatever they were)?
-
-
@LB_ fa-spin
-
-
We should resolve this issue @eviltrout either by disallowing Markdon't
trailing _<
-
My favorite part is the "or otherwise".
In spirit, as a software designer and architect, I think I understand what His Jeffiness is on about: mentions are core functionality (actively engage people in discussion), as is the markupupdowndownleftrightleftrightBAstart parser (make mildly complex composition approachable no matter what someone's online discussion background is). If the two cannot be made to coeexist with the edge functionality of "users with weird taste in names", trailing underscores need to go.
It would have better been phrased as "We should resolve this issue, @eviltrout. By disallowing trailing _ if necessary." (note the additional punctuation for more comprehensible constructive discourse).
I don't agree with his choice of not-markdown as the solution for the "approachable composition" design goal (We invented WYSIWYG for that how many years ago?), but I understand the logic and have made similar calls.
-
"users with weird taste in names"
Look, there was a three character minimum, and just like @Lorne_Kates I didn't know dashes were allowed. (Not mad at you, @Weng)
-
Frankly, I'm lucky the substring "eng" doesn't have special meaning to the markdiagonally parser.
-
So apparently direct linking bypasses the filter.
-
..... This needs to be investigated further.
-
markupupdowndownleftrightleftrightBAstart parser
This is the most magical wording ever used on Discourse.
-
@Weng said:
"users with weird taste in names"
Look, there was a three character minimum, and just like @Lorne_Kates I didn't know dashes were allowed. (Not mad at you, @Weng)
On the old forums, my username had a space in it but NO ONE USES SPACES IN USERNAMES THAT IS NOT A PROPER USECASE UNSUPPORTED WONT FIX!!!!!!!!!!!!!!!!!!!!
So during the import, my username got munged because Discourse is less functional than Community Server.
I'm sure the fix for this will be fucktacular. Keep in mind that there's a bug in Discourse where if you register with the username user, it'll fuck up your notification page because /user/ is Special So the solution was to ban the username user and make it so that you can't register that username.
There's a massive list of these "unacceptable" usernames in the Dysentery codebase. A whole collection of canaries that should scream "THESE DEVS DONT KNOW HOW TO HANDLE DATA RUN THE FUCK AWAY".
I'm sure next will be:
OnUserSelectsUsername(username) { if(username != htmlbbcodemarkdown(username)) $banned = true; if(username != DiscourseModifyUsernameToAnchorAfterMention(username).InnerText) $banned = true; if(username != EverySingleOtherTransformativeFunctionInDiscourse(username)) $banned = true; return $banned };
Every time Discourse updates, it'll re-run this function for every user, and randomly ban people who had the gall to pick an "unacceptable" username.
Filed under: How's the new forums coming?
-
If the two cannot be made to coeexist with the edge functionality of "users with weird taste in names", trailing underscores need to go.
No, that means that they're supposed to fix their shit so that they can coexist. I mean, that's just bizarre.
- "Hey, Mr. J, there's a bug report saying you can't mention people with names starting with a letter M."
Jeff from a bizarre parallel universe where he's a sane man: "Jesus Christ, people, how do you even fuck this up? Quick, push the fix before someone lands our code on The Daily WTF."
Jeff from current universe: "Well, my name doesn't have a letter M in it, my nick doesn't have a letter M in it, who needs a letter M anyway? It's a stupid letter. Ban it."I mean, someone eventually is going to want to register with a trailing underscore, be told his name is invalid because reasons, then he'll move the underscore to the beginning and it's going to work. And he'll be like "WTF is up with this broken software" even before he experiences the whole fucking package.
-
(also, under "things I just realized:")
-
I didn't know dashes were allowed.
If they'd been not allowed, it would have told you in account creation, right?
-
(also, under "things I just realized:")
I spent way too long on this, I hope Jeff appreciates it!
Filed under: Wanna see how I got these bugs?
-
@Lorne_Kates said:
WONT FIX!!!!!!!!!!!!!!!!!!!!
Yeah, but what you don't realize is that the thing with trailing underscore is in fact FEATURE WONTFIX!
Now, I'm unmentionable. I'm unsummonable. I can't be called, I can't be sent for before the evil ruler. I'm a shadow, I'm a ghost, I'm forever unmentionable. But I'm only one of many. We call ourselves... The Unmentionables!
-
-
Yeah, let's call the group
unmentionables_
.