Notification payload now delivered over the message bus
-
ping @accalia
-
This I will have to play with.....
😁
-
Does that change mean, once deployed, we don't have to poll both messagebus and notifications?
-
i will have to double check the implementation, in particular the behavior if multiple notifications come in before message-bus is polled again, but otherwise.... yes it looks like that may be the case.
-
It'll be interesting to see how it works with cyberparts; if notifications are going to be part of messagebus, we need to be careful we don't accidentally mark them read
-
that will be a design consideration....
and a solveable one actually, if we never register for the notifications channel we'll never get notifications through message-bus. ;-)
-
Does this also mean that the delay caused by asking the server for notifications is gone? And they're just queued up as they come in?
-
My understanding is that is the intention; should keep the rat happy (well, marginally less vitriolic anyway)
-
BECAUSE WHY THE FUCK WASN'T IT THAT WAY FROM THE START!? Seriously, nobody at Discourse, Inc said, "hey guys, this is a really really shitty awful design, we should redo this" before it was 2 years old? It's incredible how incompetent the fuckers running this project are.
But hey, a fix is a fix. Now they only have 574,3421,312834712846124 bugs left.
-
Cue a load of new notification bugs then, I guess.
-
574,3421,3128347128461245,743,421,312,834,712,846,124FTFY
How did you even manage to put 4 digits in one grouping?
-
How did you even manage to put 4 digits in one grouping?
Maybe he is secretly a japanophile? Traditionally, numbers are written in groups of 4 there.
-
-
Does this also mean that the delay caused by asking the server for notifications is gone? And they're just queued up as they come in?
HAHAHAHAHHAHAHA nope
Also, just trying to read the notifications popup is a fucking chore now. This is me trying to read it. I'm not moving the mouse. I'm not clicking on anything:
Filed Under: Filed Un[loading] Filed U[loading] F[Loading][loading][loading] Filed Under
-
@Lorne_Kates said:
HAHAHAHAHHAHAHA nope
We don't have that yet. It's probably on fail.d, where they've done away with the notification dropdown altogether. Actually, it does seem snappier over there, but they have a beefier server (and I have far fewer notifications), too, so it's not trivial to compare:
-
yeah i checked at message-bus... we don't have this new feature yet.
-
Good, we've got other bugs to find first!
-
Actually, it does seem snappier over there
This change is exactly what you're seeing making the notifications snappier.
-
574,3421,312834712846124
Oh shit, @blakeyrat was infected by a new variety of disconumbering.
ETA: Yes, yes,