Mystery badgers...

tar

So I got a notification this morning saying I was a MediocHre Poster again...

But when I went to check, there's no corresponding entry on the badgers page...



RaceProUK

The timestamp of the badge is that of the post, so your badge is in that list, but you have no idea which is the one just granted.

DISCHORSE!

tar

But there should be an entry there from 3 hours ago (now)... that's how it's always worked in the past:

Get notification.
goto badger page
click on your name
goto post, go "oh yeah, lol..."
resume normal activity.

tar

I mean, the badgers are in time order, there should be one with the same timestamp as the notification...

RaceProUK

But it's like I said; the timestamp on the badger is the timestamp from the post, not when the badger was granted.

@PJH, can you confirm?

tar

Did this behaviour change recently, as in the last 12 hours or so? Because that's how it's always worked every time until now...

tar

@RaceProUK said:

timestamp on the badger is the timestamp from the post, not when the badger was granted.

@PJH, can you confirm?

I disagree—but yes, confirmation needed...

PleegWat

IIRC, the notification timestamp is supposed to equal the timestamp of whatever it is notifying, in this case the granting of the badge?

aliceif

FWIW, the two "Good Post" badgers I just received both have a timestamp of 1day.

HardwareGeek

The timestamp on what.thedailywtf.com/users/foo/notifications is when the badge was awarded.

what.thedailywtf.com/badges/id/name is sorted in (reverse) chronological order of award, but the timestamp is the date of the post for which it was awarded, if applicable.

aliceif

Which is new and not a good thing.

HardwareGeek

@aliceif said:

Which is new

My memory (which is not always reliable) tells me that this behavior has existed for quite a while, if not since the beginning.

@aliceif said:

and not a good thing

On this we agree.

tar

There's no way to filter badges awarded per-user, is there? DC tells me I have 38 Mediocre Posters, but I don't fancy trolling the whole list manually to verify this claim...

HardwareGeek

@tar said:

filter badges awarded per-user

Why would anyone ever want to do that? CLOSED_WORKS_AS_DESIGNED_WONT_FIX
Note: Closed before waiting for any possible replies. No dissent permitted.

aliceif

@tar said:

There's no way to filter badges awarded per-user, is there

Yep. Yet another awful thing about badges.

JazzyJosh

@RaceProUK said:

the timestamp on the badger is the timestamp from the post, not when the badger was granted.

TRWTF.

Mikael_Svahnberg

This is why I do exactly like you, then facepalm and check the 'nice post' badger instead because there they are sorted as they "should" be.

PJH

@RaceProUK said:

But it's like I said; the timestamp on the badger is the timestamp from the post, not when the badger was granted.

@PJH, can you confirm?

SELECT p.user_id, p.id post_id, p.updated_at granted_at
FROM badge_posts p
WHERE p.like_count >= 10 AND
    p.post_number > 1 AND
    p.topic_id not in (1000) AND /* Just exclude the likes thread - other discountable threads can still get legitimate likes */
    (:backfill OR p.id IN (:post_ids) )

As a copy of the Nice Post badger, the timestamp is the modification time of the post at the time the 10th like is given:

    SELECT p.user_id, p.id post_id, p.updated_at granted_at
    FROM badge_posts p
    WHERE p.post_number > 1 AND p.like_count >= 10 AND
      (:backfill OR p.id IN (:post_ids) )

I suspect 'liking a post' does not actually modify it.

@aliceif said:

Which is new and not a good thing.

The SQL itself hasn't changed for ages.

aliceif

Maybe I never noticed that. I was sure that the ordering of badge posts made sense in some way.
Seriously, why would badges not be sorted in the order they were granted in?

PJH

@aliceif said:

Maybe I never noticed that. I was sure that the ordering of badge posts made sense in some way.

If you've been going off the behaviour of the Nice Post badges in conjunction with /t/1000, then you've probably been misled.

https://youtu.be/vKA4w2O61Xo

RaceProUK

@PJH said:

I suspect 'liking a post' does not actually modify it.

That would explain it.

Is there not a timestamp for the most recent like?

PJH

@RaceProUK said:

Is there not a timestamp for the most recent like?

In post_actions, yes. But that would involve getting the created_at field of the most recent post_action_type_id==2 that applies to that post, somewhat complicating the query.

Which is why I think it doesn't happen...

RaceProUK

And given how often those queries run, you want them to be snappier than an over-sensitive mousetrap; guess we'll just have to live with it

PJH

@RaceProUK said:

And given how often those queries run, you want them to be snappier than an over-sensitive mousetrap; guess we'll just have to live with it

Well there is another option:

SELECT p.user_id, p.id post_id, current_timestamp granted_at
    FROM badge_posts p
    WHERE p.post_number > 1 AND p.like_count >= 10 AND
      (:backfill OR p.id IN (:post_ids) )

RaceProUK

Y'know, if you want to, and have the time, there's no rush ;)

PJH

I can't change Nice Post.

RaceProUK

Oh… hmm… may raise this at meta.d then.

boomzilla

@tar said:

Did this behaviour change recently, as in the last 12 hours or so? Because that's how it's always worked every time until now...

No. I routinely have to scroll down on this badge. The easiest way to figure this stuff out is usually to go look at your profile and check the "Likes Received." The Mediochre post should stand out with all the likes (unless you're posting in the Likes thread, of course).

boomzilla

@tar said:

There's no way to filter badges awarded per-user, is there?

I recall some chatter on meta.d about this being a future possibility. Pretty sure it was @sam.

RaceProUK

@RaceProUK said:

Oh… hmm… may raise this at meta.d then.

https://meta.discourse.org/t/badge-timestamp-should-be-the-time-the-badge-was-granted/26576?u=raceprouk
Let's see how long before it gets CLOSED WONTFIX

sam

Yes we plan to add that.