Yes no enums and goto's

dumbphux

I love working with Yes No enums...then tie that in with goto's and life is good. Did I mention this is from a top 30 internet site. I guess bool's just wouldn't work.

switch(searchResultsAvailable)
{
 case SearchResultsAvailable.yes:
 title = "Featured Products";
 break;
 case SearchResultsAvailable.no:
 title = "Top Sellers";
 break;
 default:
 goto case SearchResultsAvailable.no;
}

snoofle

@dumbphux said:

I love working with Yes No enums...then tie that in with goto's and life is good. Did I mention this is from a top 30 internet site. I guess bool's just wouldn't work.

switch(searchResultsAvailable)
{
 case SearchResultsAvailable.yes:
 title = "Featured Products";
 break;
 case SearchResultsAvailable.no:
 title = "Top Sellers";
 break;
 default:
 goto case SearchResultsAvailable.no;
}

Hmmm, that worked well....

For when:

switch (theEnum) {
  case theEnum.yes: { ...; break; }
  case theEnum.no:
  case default: { 
       ...; 
       break; 
  }
}

... simply won't do!

Kyanar

@snoofle said:

@dumbphux said:
I love working with Yes No enums...then tie that in with goto's and life is good. Did I mention this is from a top 30 internet site. I guess bool's just wouldn't work.

switch(searchResultsAvailable)
{
 case SearchResultsAvailable.yes:
 title = "Featured Products";
 break;
 case SearchResultsAvailable.no:
 title = "Top Sellers";
 break;
 default:
 goto case SearchResultsAvailable.no;
}

Hmmm, that worked well....
For when:
switch (theEnum) {
 case theEnum.yes: { ...; break; }
 case theEnum.no:
 case default: { 
 ...; 
 break; 
 }
}
... simply won't do!

Assuming this is C#, that syntax would cause a compile error.

fennec

@Kyanar said:

Assuming this is C#, that syntax would cause a compile error.

Why? Is C# the real WTF here? :P

dumbphux

@fennec said:

@Kyanar said:
Assuming this is C#, that syntax would cause a compile error.

Why? Is C# the real WTF here? :P

switch (theEnum) {
case theEnum.yes: { ...; break; }
case theEnum.no:
case default: {
...;
break;
}
}

the brackets shouldn't be there. It should actually be:
switch (theEnum) {
case theEnum.yes: ...; break;
case theEnum.no:
case default:
       ...;
       break;
}
}

fourchan

I hate to state the obvious but...

if (searchResultsAvailable == SearchResultsAvailable.yes)
 title = "Featured Products";
else
 title = "Top Sellers";

... or just use the ternary operator.

The only reason I can see for that other code not working in C# is "case default" instead of just "default".

dumbphux

Doh, you are right...it is the case default that would blow it up.

aquanight

@Kyanar said:

@snoofle said:
@dumbphux said:
I love working with Yes No enums...then tie that in with goto's and life is good. Did I mention this is from a top 30 internet site. I guess bool's just wouldn't work.
switch(searchResultsAvailable)
{
 case SearchResultsAvailable.yes:
 title = "Featured Products";
 break;
 case SearchResultsAvailable.no:
 title = "Top Sellers";
 break;
 default:
 gotocase SearchResultsAvailable.no;
}

Hmmm, that worked well....
For when:
switch (theEnum) {
 case theEnum.yes: { ...; break; }
 case theEnum.no:
 case default: { 
 ...; 
 break; 
 }
}
... simply won't do!
Assuming this is C#, that syntax would cause a compile error.

Actually, C# should accept that IIRC. You can have case X: case Y: code. It only requires a jump if there's code in between.

I don't know if that's true with case X: default: - but that's a pointless construct anyway, when you can just say default: . And a switch with 1 case and a default should just be an if/else.

Benanov

@Kyanar said:

@snoofle said:
@dumbphux said:
I love working with Yes No enums...then tie that in with goto's and life is good. Did I mention this is from a top 30 internet site. I guess bool's just wouldn't work.

switch(searchResultsAvailable)
{
 case SearchResultsAvailable.yes:
 title = "Featured Products";
 break;
 case SearchResultsAvailable.no:
 title = "Top Sellers";
 break;
 default:
 goto case SearchResultsAvailable.no;
}

Hmmm, that worked well....
For when:
switch (theEnum) {
 case theEnum.yes: { ...; break; }
 case theEnum.no:
 case default: { 
 ...; 
 break; 
 }
}
... simply won't do!
Assuming this is C#, that syntax would cause a compile error.

switch (theEnum)
{

    case theEnum.yes: { stuff(); break;}
    case theEnum.no:
default: {    stuff(); break; }

}

is perfectly fine in C#.NET 1.1. Curly braces work just fine around blocks. No and Default can point to the same block. You just can't have any sort of fall-through.

Kyanar

@Benanov said:

switch (theEnum)
{
    case theEnum.yes: { stuff(); break;}
    case theEnum.no:
default: {    stuff(); break; }
}
is perfectly fine in C#.NET 1.1. Curly braces work just fine around blocks. No and Default can point to the same block. You just can't have any sort of fall-through.

Indeed. I was confusing it with another type of fall-through construct ("case something: case somethingelse:") which did NOT work in an earlier version of the framework. Trying it in .NET 2.0 (pleasantly) compiles as expected.