End Discourse

chubertdev

Not what you think it is.

go into a random topic
click the link icon on a random post
notice that the link text has focus
hit the End
notice how you go to the end of the thread, not the end of the textbox that has focus, thereby losing your place

ChaosTheEternal

Same issue with Home, which means they're not escaping those keyboard shortcuts in that input field, but all others are (any single letter ones as well as Ctrl+F).

PJH

I'm guessing this is a side effect of stopping Del deleting the contents of that box...

chubertdev

So when I have focus on a textbox, and I press the Del, it doesn't do exactly what I'd expect it to do?

ChaosTheEternal

Considering they're using "readonly" on that textbox, Del shouldn't have any effect with or without keyboard shortcuts.

PJH

Correct. They changed it from what you think it'd do to not doing anything.

PJH

@ChaosTheEternal said:

Considering they're using "readonly" on that textbox

If that's the only thing they did, then my supposition is probably incorrect.

darkmatter

@ChaosTheEternal said:

Considering they're using "readonly" on that textbox, Del shouldn't have any effect with or without keyboard shortcuts.

If you're not allowed to delete or edit the text in that INPUT box, why is it an input at all?

ChaosTheEternal

My thought would be, the keyboard shortcuts should work anywhere on the forums except when focus is in input[type=text] and textarea elements, with the possible exception of Ctrl+F.

Yes, I'm aware the input one would need to be expanded for the other text field types (password, email, etc.).

ChaosTheEternal

@darkmatter said:

delete or edit the text in that INPUT box

Ask the W3C, not me.

darkmatter

@ChaosTheEternal said:

Ask the W3C, not me.

No no - it makes sense in cases where you have real inputs, but sometimes they may need to be disabled/readonly for the form to work.

But this isn't a freaking form. It's a big mess of JS that probably even pulls a new json stream rather than reading the text from that box at all anyway, so there is zero value to it being an input box if it's set to readonly.

ChaosTheEternal

I assume it's an input box to help facilitate easy highlighting/copying of the link to the post, since text inputs handle overflow really well in general.

anonymous234

Does not happen in Firefox.

darkmatter

@ChaosTheEternal said:

I assume it's an input box to help facilitate easy highlighting/copying of the link to the post, since text inputs handle overflow really well in general.

good enough for me - now if only they fixed all the things that hack doesn't facilitate

hungrier

@ChaosTheEternal said:

to help facilitate easy highlighting/copying of the link to the post

If only there was some way to copy the url of a link using any browser.

Filed under: but that would require using actual links like the time stamp

ChaosTheEternal

@hungrier said:

like the time stamp

Too bad the timestamp being a link to share the post isn't very discoverable, and the "share a link to this post" button is, actually, a button.

Filed under: Also, have to develop it for the lowest common denominator

hungrier

And all this is true because the Discourse way of solving problems is to create additional problems that make the original problems seem insignificant.

chubertdev

"Ohhhh, you think you have a problem now..."

faoileag

Can't repro in Firefox 32.

chubertdev

Interesting.

(that anyone uses Firefox, not that you can't repro)

Zecc

I use Firefox because the benefit of switching does not make up for the cost.

ChaosTheEternal

No repro in IE10, likely works in IE11.

Looks to be a Chrome thing. Seems their attempt to set focus in the box doesn't work in Chrome (and possibly Safari too?), but does in IE and FF.

riking

It seems to me that while you can select the text in the box, you cannot actually place your cursor inside of it - and not having a cursor, I suppose, is what causes the keypress to bubble out of the input field and be handled.

ChaosTheEternal

Definitely is a Chrome thing regarding the cursor, but if the input field is supposed to be capturing the key events (and not bubbling it if caught), it still is caught in Chrome, even if it is readonly: