Can't seem to set tracking to always
-
I thought I'd set this yesterday, but when I entered my preferences again, it was back at "after 4 minutes". Maybe I didn't hit save? Oh well, I figured. I set it, clicked save:
Then I go to my profile page. Then I clicked back into "preferences."
Wait, what? I wanted always. I re-set it to "always", click Save. Go back to profile. Go back to "Preferences". It's on "never" again! WTF?
-
Looks like you have to do a shift-reload of the page to see the change in your preferences.
-
But how did it get to "never" in the frist place?! It was on "after 4 minutes". I changed it to "always". It displayed "never". WTF?
-
Ok, reproduced the behaviour. As for the reason... "never" is the first option of the dropdown, so I assume that when entering the preferences "page" from navigating within Discourse, the "selected" attribute of that dropdown is not set to the actual preference.
Edit: as I side-effect, I now have 109 unread topics??? WTF?
-
That's a feature...It's just designed to see if your paying attention j/k. I agree with @faoileag I think you got caught in a cache black hole.
I have my own discourse site and when this happens to me I get filled with dread because it equates to me having to re-install Discourse (which I am getting really good at...I don't even need to read the instruction (I have it memorized)).
Filed under: (nervous laugh) haha..suprise...I think.
-
I'm sure there's some rationalisation awaiting about how wrong you're all using DC.
-
I was able to reproduce this on a new blank Discourse site:
- Enter profile
- Change tracking state from the default (4 minutes) to "always"
- Click Save Changes
- Click on your username at the top of the page to go back to your profile.
- Notice the setting is now at "never", not "always"
But it actually is saving -- if you go back to the homepage, then enter your profile, you'll see the value is "always". Something about that particular path of navigation is not firing the loading of the preferences as @faoileag noted.
This also seems oddly specific to "Always", if I set it to "30 seconds", "1 minute", "2 minutes", "3 minutes" etc it works fine. So maybe some kind of zero / first position setting issue?
Can you check this tomorrow @eviltrout?
-
I just pushed a fix for this. The issue is that field uses an integer value 0 for "always", and a piece of code was treating that as falsey when pre-selecting the value in the combo box.
-
Ruby 0 is true, JavaScript 0 is false.
Fun times.
-
Sorry, you posted that in the wrong thread. The 'bad ideas' thread is
that way.
-
JavaScript is the bad idea one. In Ruby, only false and null are false.
-
That's funny, I thought 0 == false was typical in languages and that simply Ruby was being special.
-
Zero is a number like any other. This isn't C where there are no real data types.
-
FIX: Try to match a selected element in a combo box, even if it · discourse/discourse@689afbf
