Username autocomplete selects the wrong name

Arantor

<pre message="yeah, that's pretty bad" />

But this is THE FUTURE of message forums because @codinghorror says so.

Also, funny... I typed in @coding because I'm faster than the lookup is, pressed enter without looking at what I got (but I had gotten to @coding before pressing enter) and ended up with @Arantor which is definitely wrong since neither my name nor my display name have coding in them. Or even c for that matter.

chubertdev

didn't reload after you typed the @ symbol

sam

@Arantor said:

For example the ordering of the list in @

hmmm ... this is a first, what is wrong with it? We try to prioritize it so people on the same topic appear first.

Arantor

I don't know, how about the fact I typed @coding then enter and got myself as the result? The fact that we had a whole discussion about it today about how it doesn't make sense?

sam

Can you reproduce that?

Arantor

I just tried it just now in this topic. @coding and enter. First hit was for ben_lubar.

Second and third time I get Jeff come up. I suspect the first time I'm doing it too fast for the autocorrect to keep up so it might as well be random, but the second and third time it's caught up with me.

Fourth time: I was so quick off the draw that I had @coding then a newline where the cursor was at, then the menu came up with Jeff as the first time, and despite the fact I had written 'coding', I still got a bunch of stemmed results for 'code', e.g. CodeClown.

This seems interestingly inconsistent.

ChaosTheEternal

@Arantor said:

The fact that we had a whole discussion about it today about how it doesn't make sense?

LTFY

Filed under: [It goes on for a bit in there](#tag2) @sam [so you'll have to read through a bit of off topic for all of our commentary and confusion](#tag2)

darkmatter

3 cheers for @sam
minus 1 cheer for the @mention list auto-changing to @riking when I typed @sam and tried to hit enter to start a new line.

minus 1 cheer for whoever ruined

[spoiler]spoilerplates[/spoiler]

end

@Arantor said:

Second and third time I get Jeff come up. I suspect the first time I'm doing it too fast for the autocorrect to keep up so it might as well be random, but the second and third time it's caught up with me.

That was the immediate conclusion I reached reading the initial description. You're faster than a speeding JavaScript + HTML + DOM!

@sam about the only thing we could do re: the @username autocomplete is check and make sure we're returning the matches quickly, e.g. look for any low-hanging optimization fruit around that. But first load is always going to be slower, maybe we can pre-cache it better?

Matches

For the most part, I don't think we're complaining about the speed of the match. We're complaining that we type @name, get a match and when we hit tab or enter to select the match, it 'forgets' our selection that we just made, and picks a random name (to us)

Maybe more aggressively save position of the selector?

end

OK but I can't repro that?

sam

Yeah I totally need a repro here, what browser version OS?

Are you able to reproduce this with some sort of steps?

sam

Note, one change that did pop up here:

http://what.thedailywtf.com/t/how-does-the-username-matching-thingy-work/1397

We should always be prioritizing username matches over long name matches, we are not doing so now. But as to the incorrect selection, I am a bit stumped.

Matches

I get matches for people whose letters don't match even a single letter in my selection.

If I had to take a guess, it's typing speed plus how much your discourse stuff is doing. It happens on Chrome 35.1916.153m, and regularly happens when I'm quickly typing @na... And a name match pops, but I hit tab or enter and it goes from @na.. To @bob

I think it's not saving current search user position, and instead reverting to the first person on the list, or maybe first person on the search 'page' if you're bringing in results by blocks.

sam

Merry Christmas, I just fixed this:

Jul 5, 2014

FIX: autocomplete quirks · discourse/discourse@8298929

A platform for community discussion. Free, open, simple. - FIX: autocomplete quirks · discourse/discourse@8298929

@codinghorror FYI this was seriously bust, there was this as well:

Jul 4, 2014

FIX: username search logic was stemming and not ordering right · discourse/discourse@cf60bed

A platform for community discussion. Free, open, simple. - FIX: username search logic was stemming and not ordering right · discourse/discourse@cf60bed

Deployed here, @PJH feel free to close

end