Highlighting the incorrect topic in the topic list

HardwareGeek

Bug: Discourse highlights a topic in the "Latest" list for no reason.
Actual: Click on a topic in the "Latest" list. Use browser's back button to return to "Latest" page. Occasionally, randomly, the page will be scrolled to some random spot in the middle of the list, instead of the spot where I was when I clicked the link. (I don't know if this is a Discourse issue or a browser issue. Chrome 34, if anyone cares.) Random topic in the list will be highlighted with the fading gray "this is the last topic you clicked on" background.
Expected: Only the link I actually clicked should be highlighted, not some random link the browser randomly scrolled to.

sam

My repro for this is.

Scroll down the topic list until more topics load up.
Click on one of the newly loaded topics.

Discourse seems to be highlighting an incorrect topic (sometimes it highlights the correct one in conjunction with another)

dhromed

Are you guys using the word "topic" when you should be using "post"?

These words are not interchangeable, and it's causing confusion. In my head at least.

sam

@dhromed said:

Are you guys using the word "topic" when you should be using "post"?

Nope, talking about topics here, the issue is on this screen.

dhromed

Oh ok good.

You were also talking about highlighting, like the blue highlight that happens for the post where you left off.

HardwareGeek

@dhromed said:

You were also talking about highlighting, like the blue highlight that happens for the post where you left off.

Yes, if you read a topic then go back to the topic list, it briefly highlights the topic you just read.

dkf

Or at least that's what it is supposed to do. If it doesn't, that's this bug…

eviltrout

Are you guys talking about the topic that highlights to show you where the second page of topics was inserted? Because that's all I see when I try to reproduce this.

end

Yeah that might be the confusion. Note as you scroll down in the topic list, guys, we highlight the point of load, e.g this:

becomes this

The highlight is simply "here's where we started adding more topics"

HardwareGeek

@codinghorror said:

The highlight is simply "here's where we started adding more topics"

First, why? That seems to me to be rather pointless.

That said, that may indeed be what is happening. Read a topic, then hit Back to return to the topic list. Occasionally, the list does not display the topic you just read, but is scrolled to some arbitrary point further down. It may be the case that the topic highlighted is where Discourse had to load more topics to display the list at the point it's scrolled to.

So then the question is, "Why is the list arbitrarily scrolled?" rather than, "Why is that topic highlighted?" Still unexpected behavior, and still intermittent, with no good repro.

riking

Another question is, "Should the point of insertion even be highlighted?"

What about resuming lower down than page 2? That doesn't work either.

end

@riking said:

What about resuming lower down than page 2? That doesn't work either.

Yes, that's a regression. @eviltrout here is the repro:

Enter a category (or not, doesn't seem to matter, fails with /latest too)
Scroll down two "loading.."s
Enter a topic
Click the back button

Note that you don't get resumed at the position you were at in the topic list, like we used to. So we regressed..

sam

Also, point of insertion should not be highlighted on back button, that makes no sense.

eviltrout

The sequence of events for loading/filter needs a refactor to fix it up fully, but I have the basic bug fixed.

end