Representative diff, part 2
-
So I went out to eat lunch at Benji's (hoppel poppel is the best thing ever). When I came back, I noticed that mister Microsoft Word had committed again.
Here's the commit message:
And here's a snippet of the same fucking commit:
Thankfully no syntax errors this time.
-
So what? He fixed it.
Why are you making such a big deal about this? Github highlights each line that's changed, even if it's only a single character (that's how diff display tools work in general). When Git does cleanup and compresses old revisions it doesn't matter as it's gzipped away.
-
@dynedain said:
So what? He fixed it.
Why are you making such a big deal about this? Github highlights each line that's changed, even if it's only a single character (that's how diff display tools work in general). When Git does cleanup and compresses old revisions it doesn't matter as it's gzipped away.
Fixed what? He DELETED the section he was looking for. There was no NameFrontSyllableConsonant section readded in that commit. It just went bye bye until I re-added it manually.
-
So revert and tell him to fix his code. Easy peasy. Why bother with manually fixing his mistakes.
If he's so problematic, take away his commit privileges, tell him to fork (or at least branch) the project and issue merge requests so someone can peer-review everything he does.
-
-
And start adding unit tests and automated builds so that it's obvious when someone's commits break the build.
-
@dynedain said:
And start adding unit tests and automated builds so that it's obvious when someone's commits break the build.
What, quality control? You're anti-open-source!
-
@joe.edwards said:
Filed under: Next you'll be demanding we make it accessible to disabled users.
Oh boy.
-
@mikeTheLiar said:
@joe.edwards said:
Filed under: Next you'll be demanding we make it accessible to disabled users.
-
@Ben L. said:
@dynedain said:
Why is it so hard for you to actually SAY stuff like this in the original post? Nobody here can read minds. Even still, that's just failure, not worse than failure.So what? He fixed it.
Why are you making such a big deal about this? Github highlights each line that's changed, even if it's only a single character (that's how diff display tools work in general). When Git does cleanup and compresses old revisions it doesn't matter as it's gzipped away.
Fixed what? He DELETED the section he was looking for. There was no NameFrontSyllableConsonant section readded in that commit. It just went bye bye until I re-added it manually.
-
@joe.edwards said:
What, quality control? You're anti-open-source!
This gave me an early morning chortle.
(I also can't wait for Blakeyrat to turn up to give his opinion of Github)
-
@El_Heffe said:
@mikeTheLiar said:
@joe.edwards said:
Filed under: Next you'll be demanding we make it accessible to disabled users.
Oh boy.
I prefer your facepalming women.
-
@Sutherlands said:
@Ben L. said:
@dynedain said:
Why is it so hard for you to actually SAY stuff like this in the original post? Nobody here can read minds. Even still, that's just failure, not worse than failure.So what? He fixed it.
Why are you making such a big deal about this? Github highlights each line that's changed, even if it's only a single character (that's how diff display tools work in general). When Git does cleanup and compresses old revisions it doesn't matter as it's gzipped away.
Fixed what? He DELETED the section he was looking for. There was no NameFrontSyllableConsonant section readded in that commit. It just went bye bye until I re-added it manually.
Explaining the joke, ruins the joke.
-
@bode said:
@Sutherlands said:
Oh, you think that was a joke? Interesting sense of humor you have there.@Ben L. said:
@dynedain said:
Why is it so hard for you to actually SAY stuff like this in the original post? Nobody here can read minds. Even still, that's just failure, not worse than failure.So what? He fixed it.
Why are you making such a big deal about this? Github highlights each line that's changed, even if it's only a single character (that's how diff display tools work in general). When Git does cleanup and compresses old revisions it doesn't matter as it's gzipped away.
Fixed what? He DELETED the section he was looking for. There was no NameFrontSyllableConsonant section readded in that commit. It just went bye bye until I re-added it manually.
Explaining the joke, ruins the joke.
-
@Sutherlands said:
You don't have to be able to read minds, you just have to be able to read diffs. It clearly showed 1) a comment asking "where has X gone" and 2) a diff hunk showing that X had been deleted by that user in that commit.Why is it so hard for you to actually SAY stuff like this in the original post? Nobody here can read minds.
-
@DaveK said:
2) a diff hunk showing that X had been deleted by that user in that commit.
How am I supposed to know that FrontSyllableConsonant is the same as NameFrontSyllableConsonant?
-
@dhromed said:
Common sense was what did it for me. So ok, I guess it takes two things to get the post: the ability to read diffs, and a modicum of common sense. That's still not mind reading, though.@DaveK said:
2) a diff hunk showing that X had been deleted by that user in that commit.
How am I supposed to know that FrontSyllableConsonant is the same as NameFrontSyllableConsonant?
-
@DaveK said:
a modicum of common sense.
Nah.
The varnames could mean the same thing, sure, but there's no guarantee and given the context I wouldn't even call it probable that they're the same thing.
What I'm saying is that I think my common sense is more accurate than yours.
And now I'm going to reinstall my graphics driver because the goddamn thing turned off Aero Glass instead of making a screenshot.
-
@dhromed said:
The "context" you refer to is that of a post on TDWTF, which implies that there is something WTF-y about what has been posted, and that made it seem probable to me that they were indeed the same thing.@DaveK said:
a modicum of common sense.
Nah.
The varnames could mean the same thing, sure, but there's no guarantee and given the context I wouldn't even call it probable that they're the same thing.
@dhromed said:
What I'm saying is that I think my common sense is more accurate than yours.
That's a difficult claim to support given that your common sense failed to enable you to understand the post, while mine came up with an explanation that a) fitted all the facts, b) offered a coherent understanding of why the diff and commit comment posted were a WTF, and c) turned out to be actually in fact correct, as subsequently confirmed by the OP.@dhromed said:
And now I'm going to reinstall my graphics driver because the goddamn thing turned off Aero Glass instead of making a screenshot.
Your admission to the use of Aero Glass undermines your claim to any kind of common sense at all! ;-p
-
@DaveK said:
@dhromed said:
What I'm saying is that I think my common sense is more accurate than yours.
That's a difficult claim to support given that your common sense failed to enable you to understand the post, while mine came up with an explanation that a) fitted all the facts, b) offered a coherent understanding of why the diff and commit comment posted were a WTF, and c) turned out to be actually in fact correct, as subsequently confirmed by the OP.What you're saying is that you took a guess, while I prudently rejected that guess given the fact that indeed we are on TDWTF, where nothing is certain and any snippet of code can turn out to be a potent caustic, and assuming *VariableNameX == *PrefixVariableNameX might easily have disintegrated my monitor.
So I move that you were right for the wrong reasons!
@DaveK said:
@dhromed said:
And now I'm going to reinstall my graphics driver because the goddamn thing turned off Aero Glass instead of making a screenshot.
Your admission to the use of Aero Glass undermines your claim to any kind of common sense at all! ;-O no, I am vanquished!
-
@dhromed said:
@DaveK said:
This person uses Microsoft Word as a code editor. I think we can safely assume they got the name wrong.@dhromed said:
What I'm saying is that I think my common sense is more accurate than yours.
That's a difficult claim to support given that your common sense failed to enable you to understand the post, while mine came up with an explanation that a) fitted all the facts, b) offered a coherent understanding of why the diff and commit comment posted were a WTF, and c) turned out to be actually in fact correct, as subsequently confirmed by the OP.
What you're saying is that you took a guess, while I prudently rejected that guess given the fact that indeed we are on TDWTF, where nothing is certain and any snippet of code can turn out to be a potent caustic, and assuming *VariableNameX == *PrefixVariableNameX might easily have disintegrated my monitor.So I move that you were right for the wrong reasons!
-
@Ben L. said:
@dhromed said:
Or we can safely assume that they completely destroyed the system and had to rebuild it from scratch because they didn't know how to just get it from source control again, and didn't want to redo their work.@DaveK said:
This person uses Microsoft Word as a code editor. I think we can safely assume they got the name wrong.@dhromed said:
What I'm saying is that I think my common sense is more accurate than yours.
That's a difficult claim to support given that your common sense failed to enable you to understand the post, while mine came up with an explanation that a) fitted all the facts, b) offered a coherent understanding of why the diff and commit comment posted were a WTF, and c) turned out to be actually in fact correct, as subsequently confirmed by the OP.
What you're saying is that you took a guess, while I prudently rejected that guess given the fact that indeed we are on TDWTF, where nothing is certain and any snippet of code can turn out to be a potent caustic, and assuming *VariableNameX == *PrefixVariableNameX might easily have disintegrated my monitor.So I move that you were right for the wrong reasons!
Yes, that's what I'm going with. That's TRWTF.
-
@Sutherlands said:
Or we can safely assume that they completely destroyed the system and had to rebuild it from scratch because they didn't know how to just get it from source control again, and didn't want to redo their work.
I hear he's in the process of writing up an epic rant about git...
-
@Sutherlands said:
because they didn't know how to just get it from source control again
What do you mean "again"? They use the web editor. That's why they only change one file per commit.
-
@Ben L. said:
@Sutherlands said:
It seems like you're serious. If so, go back and look at the post you replied to and see if it was serious.because they didn't know how to just get it from source control again
What do you mean "again"? They use the web editor. That's why they only change one file per commit.
-
@boomzilla said:
@Sutherlands said:
Or we can safely assume that they completely destroyed the system and had to rebuild it from scratch because they didn't know how to just get it from source control again, and didn't want to redo their work.
I hear he's in the process of writing up an epic rant about git...
Whoa, Rombomm is blakeyrat? That explains... very few things.
-
@dhromed said:
No, I didn't take a guess, and you didn't reject one. I made an inference based on the content of the post and one background assumption, which is that the OP was not posting incoherent nonsense but instead had a meaningful WTF to communicate to us. You likewise made an inference, based on the same post content and the diametrically opposite assumption. We're not programming a computer here, we're communicating in English, so we don't have to blindly look for an exact match between two strings of text as if we were doing a symbol table lookup. I therefore move that I was right for the right reasons.@DaveK said:
@dhromed said:
What I'm saying is that I think my common sense is more accurate than yours.
That's a difficult claim to support given that your common sense failed to enable you to understand the post, while mine came up with an explanation that a) fitted all the facts, b) offered a coherent understanding of why the diff and commit comment posted were a WTF, and c) turned out to be actually in fact correct, as subsequently confirmed by the OP.What you're saying is that you took a guess, while I prudently rejected that guess given the fact that indeed we are on TDWTF, where nothing is certain and any snippet of code can turn out to be a potent caustic, and assuming *VariableNameX == *PrefixVariableNameX might easily have disintegrated my monitor.
So I move that you were right for the wrong reasons!
-
@DaveK said:
We're not programming a computer here, we're communicating in English, so we don't have to blindly look for an exact match between two strings of text as if we were doing a symbol table lookup.
It's too bad I agree with you otherwise I would have posted a clever joke about case-sensitive comparisons. I'm bittersweet at the moment*.
* that's what she said
-
@Ronald said:
* that's what she said
There needs to be a Unicode code point permanently reserved for this saying, that doesn't need to be defined in a footnote.
Edit: Fucking hell why does my tag change to 👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳👳 when I type 💩 once?
-
@Ronald said:
@DaveK said:
Hell, post it anyway :)We're not programming a computer here, we're communicating in English, so we don't have to blindly look for an exact match between two strings of text as if we were doing a symbol table lookup.
It's too bad I agree with you otherwise I would have posted a clever joke about case-sensitive comparisons. I'm bittersweet at the moment*.
* that's what she said
