Wrong notification text for threads with a comma in the title
-
Noticed in 2 threads so far:
Original titles are
What gives, Nginx?
andEU 1, Google 0
.
Filed under: Yes, I stalk
-
-
Wasn't this reported already?
-
Also, no repro, but I can't post the screenshot proving it works for me, because it's all Lounge threads
-
@onyx
We need @ben_lubar to update the pester code to dynamically overlay the Lounge Construction Tape instead of pestering you when you try to post a screenshot of lounge or mafia threds.
-
@izzion it's a bad image, too, I was too lazy to do it properly :P
-
@raceprouk said in Wrong notification text for threads with a comma in the title:
Also, no repro, but I can't post the screenshot proving it works for me, because it's all Lounge threads
I got it on your test thread, again
-
@onyx said in Wrong notification text for threads with a comma in the title:
@raceprouk said in Wrong notification text for threads with a comma in the title:
Also, no repro, but I can't post the screenshot proving it works for me, because it's all Lounge threads
I got it on your test thread, again
I didn't:
Fun note: even though I've blanked out the Lounge stuff, it still triggered the warning
-
@raceprouk The fancy pattern goes all the way to the toggles, maybe even past them.
-
@raceprouk Might be on new threads only, then?
-
@onyx said in Wrong notification text for threads with a comma in the title:
it's a bad image
has it been naughty?
-
@luhmann said in Wrong notification text for threads with a comma in the title:
@onyx said in Wrong notification text for threads with a comma in the title:
it's a bad image
has it been naughty?
Indeed. Sadly, there is no
SPANK
tool in Inkscape. Need to switch to an EFL based editor I guess...
-
-
@raceprouk said in Wrong notification text for threads with a comma in the title:
now I'm following him
creep!
-
BINGO!
Thanks @Jaloopa! :D
-
@raceprouk said in Wrong notification text for threads with a comma in the title:
now I'm following him
*hedgehog snuffling intensifies*
-
Could have something to do with this:
bodyShort: '[[notifications:user_posted_topic, ' + postData.user.username + ', ' + title + ']]',
from /src/user/notifications.js
Looks like a comma in the text would f that up pretty good.
-
@hungrier said in Wrong notification text for threads with a comma in the title:
Looks like a comma in the text would f that up pretty good
More evidence that treating strings and code the same is bad? Say it ain't so!
-
@jaloopa said in Wrong notification text for threads with a comma in the title:
@hungrier said in Wrong notification text for threads with a comma in the title:
Looks like a comma in the text would f that up pretty good
More evidence that treating strings and code the same is bad? Say it ain't so!
It aren't so!
-
Possible XSS?