Bookmarks are b0rked
-
@ben_lubar Not sure what you did, but one of those updates you applied today has broken bookmark tracking. Every time I click on a topic in Unread, I get sent back to the point I was at several hours ago, even if I've already read further than that.
-
I suppose it's better than getting sent to a post from a few minutes ago after having slept through over a dozen posts before it with my computer turned off. Now I can scroll down instead of up to find where I was last at!
-
@masonwheeler I had that happen on occasion before the update, but never enough for me to bother reporting it.
-
It seems inconsistent. I recall seeing something like that, but only sometimes.
-
Now it's happening pretty consistently.
-
It was 'fixed' in 2016:
I don't remember it ever being fixed, though.
Notifications.merge results in "new posts made to topic" notifications going to end of topic · Issue #4469 · NodeBB/NodeBB
Ideally, the first unread post should be the target of the merged notification. Ref: apxltd/what-bugs#54
-
@LB_ that's for notifications, not the "unread" bookmark. If you're watching a topic, the notification that says "new posts" should take you to the first unread post.
It was screwed up because each new post would generate a new notification, and the new notification would merge with the older notification from the same topic... the merge resulted in a single notification that pointed to the newer post, rather than the older post, so the "new posts" notification always took you to the last unread post instead of the first unread post.
-
@anotherusername oh, well it's still broken so I didn't realize it was a separate issue.
-
@LB_ are you referring to when read posts are merged into an existing thread, and they're no longer "read"?
That one's tricky, because it's possible that there may be unread posts in the thread that would come before (some or all of) the read ones being merged into it. If the bookmark gets moved to the end of the read moved posts, it might be skipped past unread posts already in the thread.
-
@anotherusername I'm referring to clicking on a "user and X others have replied to Thread name" notification taking me to some random post in the middle of posts I haven't read. It's happened before where I'll have been sleeping all night with my computer off and the next morning a thread with hundreds of unread posts will have a notification that takes me to the last post in the thread, and I have to scroll up to find where I left off based on what I remember reading or what I upvoted.
-
@masonwheeler said in Bookmarks are b0rked:
Now it's happening pretty consistently.
Ugh...I just got taken to the top of the Postgres free tools thread. The link in the list is pointing at post 1, so it looks like some bookmarks aren't persisting. Which is weird, because I just posted there a few minutes ago and when I navigated there it definitely took me to the middle of the thread where I'd left off reading.
-
@boomzilla Yup. It doesn't happen on every thread, but it's happening enough to be real annoying.
-
It seems to be related to:
https://what.thedailywtf.com/topic/23151/mobile-missing-navigation-bar-at-bottom
Basically, if the nav thing isn't there, it won't update your bookmark. I didn't see any error in the js console (or the server logs), but there's something happening that prevents normal stuff from happening.
-
@boomzilla Maybe, but that's not the whole of it. It's happening to me on the desktop version, with the nav widget where it's always been.
-
@masonwheeler Yes, that was mentioned over there, too. And it was on desktop where I confirmed the correlation.
