Code doesn't like second bounce, please help?

Steeldragon

Imports System.Drawing.Drawing2D

Imports System.Math

Imports System.IO

Imports System.Uri

Imports System.Threading

Public Class Form1

Private ht0 As Decimal

Private time As Decimal

Private cht As Decimal

Private v0 As Decimal

Private v As Decimal

Private x As Integer = 10

Private t As Decimal = 0

Private fht As Integer

Private fw As Integer

Private mindrop As Integer

Private maxdrop As Integer

Private curdrop As Integer

Private ball As Bitmap = New Bitmap("ball.bmp")

Private shadow As Bitmap = New Bitmap("shadow.bmp")

Private ground As Bitmap = New Bitmap("ground.bmp")

Private background As Bitmap = New Bitmap("background.bmp")

Private rball As Rectangle

Private rshadow As Rectangle

Private rground As Rectangle

Private canvas As Graphics

Private bht As Decimal

Private gen As New Random

Private count As Integer = 0

Private done = False 'True

Private bounce As Decimal

Private curht2 As Decimal

Private vrand As Integer

Private terfont As Font = New Font("symbol", 12, FontStyle.Regular, GraphicsUnit.Pixel, 0)Private Sub runbtn_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles runbtn.Click

bounce = 0

curht2 = 0

curht.Text = curht2

bounceht.Text = curht2

mindrop = mindrop_txt.Text

maxdrop = maxdrop_txt.Text

t = 0

v = 0

ball.MakeTransparent(Color.Blue)

shadow.MakeTransparent(Color.Blue)

canvas = PicAnim.CreateGraphics

fht = PicAnim.Height

fw = PicAnim.Width

bht = ball.Height

ht0 = 0

cht = ht0

count = 0

If maxdrop > 375 Then

maxdrop = 375

End If

If mindrop > 370 Then

mindrop = 370

End If

curdrop = gen.Next(mindrop, maxdrop)

v0 = gen.Next(gen.Next(2000))

If v0 > 200 Then

v0 = v0 / 10

End If

rground = New Rectangle(0, curdrop, fw, fht - curdrop)

rshadow = New Rectangle(x, curdrop, shadow.Width, shadow.Height)

rball = New Rectangle(x, cht, ball.Width, ball.Height)

canvas.DrawImage(background, 0, 0)

canvas.DrawImage(ground, rground)

canvas.DrawImage(shadow, rshadow)

canvas.DrawImage(ball, rball)

Do

Thread.Sleep(10)

ter1()

Thread.Sleep(10)

If (cht + bht) > curdrop Then

count = 1

Else

rball = New Rectangle(x, cht, ball.Width, bht)

'Thread.Sleep(10)

canvas.DrawImage(background, 0, 0)

'Thread.Sleep(10)

canvas.DrawImage(ground, rground)

'Thread.Sleep(10)

canvas.DrawImage(shadow, rshadow)

'Thread.Sleep(10)

canvas.DrawImage(ball, rball)

Thread.Sleep(40)

End If

Loop Until count > 0

' Do

'vrand = gen.Next(10)

' Thread.Sleep(20)

'v0 = (curdrop - (cht + bht) - vrand) '* -1

'Thread.Sleep(5)

't = 0

'Thread.Sleep(5)

'bounceht.Text = 0

'ht0 = curdrop '* -1

'cht = 0

'Thread.Sleep(5)

canvas.DrawString("Sorry this is just a demo, rest of code there but won't work", terfont, Brushes.Silver, 10, 380)

'Do

'ter2()

'Thread.Sleep(5)

'Thread.Sleep(20)

'If (cht + bht) > curdrop Then

'count = 1

'Else

'rball = New Rectangle(x, cht, ball.Width, bht)

'Thread.Sleep(5)

'canvas.DrawImage(background, 0, 0)

'Thread.Sleep(5)

'canvas.DrawImage(ground, rground)

'Thread.Sleep(5)

'canvas.DrawImage(shadow, rshadow)

'Thread.Sleep(5)

'canvas.DrawImage(ball, rball)

'Thread.Sleep(5)

'End If

'Loop Until (cht + bht) > curdrop

'Thread.Sleep(5)

'Loop Until done = True

End Sub

Function ter1()

cht = v - (v0 * t) - ht0

Thread.Sleep(10)

t = t + 0.1

Thread.Sleep(10)

v = 16 * (t ^ 2)

Thread.Sleep(10)

End Function

Function ter2()

cht = v - ((v0 + ht0) * t) + ht0

Thread.Sleep(5)

t = t + 0.1

Thread.Sleep(5)

v = 16 * t ^ 2

Thread.Sleep(5)

curht2 = (ht0 - cht)

Thread.Sleep(5)

'curht.Text = curht2

Thread.Sleep(5)

If curht2 > bounce Then

bounce = curht2

Thread.Sleep(5)

'bounceht.Text = bounce

Else

Thread.Sleep(5)

End If

End Function

Private Sub stopbtn_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles stopbtn.Click

If done = False Then

done = True

Else

Close()

End If

End Sub

End Class

So that's where all the missing linebreaks went!

PSWorx

Code doesn't like second bounce, please help?

Easy. Your duractance is not optimal. Just cross-triage the logarithmic carburetor on line 15.

Steeldragon

Re: Code doesn't like second bounce, please help? Code has now been indented.

@Steeldragon said:

Imports System.Drawing.Drawing2D
 
Imports System.Math
 
Imports System.IO
 
Imports System.Uri
 
Imports System.Threading
Public Class Form1 
 Private ht0 As Decimal
 
 Private time As Decimal
 
 Private cht As Decimal
 
 Private v0 As Decimal
 
 Private v As Decimal
 Private x As Integer = 10 
 Private t As Decimal = 0

 Private fht As Integer
 
 Private fw As Integer
 
 Private mindrop As Integer
 
 Private maxdrop As Integer
 
 Private curdrop As Integer
 Private ball As Bitmap = New Bitmap("ball.bmp") 
 Private shadow As Bitmap = New Bitmap("shadow.bmp")
 Private ground As Bitmap = New Bitmap("ground.bmp") 
 Private background As Bitmap = New Bitmap("background.bmp")
 Private rball As Rectangle 
 Private rshadow As Rectangle
 Private rground As Rectangle 
 Private canvas As Graphics

 Private bht As Decimal
 Private gen As New Random 
 Private count As Integer = 0

 Private done = False 'True
 
 Private bounce As Decimal
 
 Private curht2 As Decimal
 
 Private vrand As Integer
 Private terfont As Font = New Font("symbol", 12, FontStyle.Regular, GraphicsUnit.Pixel, 0)
 Private Sub runbtn_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles runbtn.Click 
 bounce = 0

 curht2 = 0

 curht.Text = curht2

 bounceht.Text = curht2

 mindrop = mindrop_txt.Text

 maxdrop = maxdrop_txt.Text

 t = 0

 v = 0

 ball.MakeTransparent(Color.Blue)

 shadow.MakeTransparent(Color.Blue)

 canvas = PicAnim.CreateGraphics

 fht = PicAnim.Height

 fw = PicAnim.Width

 bht = ball.Height

 ht0 = 0

 cht = ht0

 count = 0

 If maxdrop > 375 Then
 
 maxdrop = 375

 End If
 
 If mindrop > 370 Then
 
 mindrop = 370

 End If
 
 curdrop = gen.Next(mindrop, maxdrop)

 v0 = gen.Next(gen.Next(2000))

 If v0 > 200 Then
 
 v0 = v0 / 10

 End If
 rground = New Rectangle(0, curdrop, fw, fht - curdrop) 
 rshadow = New Rectangle(x, curdrop, shadow.Width, shadow.Height)
 rball = New Rectangle(x, cht, ball.Width, ball.Height) 
 canvas.DrawImage(background, 0, 0)

 canvas.DrawImage(ground, rground)

 canvas.DrawImage(shadow, rshadow)

 canvas.DrawImage(ball, rball)

 Do
 
 Thread.Sleep(10)

 ter1()

 Thread.Sleep(10)

 If (cht + bht) > curdrop Then
 
 count = 1

 Else
 rball = New Rectangle(x, cht, ball.Width, bht) 
 'Thread.Sleep(10)
 
 canvas.DrawImage(background, 0, 0)

 'Thread.Sleep(10)
 
 canvas.DrawImage(ground, rground)

 'Thread.Sleep(10)
 
 canvas.DrawImage(shadow, rshadow)

 'Thread.Sleep(10)
 
 canvas.DrawImage(ball, rball)

 Thread.Sleep(40)

 End If
 Loop Until count > 0 
 ' Do
 
 'vrand = gen.Next(10)
 
 ' Thread.Sleep(20)
 
 'v0 = (curdrop - (cht + bht) - vrand) '* -1
 
 'Thread.Sleep(5)
 
 't = 0
 
 'Thread.Sleep(5)
 
 'bounceht.Text = 0
 
 'ht0 = curdrop '* -1
 
 'cht = 0
 
 'Thread.Sleep(5)
 canvas.DrawString("Sorry this is just a demo, rest of code there but won't work", terfont, Brushes.Silver, 10, 380) 
 'Do
 
 'ter2()
 
 'Thread.Sleep(5)
 
 'Thread.Sleep(20)
 
 'If (cht + bht) > curdrop Then
 
 'count = 1
 
 'Else
 
 'rball = New Rectangle(x, cht, ball.Width, bht)
 
 'Thread.Sleep(5)
 
 'canvas.DrawImage(background, 0, 0)
 
 'Thread.Sleep(5)
 
 'canvas.DrawImage(ground, rground)
 
 'Thread.Sleep(5)
 
 'canvas.DrawImage(shadow, rshadow)
 
 'Thread.Sleep(5)
 
 'canvas.DrawImage(ball, rball)
 
 'Thread.Sleep(5)
 
 'End If
 
 'Loop Until (cht + bht) > curdrop
 
 'Thread.Sleep(5)
 
 'Loop Until done = True
 
 End Sub
 Function ter1() 
 cht = v - (v0 * t) - ht0

 Thread.Sleep(10)

 t = t + 0.1

 Thread.Sleep(10)

 v = 16 * (t ^ 2)

 Thread.Sleep(10)

 

 End Function
 Function ter2() 
 cht = v - ((v0 + ht0) * t) + ht0

 Thread.Sleep(5)

 t = t + 0.1

 Thread.Sleep(5)

 v = 16 * t ^ 2

 Thread.Sleep(5)

 curht2 = (ht0 - cht)

 Thread.Sleep(5)

 'curht.Text = curht2
 
 Thread.Sleep(5)

 If curht2 > bounce Then
 
 bounce = curht2

 Thread.Sleep(5)

 'bounceht.Text = bounce
 
 Else
 
 Thread.Sleep(5)

 End If
 
 End Function
 Private Sub stopbtn_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles stopbtn.Click 
 If done = False Then
 
 done = True
 
 Else
 
 Close()

 End If
 End Sub 
End Class

sorry about earlier, but i posted in less than a minute. This code is supposed to show the law of falling objects, and said object is supposed to bounce afterwards. v0 is the initial upwards velocity, mindrop & maxdrop are masked textboxes, and ht0 is the initial height. The code is VB EE 08 and always freezes in the nested do loop. any help would be appreciated. Take out the apostrophies on the commented lines to run it. Ball is just a ball image, and for the others, well, you can use anything.

Welbog

@Steeldragon said:

[lots of terrible, terrible VB]@Steeldragon said:
sorry about earlier, but i posted in less than a minute. This code is supposed to show the law of falling objects, and said object is supposed to bounce afterwards. v0 is the initial upwards velocity, mindrop & maxdrop are masked textboxes, and ht0 is the initial height. The code is VB EE 08 and always freezes in the nested do loop. any help would be appreciated. Take out the apostrophies on the commented lines to run it. Ball is just a ball image, and for the others, well, you can use anything.

Alright, some advice: use a service like Pastebin instead of relying on our terrible forum software to post code. It's OK to post a snippet directly on the forums when it's small, but in this case it's just too much. You'll find Pastebin to be very useful for this kind of thing (because that's what it's for).

The other thing is explain the code you're posting more clearly. You've got no actual code comments in this mess, and we only have a small description that doesn't hope to explain the dozens of global variables you've thoughtfully named things like "cht" and "v", along with functions named "ter1" and "ter2". If your variables and functions are named reasonably, you generally don't have to document your code with comments. In your case, though, you really need to provide a better description of this code.

Don't give us a mess of code, then tell us to uncomment some of it. Just give us the code you want us to look at, with a description sufficient so that we don't have to wade through variable soup to figure out what the heck you're trying to do.

CDarklock

Only a cursory examination, but it appears you may have the test wrong in the nested loop. When you drop the ball, and it is moving down, you test "(cht + bht) > curdrop". When the ball bounces and is moving up, you continue to use the same test. Since (cht + bht) are now going down instead of up, the loop will never terminate.

Steeldragon

@CDarklock said:

Only a cursory examination, but it appears you may have the test wrong in the nested loop. When you drop the ball, and it is moving down, you test "(cht + bht) > curdrop". When the ball bounces and is moving up, you continue to use the same test. Since (cht + bht) are now going down instead of up, the loop will never terminate.

thx, but it'sa bit too late. assessment is over. Will keep in mind though.

ekolis

"Assessment is over"? Ugh, this guy was trying to get help on an EXAM? I see... so testing "(cht + bht) > curdrop" means "if amount of cheating 'cht' plus the bone-headedness of the teacher 'bht' is greater than the threshold necessary for forcing withdrawal from the course 'curdrop'"... wait, that doesn't make sense, the teacher's boneheadedness should be on the other side of the equation, canceling out the cheating! Hmm, our educational system truly is flawed...

Steeldragon

@ekolis said:

"Assessment is over"? Ugh, this guy was trying to get help on an EXAM? I see... so testing "(cht + bht) > curdrop" means "if amount of cheating 'cht' plus the bone-headedness of the teacher 'bht' is greater than the threshold necessary for forcing withdrawal from the course 'curdrop'"... wait, that doesn't make sense, the teacher's boneheadedness should be on the other side of the equation, canceling out the cheating! Hmm, our educational system truly is flawed...

assessment=in class assignment that's actually graded. Now it's time for the quarter-long assessment.

cht=current height

bht=size of the ball along the Y axis

curdrop= how far the ball has to fall.