Said in post/null
-
Repro:
- Go to the first post in a thread.
- Highlight a part of the post.
- Click the large topic-global "reply" button under the post.
Expected: either a proper quote attribution, or no quote attribution at all, or no quote.
Actual:
-
And for some reason, it's not the case in this topic. Maybe because it only has one post?
-
-
-
@Maciejasjmj said in Said in post/null:
And for some reason, it's not the case in this topic. Maybe because it only has one post?
Yeah, we've discussed this elsewhere sometime last month. Basically, this bug only happens with the top-of-topic-controls (ToTC) and not with the end-of-topic-controls (EoTC). When the OP is the only post in the thread, then the ToTC are hidden in favor of the EoTC.
-
Hmm... The link format is a result of my most recent PR, and it looks like it's exposed a
in the ToTC controls.If I remember, I'll have a look tonight, see if I can find a quick (and correct) fix.
-
@RaceProUK So, I forgot to look at this yesterday
. But today, I have looked at it, and I believe I've found the issue.The fix is in two parts:
https://github.com/RaceProUK/NodeBB/commit/5afd5731dfe9c639304454753b361c7e98ce5eaa
https://github.com/RaceProUK/nodebb-plugin-composer-default/commit/e3a4c568216df6eb63fb235a43484c19a4d22831If people could have a look and check I've not bin an dum before I PR these mofos, I'd be grateful
FAO: @ben_lubar if he wants to do a trial run
Edit; The first commit is the one that actually fixes the bug @Maciejasjmj found; the second is something that should have been done ages ago, tbh.
-
Fix issue with top-of-topic reply button not passing post ID by RaceProUK · Pull Request #5450 · NodeBB/NodeBB
When using the top-of-topic reply button with text highlit in the original post, the post ID is not passed correctly. Until now 🙂
Harden post quoting logic by RaceProUK · Pull Request #84 · NodeBB/nodebb-plugin-composer-default
Correctly handle situations where the post ID is not passed, falling back to an older behaviour that uses the topic slug and ID, and the post index.
-
@RaceProUK psst... you forgot tests.
-
@Yamikuronue I know, but the main project doesn't have client-side code tests, and the composer project has no test framework at all
