:mag: The One Where the Hedgehog Wears a Deerstalker :mag_right: :fa_bell_o:
-
Since the most recent forum update (as of posting), I've noticed my notifications count doesn't always update properly, which is did before the update. Is anyone else seeing this?
Note I'm talking about ο’, not ο, the count for which has never worked right for me.
-
@RaceProUK
I had some possible jankiness this morning with a notification, the count updated after I pulled down the notifications menu to double check. But I didn't try to build any sort of replication case, and I was in a pre-caffeinated state, so I may not have seen what I thunk I saw.
-
@izzion I can repro fairly easily: I just leave the browser tab on the home page, and come back a while later. I did that just now, and had three notifications, but no counter. The counter appeared when I followed a notification though.
Next time, I'll see if the browser console has anything on it.
-
Yep, deffo an issue. And the console is blankety-blank, so there's no help there.
-
@RaceProUK said in The One Where the Hedgehog Wears a Deerstalker ο’:
Is anyone else seeing this?
WOMM
-
All the "live" features seem to be broken for me. No streamed-in posts, updated topics, notification counter or favicon overlay updates.
-
@hungrier said in The One Where the Hedgehog Wears a Deerstalker ο’:
All the "live" features seem to be broken for me. No streamed-in posts, updated topics, notification counter or favicon overlay updates.
That's new? I assumed this was a known bug. I have been dealing with it for a while now.
-
I get the feeling it's a socket issue.
/me orders @ben_lubar one of these:
-
@Polygeekery I think it was all working for me yesterday.
-
@RaceProUK said in The One Where the Hedgehog Wears a Deerstalker ο’:
I get the feeling it's a socket issue.
/me orders @ben_lubar one of these:
It won't fit our outlets. That could make the problem worse.
Plus...What if he uses it and electrocutes himself and then blows up a gas station?
-
@Onyx said in The One Where the Hedgehog Wears a Deerstalker ο’:
WOMM
I take that back, seems like I have to enter a topic or something for the notifications to show up as well, I just didn't notice it so far it seems...
-
@Polygeekery said in The One Where the Hedgehog Wears a Deerstalker ο’:
Plus...What if he uses it and electrocutes himself and then blows up a gas station?
Then his days of shooting aliens will be over.
-
@hungrier said in The One Where the Hedgehog Wears a Deerstalker ο’:
All the "live" features seem to be broken for me. No streamed-in posts, updated topics, notification counter or favicon overlay updates.
Same here, for the most part. In addition, not sure if it's related, but I also seem to be getting either a significant delay on notifications for watched posts, or the notifications never trigger so I never get them...
-
I wonder if this issue is also related to the current status of yamibot not responding to pings in the PBP RPGs forum.
@Yamikuronue you said that notifications were coming through, do you have a simple way to tell if the format has changed?
https://what.thedailywtf.com/post/1092033
Separately, I just observed the problem again, once I clicked into a thread my notifications came through.
-
@izzion said in The One Where the Hedgehog Wears a Deerstalker ο’:
I wonder if this issue is also related to the current status of yamibot not responding to pings in the PBP RPGs forum.
If so, that's gonna make the next Mafia game rather interesting.
-
@izzion @accalia is on the task. Notifications are reaching the web client for yamibot but not the sockbot client.
-
@Yamikuronue said in The One Where the Hedgehog Wears a Deerstalker ο’:
@izzion @accalia is on the task. Notifications are reaching the web client for yamibot but not the sockbot client.
currently at work, but will investigate at lunch break. with luck is simple fix....
-
@accalia It's probably irrevelant info, but I've noticed CHrome's trying to connect via websockets, and gets a
101 Switching Protocols
response. I also see some pollings, and this looks odd to me: .Then again, all that could be a vermillion clupea harengus.
-
I think I can define the behavior I'm seeing a little more clearly:
- If I trigger a page load (navigate to a new topic, click the logo to navigate to the home page, etc), my notifications will show up (number pending, bell darkens, change of the favicon)
- If I trigger the notifications window by clicking on the bell, my notifications will show up
- If I passively sit around not interacting with the forum, I do not receive notifications updates.
So it seems that the issue with the websockets connection highlighted by RPUK is highly related to the symptoms being observed.
-
I'm getting no notifications for chat notices
-
@Yamikuronue said in The One Where the Hedgehog Wears a Deerstalker ο’:
I'm getting no notifications for chat notices
these seem to have disappeared with the latest update, yes.
-
@accalia Which sucks for sekret reasons
-
@Yamikuronue said in The One Where the Hedgehog Wears a Deerstalker ο’:
@accalia Which sucks for sekret reasons
oh. now that is interesting........ notifications appear to no longer be broadcast in the same way they were before....
having devtools open and looking at the ws frames as they pass i get a broadcast message of:
42["event:notifications.updateCount",1]
but no broadcast for
event:new_notification
it's only when i click on the notification bell that i emit a ws frame of:
4250["notifications.get",null]
which gets a response of:
4350[null,{"read":[{"bodyShort":"[[notifications:user_posted_to, masonwheeler, The Impossible Mission: Group B Game Thread]]","bodyLong":"Text of the post", ... , "readClass":"unread"}]}]
that's bad for sockbot. we relied on those event emits, and there is no readily available replacement for them.
-
@accalia Can we send a get in response to every updateCount event? We never "read" them, after all. But we might need a document store to dump them in to see if we've seen the message already, like how the Slack driver does.
-
@Yamikuronue said in The One Where the Hedgehog Wears a Deerstalker ο’:
@accalia Can we send a get in response to every updateCount event? We never "read" them, after all. But we might need a document store to dump them in to see if we've seen the message already, like how the Slack driver does.
if this is the new way nodebb does things, yeah that's how we'll have to do things, it's not a direct replacement and will take time to code.
we gotta find out if this is a bug or intentional first though.
i'm trying to find where the change happened so i can find the commit it happened in and that should help me find out if it's sockbot that needs to change or if it's nodebb.
-
@accalia See the update thread? I'm not seeing a lot there though.
-
@Yamikuronue said in The One Where the Hedgehog Wears a Deerstalker ο’:
@accalia See the update thread? I'm not seeing a lot there though.
i saw. am consulting GIT now..... i will find it.
or die trying.
-
@accalia ο ο ???
-
hokay....... this is def a nodebb bug.
event:new_notification
is emitted by the server hereassuming that the waterfall function chain that call is contained in passes (the only thing that looks like it might be interfereing is that call to
filter:notification.push
)If my assumption holds then the pushToUIDs function must not be getting called, but where is it called from?
here obviously.
is one of those tests failing and aborting early? dunno, but i'm out of time for debugging.
paging @ben_lubar for rollback or escalation.
she's borken, please fix.
-
@accalia said in The One Where the Hedgehog Wears a Deerstalker ο’:
is one of those tests failing and aborting early? dunno, but i'm out of time for debugging.
In that case, I shall continue, otherwise the fork I just made was a waste of time
Edit: 119563 objects. I might be waiting a whileβ¦
-
@accalia or @boomzilla if he's more available
-
Progress so far
The latest update included an upgrade for the Socket.io packages:
It's possible one of them contains a breaking change, but I'm not going to go spelunking in their codebases just yet.
I've yet to find anything else though.
-
@Yamikuronue said in The One Where the Hedgehog Wears a Deerstalker ο’:
I'm getting no notifications for chat notices
I'm getting normal notifications (the bell dropdown) that someone sent me a message, but nothing on the chat icon and their avatar isn't floating down at the bottom.
-
@Yamikuronue said in The One Where the Hedgehog Wears a Deerstalker ο’:
@accalia or @boomzilla if he's more available
Not today, unfortunately.
-
Right⦠so⦠um⦠OK. Here's the thing. Turns out, if I have myself logged in on Sky Patrol (only) and RPBot logged in on Sally (only), my notifications and unread count work perfectly.
But it doesn't work when anyone else triggers a notification.
Unless someone's able to suggest a new avenue of investigation, I'm gonna have to call time on my efforts here, as I've hit a brick wall. Not literally of course, as literally hitting a wall would cause an owie.
/me toddles off to make dinner
-
@boomzilla I have chat messages from today, but in my notification history, the only notifications from that user are from threads he's posted in.
-
The unread count normally updates fine for me, but today that's borked for me too. It's stuck on 8 and I don't have unread topics anymore.
-
β¦and now notifications and unread counts are working fine for me, regardless of anything else
-
@RaceProUK To get PMs, I have to refresh the page, then open the chat box itself, because I won't get a notification and also I might not see the PM without a refresh.
-
@RaceProUK said in The One Where the Hedgehog Wears a Deerstalker ο’:
β¦and now notifications and unread counts are working fine for me, regardless of anything else
Just as I say that, they break again
-
-
@accalia @RaceProUK @boomzilla @Yamikuronue
Statistically, if you get the notification for this post, the problem is fixed.
-
@ben_lubar said in The One Where the Hedgehog Wears a Deerstalker ο’:
@accalia @RaceProUK @boomzilla @Yamikuronue
Statistically, if you get the notification for this post, the problem is fixed.
if that's the case then.....
@yamibot help
-
Registered commands:
help: print command help listing
roll: Roll some dice
rollfate: Roll dice for Fate
rollscion: Roll dice for Scion
rollww: Roll dice for White Wolf games* Help topic available.
Issue the
help
command with an available help topic as a parameter to read additonal help
-
@yamibot said in The One Where the Hedgehog Wears a Deerstalker ο’:
Registered commands:
help: print command help listing
roll: Roll some dice
rollfate: Roll dice for Fate
rollscion: Roll dice for Scion
rollww: Roll dice for White Wolf games* Help topic available.
Issue the
help
command with an available help topic as a parameter to read additonal helpyeah we're good.
-
@accalia ok, I'll send a PR.
-
@ben_lubar said in The One Where the Hedgehog Wears a Deerstalker ο’:
@accalia @RaceProUK @boomzilla @Yamikuronue
Statistically, if you get the notification for this post, the problem is fixed.
now..... what the flip did you actually do to fix this?!
-
@ben_lubar I did see a notification pop up, then disappear almost immediately (I was already in the thread and it streamed in).
So, what was the fix? The
return_buffers
thing?Edit: I posted this, and
suddenly appeared before it :D
-
@accalia said in The One Where the Hedgehog Wears a Deerstalker ο’:
now..... what the flip did you actually do to fix this?!
Best guess: he turned
return_buffers
off
-