:older_man: Pepperridge farms remembers View Raw being useful
-
Not only is View Raw now tucked away in a side menu requiring extra clicks, but if you try to quote in that mode (maybe to avoid losing emoji and formatting), it will quote the entire post, regardless of how much you have selected.
-
@pydsigner said in
Pepperridge farms remembers View Raw being useful:Not only is View Raw now tucked away in a side menu requiring extra clicks, but if you try to quote in that mode (maybe to avoid losing emoji and formatting), it will quote the entire post, regardless of how much you have selected.
I think that's because the View Raw doesn't replace the post per se, but hide it and adds a new element with the raw, and the quote-to-select handler doesn't see that you've selected anything (hence the full post quote).
-
@Tsaukpaetra said in
Pepperridge farms remembers View Raw being useful:@pydsigner said in
Pepperridge farms remembers View Raw being useful:Not only is View Raw now tucked away in a side menu requiring extra clicks, but if you try to quote in that mode (maybe to avoid losing emoji and formatting), it will quote the entire post, regardless of how much you have selected.
I think that's because the View Raw doesn't replace the post per se, but hide it and adds a new element with the raw, and the quote-to-select handler doesn't see that you've selected anything (hence the full post quote).
It used to work though!
-
@pydsigner said in
Pepperridge farms remembers View Raw being useful:@Tsaukpaetra said in
Pepperridge farms remembers View Raw being useful:@pydsigner said in
Pepperridge farms remembers View Raw being useful:Not only is View Raw now tucked away in a side menu requiring extra clicks, but if you try to quote in that mode (maybe to avoid losing emoji and formatting), it will quote the entire post, regardless of how much you have selected.
I think that's because the View Raw doesn't replace the post per se, but hide it and adds a new element with the raw, and the quote-to-select handler doesn't see that you've selected anything (hence the full post quote).
It used to work though!
Define "work"...
-
@pydsigner said in
Pepperridge farms remembers View Raw being useful:It used to work though!
I'm pretty sure that's because
looks for the quoted text in original raw by using substring matching instead of just using the user selection, which resulted in other kinds of hilarity.I'm guessing it should be possible to do with current implementation as well? The raw area might just need proper
classordata-attributes, or, alternatively, it might be set to look for text in a different element if raw is visible?
-
@Onyx said in
Pepperridge farms remembers View Raw being useful:@pydsigner said in
Pepperridge farms remembers View Raw being useful:It used to work though!
I'm pretty sure that's because
looks for the quoted text in original raw by using substring matching instead of just using the user selection, which resulted in other kinds of hilarity.I'm guessing it should be possible to do with current implementation as well? The raw area might just need proper
classordata-attributes, or, alternatively, it might be set to look for text in a different element if raw is visible?No I mean, it worked right when it was added to NodeBB last year, at least before it got moved to the hidden menu. I wasn't here for the discodays.
-
@pydsigner said in
Pepperridge farms remembers View Raw being useful:No I mean, it worked right when it was added to NodeBB last year, at least before it got moved to the hidden menu. I wasn't here for the discodays.
Huh... well, possibly a change in core we didn't notice? Sadly, I can't remember who did the raw plugin, though I'm pretty sure it was either @boomzilla or @ben_lubar
-
@Onyx Not me. I think maybe @ben_lubar incorporated a user script that...uh...@anotherusername (?) wrote?
-
@pydsigner Might be related to the fix that made it so you can't quote the post chrome by selection anymore?
-
@pydsigner probably at some point the highlight quoter was modified to restrict its selection to the post's main content element. The raw element is outside of that, so it's seeing nothing and quoting the whole post.
@boomzilla yes, the view raw script was something I'd written in my userscript. I'd originally made it a button next to "reply", but people complained that it broke their "click first blue button to reply" workflow so it was moved under the menu instead. Also the reply as topic option was from my userscript, and shared some of the same code (it also has to fetch the raw post to quote it).
