Last update completely fucked things somehow (details)

Lorne Kates

Every single action I take throws the same error:

TypeError: document.querySelectorAll(...).forEach is not a function
https://what.thedailywtf.com/nodebb.min.js?3c7e2a07909e
Line 13

Every scroll does this of these into the error log. Each keystroke as I type this does it. (Sorry, not each keystroke, but every few seconds while typing-- a typing timeout? Probably some preview dumbshittery, which is funny because I have preview turned off).

If I REPLY to a post, the composed doesn't get focused. I get this instead.

Not good. =(

RaceProUK

@Lorne-Kates Does it still happen if you do Ctrl+F5?

Lorne Kates

@RaceProUK said in Last update completely fucked things somehow (details):

@Lorne-Kates Does it still happen if you do Ctrl+F5?

Yes.

Lorne Kates

For fuck's sake, did anyone test this?

Chris Coyier / Nov 13, 2018

Loop Over querySelectorAll Matches | CSS-Tricks

Let's look at some options for iterating over a NodeList, as you get back from running a document.querySelectorAll.

You can loop over Arrays really easily in JavaScript with forEach, but unfortunately it's not that simple with the results of a querySelectorAll.

RaceProUK

@Lorne-Kates Looks isolated to Firefox; those errors don't happen in Chrome.

Tested in both the latest Chrome (54.0.2840.99 m) and Firefox (47.0.2... which just updated to 50.0(!) where it doesn't happen?)

bb36e

Tl;dr

This site best viewed in Google® Chrome™ at a resolution of 640 x 480

Arantor

@bb36e unless you're stuck at 1024x768 help I hope this reads ok

Polygeekery

@Lorne-Kates said in Last update completely fucked things somehow (details):

@RaceProUK said in Last update completely fucked things somehow (details):

@Lorne-Kates Does it still happen if you do Ctrl+F5?

Yes.

Have you tried turning it off, and then turning it back on again?

Arantor

@Polygeekery no amount of that will fix Firefox not supporting things. For once it isn't even an FF22 issue...

Rhywden

Better question: Who the fuck updates to a new function without a fallback for browsers which don't have that feature?

I mean, sometimes you simply cannot update to a later version easily.

And for the record: Edge also doesn't have this yet (and thus shows the same message).

anotherusername

@Lorne-Kates said in Last update completely fucked things somehow (details):

TypeError: document.querySelectorAll(...).forEach is not a function

...well, that wouldn't work in FF 22... it's like the newest of the new thing. Chrome 51.0 and Firefox 50.0 support it.

@ben_lubar why aren't we polyfilling it, or just using a workaround?

Pretty sure all it'd take to polyfill it would be this:

NodeList.prototype.forEach = NodeList.prototype.forEach || Array.prototype.forEach;

@Lorne-Kates can you execute that in the console and see if it stops the errors?

Rhywden

@anotherusername In Edge, this stops the console spam but not without throwing another error (this time only once, though):

SCRIPT438: Object doesn't support property or method 'closest'
nodebb.min.js (13,4363)

anotherusername

@Rhywden

if (!Element.prototype.matches) {
    Element.prototype.matches = 
        Element.prototype.matchesSelector || 
        Element.prototype.mozMatchesSelector ||
        Element.prototype.msMatchesSelector || 
        Element.prototype.oMatchesSelector || 
        Element.prototype.webkitMatchesSelector ||
        function (s) {
            var matches = (this.document || this.ownerDocument).querySelectorAll(s),
                i = matches.length;
            while (--i >= 0 && matches.item(i) !== this) {}
            return i > -1;            
        };
}

if (!Element.prototype.closest) {
    Element.prototype.closest = function (s) {
        for (var e = this; e && !e.matches(s); e = e.parentElement);
        return e;
    };
}

Rhywden

@anotherusername Seems to have done the trick.

Lorne Kates

@Arantor said in Last update completely fucked things somehow (details):

@Polygeekery no amount of that will fix Firefox not supporting things. For once it isn't even an FF22 issue...

I never complain about things that are FF22 only.

Lorne Kates

@Rhywden said in Last update completely fucked things somehow (details):

@anotherusername Seems to have done the trick.

Yup. Let's hope I never have to refresh.

Arantor

@Lorne-Kates if I could see what I was typing, I'd have done an emoji to indicate I wasn't super serious.

ben_lubar

@Rhywden said in Last update completely fucked things somehow (details):

SCRIPT438: Object doesn't support property or method 'closest'

What the... I found that while testing and I'm sure I fixed it!

Lorne Kates

@ben_lubar said in Last update completely fucked things somehow (details):

@Rhywden said in Last update completely fucked things somehow (details):

SCRIPT438: Object doesn't support property or method 'closest'

What the... I found that while testing and I'm sure I fixed it!

Ah, one of those famous "Itshud" fixes.

Have you done this change?
Yes
Does it work?
{mumble} itshud.
Huh?
I-- uh-- well-- it should work.
But DOES it?
Umm... {demos, instantly fails}
I'll check back in half-an-hour for a itduz solution...

dkf

Is there a reason for the YUUUUGE font used while editing? We used to use one the same size as when reading, but no longer it seems.

OTOH, I like the “3 MONTHS LATER” inline banner when a thread restarts after a long time.

ben_lubar

@Lorne-Kates said in Last update completely fucked things somehow (details):

@ben_lubar said in Last update completely fucked things somehow (details):

@Rhywden said in Last update completely fucked things somehow (details):

SCRIPT438: Object doesn't support property or method 'closest'

What the... I found that while testing and I'm sure I fixed it!

Ah, one of those famous "Itshud" fixes.

Have you done this change?
Yes
Does it work?
{mumble} itshud.
Huh?
I-- uh-- well-- it should work.
But DOES it?
Umm... {demos, instantly fails}
I'll check back in half-an-hour for a itduz solution...

I checked the source files and there are no references to Node.closest (I changed all of them to use jQuery) or NodeList.forEach (I changed it to use jQuery).

In fact, I can browse this forum on Firefox 22 without the issue you're saying still exists happening.

Can you view source and tell me what the code after nodebb.min.js? is? (Right before </head>) It should be 7002924311d1 right now.

ben_lubar

@dkf said in Last update completely fucked things somehow (details):

Is there a reason for the YUUUUGE font used while editing? We used to use one the same size as when reading, but no longer it seems.

Ok, I'm confused now, because that was part of the broken composer update that I rolled back. Is the old NodeBB instance still running or something?

dkf

@ben_lubar said in Last update completely fucked things somehow (details):

Ok, I'm confused now, because that was part of the broken composer update that I rolled back. Is the old NodeBB instance still running or something?

No idea; it's just quite a lot larger than it used to be. Here's what I'm seeing (for the record, I have no user stylesheet applied and I have hard-refreshed since I saw this as I thought it might've been a broken CSS fetch).

0_1480114563791_upload-a5bf1057-e546-4a4d-9c7d-c37976471b06

ben_lubar

@dkf said in Last update completely fucked things somehow (details):

@ben_lubar said in Last update completely fucked things somehow (details):

Ok, I'm confused now, because that was part of the broken composer update that I rolled back. Is the old NodeBB instance still running or something?

No idea; it's just quite a lot larger than it used to be. Here's what I'm seeing (for the record, I have no user stylesheet applied and I have hard-refreshed since I saw this as I thought it might've been a broken CSS fetch).

If you quote this post, does the textarea get squished really narrow?

AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA

dkf

@ben_lubar said in Last update completely fucked things somehow (details):

If you quote this post, does the textarea get squished really narrow?

Yes.

dkf

I also end up feeling like you're making a comment on the state of world politics. ;)

Maciejasjmj

@dkf said in Last update completely fucked things somehow (details):

@ben_lubar said in Last update completely fucked things somehow (details):

If you quote this post, does the textarea get squished really narrow?

Yes.

Norepro on the latest version. Guess you just need to hard refresh... harder?

Maciejasjmj

Also, got hit by a somewhat bizarre bug:

ben_lubar

@Maciejasjmj it seems that Chrome doesn't know how to handle >[space][soft line break].